Skip to content

Commit 99443b9

Browse files
committed
make sur ebash fails fast
cf. devcontainers/ci#294
1 parent cd237b8 commit 99443b9

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

.github/workflows/ci.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ on:
66
branches:
77
- main
88

9-
defaults:
10-
run:
11-
shell: bash
12-
139
concurrency:
1410
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
1511
cancel-in-progress: true
@@ -42,6 +38,8 @@ jobs:
4238
# We want to only use it for building and testing the actual container, which resides in src/s-core-devcontainer.
4339
push: "never"
4440
runCmd: |
41+
set -euxo pipefail # make sure bash fails fast on errors
42+
4543
# Check
4644
pre-commit run --show-diff-on-failure --color=always --all-files || exit -1
4745

.github/workflows/release.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ on:
55
tags:
66
- '[0-9]+.[0-9]+.[0-9]+'
77

8-
defaults:
9-
run:
10-
shell: bash
11-
128
jobs:
139
build:
1410
name: 'Check, Build, Test, Publish DevContainer'
@@ -37,6 +33,8 @@ jobs:
3733
# We want to only use it for building and testing the actual container, which resides in src/s-core-devcontainer.
3834
push: "never"
3935
runCmd: |
36+
set -euxo pipefail # make sure bash fails fast on errors
37+
4038
# Check
4139
pre-commit run --show-diff-on-failure --color=always --all-files || exit -1
4240

0 commit comments

Comments
 (0)