Skip to content

Commit d8aa6b3

Browse files
committed
fix: do not automatically run gen_rust_project
This fails if the project is not a Rust project. So this can be quite annoying.
1 parent b2cec61 commit d8aa6b3

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Open a Terminal, and - for example - type `bazel build ...` to execute the defau
5252
After you have build the code, create [compilation databases](https://clang.llvm.org/docs/JSONCompilationDatabase.html) via Visual Studio Code [Task](https://code.visualstudio.com/docs/debugtest/tasks):
5353

5454
- C++: <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>p</kbd> -> `Tasks: Run Task` -> `Update compile_commands.json`
55-
- Rust: <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>p</kbd> -> `Tasks: Run Task` -> `Generate rust-project.json`
55+
- Rust: <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>p</kbd> -> `Tasks: Run Task` -> `Update rust-project.json`
5656

5757
These databases are used by Visual Studio Code to support code navigation and auto-completion with the help of [language servers](https://microsoft.github.io/language-server-protocol/).
5858

src/s-core-devcontainer/.devcontainer/devcontainer.json

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@
6464
"bazelbuild.vscode-bazel", // Bazel support for Visual Studio Code; see also bazel.lsp.command below
6565
"dbaeumer.vscode-eslint",
6666
"EditorConfig.EditorConfig",
67-
"ms-vscode.live-server", // for live preview of HTML files
67+
"ms-vscode.live-server", // live preview of HTML files
6868
"llvm-vs-code-extensions.vscode-clangd",
69-
"jebbs.plantuml", //to preview PlantUML diagrams
70-
"hediet.vscode-drawio", //for drawio integration
69+
"jebbs.plantuml", // preview PlantUML diagrams
70+
"hediet.vscode-drawio", // Draw.IO integration
7171
"swyddfa.esbonio", // for Sphinx documentation support
7272
"rust-lang.rust-analyzer" // Rust language support for Visual Studio Code; see also tasks below
7373
],
@@ -108,7 +108,7 @@
108108
}
109109
},
110110
{ // see https://bazelbuild.github.io/rules_rust/rust_analyzer.html#vscode
111-
"label": "Generate rust-project.json",
111+
"label": "Update rust-project.json",
112112
"command": "bazel",
113113
"args": [
114114
"run",
@@ -117,15 +117,7 @@
117117
"options": {
118118
"cwd": "${workspaceFolder}"
119119
},
120-
"group": "build",
121-
"problemMatcher": [],
122-
"presentation": {
123-
"reveal": "never",
124-
"panel": "dedicated"
125-
},
126-
"runOptions": {
127-
"runOn": "folderOpen"
128-
}
120+
"group": "build"
129121
}
130122
]
131123
}

0 commit comments

Comments
 (0)