process: include review findings

Ref: closes #102

Author: PandaeDo

src/extensions/score_metamodel/metamodel.yaml

@@ -509,15 +509,16 @@ needs_types:
     title: DFA
     prefix: feat_plat_saf_dfa__
     mandatory_options:
-      id: ^gd_guidl__dfa_failure_initiators__[0-9a-z_]*$
+      id: ^feat_plat_saf_dfa__[0-9a-z_]+$
       violation_id: ^.*$
       violation_cause: ^.*$
-      mitigation_issue: ^https://github.com/.*$
       sufficient: ^(yes|no)$
       status: ^(valid|invalid)$
-      mandatory_links:
-        mitigates: ^(feat_req__.*|aou_req__.*|)$
-        verifies: ^feat_arc_sta__[0-9a-z_]*$
+    mandatory_links:
+        mitigates: ^(feat_req__.*|aou_req__.*)$
+        verifies: ^feat_arc_dyn__[0-9a-z_]*$
+    optional_links:
+        mitigation_issue: ^https://github.com/.*$
 
   feat_saf_dfa:
     title: DFA
@@ -526,56 +527,59 @@ needs_types:
       id: ^feat_saf_dfa__[0-9a-z_]+$
       violation_id: ^.*$
       violation_cause: ^.*$
-      mitigation_issue: ^https://github.com/.*$
       sufficient: ^(yes|no)$
       status: ^(valid|invalid)$
-      mandatory_links:
-        mitigates: ^(feat_req__.*|aou_req__.*|)$
-        verifies: ^feat_arc_sta__[0-9a-z_]*$
+    mandatory_links:
+        mitigates: ^(feat_req__.*|aou_req__.*)$
+        verifies: ^feat_arc_dyn__[0-9a-z_]*$
+    optional_links:
+        mitigation_issue: ^https://github.com/.*$
 
   comp_saf_dfa:
     title: DFA
     prefix: comp_saf_dfa__
     mandatory_options:
-      id: ^gd_guidl__dfa_failure_initiators__[0-9a-z_]*$
+      id: ^comp_saf_dfa__[0-9a-z_]+$
       violation_id: ^.*$
       violation_cause: ^.*$
-      mitigation_issue: ^https://github.com/.*$
       sufficient: ^(yes|no)$
       status: ^(valid|invalid)$
-      mandatory_links:
-        mitigates: ^(comp_req__.*|aou_req__.*|)$
-        verifies: ^comp_arc_sta__[0-9a-z_]*$
+    mandatory_links:
+        mitigates: ^(comp_req__.*|aou_req__.*)$
+        verifies: ^comp_arc_dyn__[0-9a-z_]*$
+    optional_links:
+        mitigation_issue: ^https://github.com/.*$
 
   # # Safety Analysis FMEA
   feat_saf_fmea:
     title: FMEA
     prefix: feat_saf_fmea__
     mandatory_options:
-      id: ^gd_guidl__fault_models__[0-9a-z_]*$
+      id: ^feat_saf_fmea__[0-9a-z_]+$
       violation_id: ^.*$
       violation_cause: ^.*$
-      mitigation_issue: ^https://github.com/.*$
       sufficient: ^(yes|no)$
       status: ^(valid|invalid)$
-      mandatory_links:
-        mitigates: ^(feat_req__.*|aou_req__.*|)$
+    mandatory_links:
+        mitigates: ^(feat_req__.*|aou_req__.*)$
         verifies: ^feat_arc_dyn__[0-9a-z_]*$
+    optional_links:
+        mitigation_issue: ^https://github.com/.*$
 
   comp_saf_fmea:
     title: FMEA
     prefix: comp_saf_fmea__
     mandatory_options:
-      id: ^gd_guidl__fault_models__[0-9a-z_]*$
+      id: ^comp_saf_fmea__[0-9a-z_]+$
       violation_id: ^.*$
       violation_cause: ^.*$
-      mitigation_issue: ^https://github.com/.*$
       sufficient: ^(yes|no)$
-      argument: ^.+$
       status: ^(valid|invalid)$
-      mandatory_links:
-        mitigates: ^(comp_req__.*|aou_req__.*|)$
+    mandatory_links:
+        mitigates: ^(comp_req__.*|aou_req__.*)$
         verifies: ^comp_arc_dyn__[0-9a-z_]*$
+    optional_links:
+        mitigation_issue: ^https://github.com/.*$
 
 # Extra link types, which shall be available and allow need types to be linked to each other.
 # We use a dedicated linked type for each type of a connection, for instance from
@@ -653,6 +657,10 @@ needs_extra_links:
   mitigates:
     incoming: mitigated by
     outgoing: mitigates
+
+  verifies:
+    incoming: verified by
+    outgoing: verifies
 ##############################################################
 # Graph Checks
 # The graph checks focus on the relation of the needs and their attributes.
@@ -701,4 +709,3 @@ graph_checks:
       condition: safety == ASIL_B
     check:
       mitigates: safety != QM
-

src/extensions/score_metamodel/tests/rst/graph/test_metamodel_graph.rst

@@ -33,6 +33,7 @@
    :safety: ASIL_D
    :status: valid
 
+
 .. Positive Test: Child requirement QM. Parent requirement has the correct related safety level. Parent requirement is `QM`.
 #EXPECT-NOT: feat_req__child__1: parent need `feat_req__parent__QM` does not fulfill condition `safety == QM`.
 

src/extensions/score_metamodel/tests/rst/options/test_options_options.rst

@@ -68,6 +68,25 @@
 .. stkh_req:: Parent requirement
    :id: stkh_req__abcd
 
+.. List of elements which an attribute safety. Preparation of a test that actually could be need to ensure that ASIL_D is not used.
+.. doc__
+.. stkh_req__
+.. feat_req__
+.. comp_req__
+.. tool_req__
+.. aou_req__
+.. feat_arc_sta__
+.. feat_arc_dyn__
+.. logic_arc_int__
+.. logic_arc_int_op__
+.. comp_arc_sta__
+.. comp_arc_dyn__
+.. real_arc_int__
+.. real_arc_int_op__
+.. dd_sta__
+.. dd_dyn__
+.. sw_unit__
+
 
 .. Test if the `sufficient` option for Safety Analysis (FMEA and DFA) follows the pattern `^(yes|no)$`
 #EXPECT: feat_saf_fmea__test__bad_1.sufficient (QM): does not follow pattern `^(yes|no)$`.
@@ -159,3 +178,36 @@
 .. comp_saf_dfa:: This is a test
    :id: comp_saf_dfa__test__15
    :sufficient: no
+
+.. Test that the `sufficient` option is case sensitive and does not accept values other than `yes` or `no`
+#EXPECT: feat_saf_fmea__test__bad_16.sufficient (yEs): does not follow pattern `^(yes|no)$`.
+
+.. feat_saf_fmea:: This is a test
+   :id: feat_saf_fmea__test__bad_16
+   :sufficient: yEs
+
+
+
+.. comp_req:: Child requirement ASIL_B
+   :id: comp_req__child__ASIL_B
+   :safety: ASIL_B
+   :status: valid
+
+
+.. Negative Test: Linked to a non-allowed requirement type.
+#EXPECT: feat_saf_fmea__child__25.mitigates (['comp_req__child__ASIL_B']): does not follow pattern `^(feat_req__.*|aou_req__.*)$`.
+
+.. feat_saf_fmea:: Child requirement 25
+   :id: feat_saf_fmea__child__25
+   :safety: ASIL_B
+   :status: valid
+   :mitigates: comp_req__child__ASIL_B
+
+.. Negative Test: Linked to a non-allowed requirement type.
+#EXPECT: feat_saf_fmea__child__26.verifies (['comp_req__child__ASIL_B']): does not follow pattern `^feat_arc_dyn__[0-9a-z_]*$`.
+
+.. feat_saf_fmea:: Child requirement 26
+   :id: feat_saf_fmea__child__26
+   :safety: ASIL_B
+   :status: valid
+   :verifies: comp_req__child__ASIL_B