fix cleaning of external prefix (#68)

Author: MaximilianSoerenPollak

src/extensions/score_metamodel/checks/check_options.py

@@ -77,9 +77,8 @@ def remove_prefix(word: str, prefixes: list[str]) -> str:
             values = [str(raw_value)]
 
         # The filter ensures that the function is only called when needed.
-
         for value in values:
-            if field_type == "link" and allowed_prefixes:
+            if allowed_prefixes:
                 value = remove_prefix(value, allowed_prefixes)
             try:
                 if not re.match(pattern, value):

src/extensions/score_metamodel/tests/test_check_options.py

@@ -141,6 +141,7 @@ def test_missing_mandatory_options_info(self):
         app = Mock(spec=Sphinx)
         app.config = Mock()
         app.config.needs_types = self.NEED_TYPE_INFO_WITHOUT_MANDATORY_OPTIONS
+        app.config.allowed_external_prefixes = []
         # Expect that the checks pass
         check_options(app, need_1, logger)
         logger.assert_warning(
@@ -165,6 +166,7 @@ def test_invalid_option_type(self):
         app = Mock(spec=Sphinx)
         app.config = Mock()
         app.config.needs_types = self.NEED_TYPE_INFO_WITH_INVALID_OPTION_TYPE
+        app.config.allowed_external_prefixes = []
         # Expect that the checks pass
         check_options(app, need_1, logger)
         logger.assert_warning(
@@ -190,6 +192,7 @@ def test_unknown_option_present_in_neither_req_opt_neither_opt_opt(self):
         app = Mock(spec=Sphinx)
         app.config = Mock()
         app.config.needs_types = self.NEED_TYPE_INFO_WITH_OPT_OPT
+        app.config.allowed_external_prefixes = []
         # Expect that the checks pass
         check_extra_options(app, need_1, logger)