Skip to content

Commit 1b1d2b6

Browse files
committed
adding cpp tests for default values
Refactor C++ main exception handling to use unique exit codes for errors. Extract hash file creation into a separate function for clarity. Remove redundant temp_dir logic from Python fixtures and rely on pytest setup. Remove leftover get_binary usage in pytest configuration. Suppress unnecessary defaults file warnings in conftest.py. Replace explicit srcs list with glob in Bazel BUILD for maintainability. Adding the xfail and bug details . merging with the fixed bug changes for hash file
1 parent 8699447 commit 1b1d2b6

File tree

10 files changed

+910
-115
lines changed

10 files changed

+910
-115
lines changed

.github/workflows/check.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,4 +184,5 @@ jobs:
184184
rm ${OUT_FILE}
185185
186186
- name: Bazel Benchmark
187-
run: bazel run -c opt //:bm_kvs_cpp
187+
run: |
188+
bazel run -c opt //:bm_kvs_cpp

tests/cpp_test_scenarios/BUILD

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@ load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
1414

1515
cc_binary(
1616
name = "cpp_test_scenarios",
17-
srcs = [
18-
"src/main.cpp",
19-
"src/test_basic.cpp",
20-
"src/test_basic.hpp",
21-
],
17+
srcs = glob([
18+
"src/**/*.cpp",
19+
"src/**/*.hpp",
20+
]),
2221
copts = [
2322
"-g",
23+
"-Isrc",
24+
"-Isrc/cit",
25+
"-Isrc/helpers",
2426
],
2527
visibility = ["//visibility:public"],
2628
deps = [

0 commit comments

Comments
 (0)