Skip to content

Commit 256dd55

Browse files
committed
Fix mw/log target deps while importing logging
- library targets uses on the frontend - while test targets provide the concrete backends. For unit tests a lightweight console recorder with console logging backend is sufficient. - for a binary target a log target that includes all backends can be used.
1 parent 9b36cbe commit 256dd55

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

MODULE.bazel

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,3 +160,11 @@ register_toolchains(
160160

161161
# S-CORE crates
162162
bazel_dep(name = "score_crates", version = "0.0.6")
163+
164+
# S-CORE Logging
165+
bazel_dep(name = "score_logging", version = "", dev_dependency = True)
166+
git_override(
167+
module_name = "score_logging",
168+
commit = "d5267a5d89ca7462bec29c49d3b295a10ee834c3", # latest
169+
remote = "https://github.com/eclipse-score/logging.git",
170+
)

src/cpp/src/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ cc_library(
4949
"//src/cpp/src/internal:error",
5050
"@score_baselibs//score/filesystem",
5151
"@score_baselibs//score/json",
52-
"@score_baselibs//score/mw/log",
52+
"@score_baselibs//score/mw/log:frontend",
5353
"@score_baselibs//score/result",
5454
],
5555
)

src/cpp/tests/BUILD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ cc_test(
3131
"@score_baselibs//score/filesystem:mock",
3232
"@score_baselibs//score/json:mock",
3333
"@score_baselibs//score/result",
34+
"@score_baselibs//score/mw/log:backend_stub_testutil",
3435
],
3536
)
3637

@@ -48,5 +49,6 @@ cc_test(
4849
"@score_baselibs//score/filesystem",
4950
"@score_baselibs//score/json",
5051
"@score_baselibs//score/result",
52+
"@score_baselibs//score/mw/log:backend_stub_testutil",
5153
],
5254
)

tests/test_scenarios/cpp/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ cc_binary(
2727
visibility = ["//visibility:public"],
2828
deps = [
2929
"//src/cpp/src:kvs_cpp",
30+
"@score_logging//mw/log",
3031
"@score_test_scenarios//test_scenarios_cpp",
3132
],
3233
)

0 commit comments

Comments
 (0)