impl: logging support

- Support for `mw_log` with C++ backend for Bazel.
- Support for `log` for Cargo.
- Add more logs.
- Fix tests.
- Disable `score-log` feature in CI check.

Author: arkjedrz

.bazelrc

@@ -25,12 +25,11 @@ build --tool_java_language_version=17
 build --java_runtime_version=remotejdk_17
 build --tool_java_runtime_version=remotejdk_17
 
+build --@score_baselibs_rust//src/log:safety_level=qm
 build --@score_baselibs//score/json:base_library=nlohmann
 build --@score_baselibs//score/mw/log/flags:KRemote_Logging=False
 
-# ToDo: needed for "wrong" implicit dependencies
-build --@score-baselibs//score/json:base_library=nlohmann
-build --@score-baselibs//score/mw/log/flags:KRemote_Logging=False
+common --extra_toolchains=@gcc_toolchain//:host_gcc_12
 
 # Clippy linting (enabled by default)
 build --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect

.github/workflows/check.yml

@@ -38,7 +38,7 @@ jobs:
 
       - name: Cargo Clippy
         run: |
-          cargo clippy --all-targets --all-features
+          cargo clippy --all-targets --features logging -- -D warnings
 
       - name: Cargo Fmt
         run: |

Cargo.lock

@@ -46,7 +46,7 @@ bazel_dep(name = "score_rust_policies", version = "0.0.2", dev_dependency = True
 rust = use_extension("@rules_rust//rust:extensions.bzl", "rust", dev_dependency = True)
 rust.toolchain(
     edition = "2021",
-    versions = ["1.85.0"],
+    versions = ["1.90.0"],
 )
 
 # bazel cc rules
@@ -85,16 +85,19 @@ bazel_dep(name = "google_benchmark", version = "1.9.4", dev_dependency = True)
 bazel_dep(name = "platforms", version = "1.0.0")
 
 ## S-CORE bazel registry
-bazel_dep(name = "score_baselibs", version = "0.1.2")
-bazel_dep(name = "score_bazel_platforms", version = "0.0.2")
-bazel_dep(name = "score_docs_as_code", version = "2.2.0")
-bazel_dep(name = "score_platform", version = "0.5.0")
+bazel_dep(name = "score_baselibs", version = "0.2.2")
+bazel_dep(name = "score_baselibs_rust", version = "0.0.1")
+
+# TODO: replace with stable version.
 git_override(
-    module_name = "score_platform",
-    commit = "9d30b718db22ad335cccbcfd72f96e5b37fa58f1",  # obsolete by 0.5.1+
-    remote = "https://github.com/eclipse-score/score.git",
+    module_name = "score_baselibs_rust",
+    commit = "18160f840f6623a38b0cb3cd58576cbaf0cf03f6",
+    remote = "https://github.com/eclipse-score/baselibs_rust.git",
 )
 
+bazel_dep(name = "score_bazel_platforms", version = "0.0.2")
+bazel_dep(name = "score_docs_as_code", version = "2.2.0")
+bazel_dep(name = "score_platform", version = "0.5.0")
 bazel_dep(name = "score_process", version = "1.3.2")
 bazel_dep(name = "score_python_basics", version = "0.3.4")
 bazel_dep(name = "score_tooling", version = "1.0.3")
@@ -107,6 +110,13 @@ git_override(
     remote = "https://github.com/eclipse-score/tooling.git",
 )
 
+bazel_dep(name = "score_logging", version = "0.0.3")
+git_override(
+    module_name = "score_logging",
+    commit = "cd7528ce86c6eb5215a53dbbd3cdc761451e5a4b",
+    remote = "https://github.com/eclipse-score/logging.git",
+)
+
 # ToDo: implicit dependencies for score_tooling, but needed directly here??
 bazel_dep(name = "aspect_rules_lint", version = "1.10.2")
 bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2")
@@ -156,6 +166,22 @@ archive_override(
     ],
 )
 
+# TODO: remove once inherited properly from `score_logging`.
+bazel_dep(name = "trlc")
+git_override(
+    module_name = "trlc",
+    commit = "650b51a47264a4f232b3341f473527710fc32669",  # trlc-2.0.2 release
+    remote = "https://github.com/bmw-software-engineering/trlc.git",
+)
+
+# TODO: remove once inherited properly from `score_logging`.
+bazel_dep(name = "score_communication", version = "0.1.2")
+git_override(
+    module_name = "score_communication",
+    commit = "5a70133dd8bd632f5c07f200a5ee4bc9f507c23b",
+    remote = "https://github.com/eclipse-score/communication.git",
+)
+
 # Registers the custom Rust toolchain wired to @qnx_rust
 register_toolchains(
     "@score_toolchains_rust//toolchains/aarch64-unknown-qnx8_0:toolchain_aarch64_qnx8_0",

MODULE.bazel

@@ -15,8 +15,10 @@ load("@rules_rust//rust:defs.bzl", "rust_library", "rust_test")
 rust_library(
     name = "rust_kvs",
     srcs = glob(["src/**/*.rs"]),
+    crate_features = ["score-log"],
     visibility = ["//visibility:public"],
     deps = [
+        "@score_baselibs_rust//src/log/mw_log",
         "@score_crates//:adler32",
         "@score_crates//:tinyjson",
     ],
@@ -25,6 +27,7 @@ rust_library(
 rust_test(
     name = "tests",
     crate = "rust_kvs",
+    crate_features = ["score-log"],
     tags = [
         "unit_tests",
         "ut",

src/rust/rust_kvs/BUILD

@@ -7,6 +7,13 @@ edition.workspace = true
 [dependencies]
 adler32.workspace = true
 tinyjson.workspace = true
+log = { version = "0.4.29", optional = true }
+
+
+[features]
+default = ["logging"]
+score-log = []
+logging = ["log"]
 
 
 [dev-dependencies]

src/rust/rust_kvs/Cargo.toml

@@ -11,11 +11,13 @@
 
 extern crate alloc;
 
+use crate::log::error;
 use alloc::string::FromUtf8Error;
 use core::array::TryFromSliceError;
 
 /// Runtime Error Codes
 #[derive(Debug, PartialEq)]
+#[cfg_attr(feature = "score-log", derive(mw_log::ScoreDebug))]
 pub enum ErrorCode {
     /// Error that was not yet mapped
     UnmappedError,
@@ -93,7 +95,7 @@ impl From<std::io::Error> for ErrorCode {
         match kind {
             std::io::ErrorKind::NotFound => ErrorCode::FileNotFound,
             _ => {
-                eprintln!("error: unmapped error: {kind}");
+                error!("Unmapped IO error: {:?}", kind.to_string());
                 ErrorCode::UnmappedError
             }
         }
@@ -102,21 +104,21 @@ impl From<std::io::Error> for ErrorCode {
 
 impl From<FromUtf8Error> for ErrorCode {
     fn from(cause: FromUtf8Error) -> Self {
-        eprintln!("error: UTF-8 conversion failed: {cause:#?}");
+        error!("Conversion from UTF-8 failed: {:#?}", cause);
         ErrorCode::ConversionFailed
     }
 }
 
 impl From<TryFromSliceError> for ErrorCode {
     fn from(cause: TryFromSliceError) -> Self {
-        eprintln!("error: try_into from slice failed: {cause:#?}");
+        error!("Conversion from slice failed: {:#?}", cause);
         ErrorCode::ConversionFailed
     }
 }
 
 impl From<Vec<u8>> for ErrorCode {
     fn from(cause: Vec<u8>) -> Self {
-        eprintln!("error: try_into from u8 vector failed: {cause:#?}");
+        error!("Conversion from vector of u8 failed: {:#?}", cause);
         ErrorCode::ConversionFailed
     }
 }