Skip to content

Commit bd0d88d

Browse files
committed
impl: Add error message checks
- error message checks in kvs_value.rs
1 parent 0979081 commit bd0d88d

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/rust/rust_kvs/src/json_backend.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ impl From<JsonValue> for KvsValue {
6666
.collect();
6767
KvsValue::Object(map)
6868
}
69-
JsonValue::Array(arr) => KvsValue::Array(arr.into_iter().map(KvsValue::from).collect()),
7069
// Remaining types can be handled with Null.
7170
_ => KvsValue::Null,
7271
}

src/rust/rust_kvs/src/kvs_value.rs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -288,14 +288,19 @@ mod tests {
288288
fn test_tryfrom_error_cases() {
289289
use std::f64::consts::PI;
290290
let v = KvsValue::from(123i32);
291-
assert!(u32::try_from(&v).is_err());
291+
let err = u32::try_from(&v).unwrap_err();
292+
assert_eq!(err, "KvsValue is not a u32");
292293
let v = KvsValue::from("abc");
293-
assert!(i32::try_from(&v).is_err());
294+
let err = i32::try_from(&v).unwrap_err();
295+
assert_eq!(err, "KvsValue is not a i32");
294296
let v = KvsValue::from(vec![KvsValue::from(1i32)]);
295-
assert!(bool::try_from(&v).is_err());
297+
let err = bool::try_from(&v).unwrap_err();
298+
assert_eq!(err, "KvsValue is not a bool");
296299
let v = KvsValue::from(PI);
297-
assert!(String::try_from(&v).is_err());
300+
let err = String::try_from(&v).unwrap_err();
301+
assert_eq!(err, "KvsValue is not a String");
298302
let v = KvsValue::from(());
299-
assert!(i32::try_from(&v).is_err());
303+
let err = i32::try_from(&v).unwrap_err();
304+
assert_eq!(err, "KvsValue is not a i32");
300305
}
301306
}

0 commit comments

Comments
 (0)