Initial Implementation of the CPP KVS#20
Merged
vinodreddy-g merged 4 commits intoeclipse-score:mainfrom Jun 25, 2025
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
Implementation of initial CPP KVS PoC done, Unittests implemented: 100% Line Coverage, 100% Function Coverage and 100% Branch Coverage
cf679e4 to
6635833
Compare
Copyright notice was updated to the format expected by score copyright.check
Add preprocessor directives to implement include guard behavior
5a6aa1c to
b742e79
Compare
umaucher
requested changes
Jun 24, 2025
umaucher
reviewed
Jun 24, 2025
umaucher
reviewed
Jun 24, 2025
umaucher
reviewed
Jun 24, 2025
Co-authored-by: Uwe <uwe.maucher@bmw.de> Signed-off-by: Joshua Licht <148043864+joshualicht@users.noreply.github.com> Rename kvs_helper.h Rename kvs_helper.h to kvs_helper.hpp
63ac1ca to
cb2e992
Compare
umaucher
approved these changes
Jun 25, 2025
vinodreddy-g
approved these changes
Jun 25, 2025
Contributor
|
Ci breaks because of other dependent libs as i understood . Should we merge it? @guysagnes |
Yes, Agree to merge in the next step until generic fix of CD is available. |
|
html report - code coverage Report from build |
atarekra
pushed a commit
to Valeo-S-CORE-Organization/persistency
that referenced
this pull request
Nov 9, 2025
Initial Implementation of the CPP KVS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial Implementation of CPP KVS
Features:
-Supports Score Filesystem
-Supports Score JSON (Notice: Score JSON (nlohmann) has a problem with serializing Bool types)
-Supports Score Result and Errorcodes
-Behavior Unittests with 100% Line Coverage, 100% Function Coverage and 100% Branch Coverage
(except for brackets that are reported incorrectly),
Command to generate Coverage and create html results:
bazel coverage test_kvs_cpp --collect_code_coverage --instrument_test_targets --combined_report=lcov --experimental_generate_llvm_lcov --nocache_test_results --nostamp; genhtml --branch-coverage --output genhtml "$(find "$(bazel info output_path)" -name _coverage_report.dat)"-Supports Bazel Build
-Doxygen Documentation
Not yet implemented/ To Dos:
-Set Default Value Handling TBD
-Add Score Logging
-Replace std libs with baselibs where possible
-Versioning of the CPP KVS (needs to be solved for CPP in general, not only for KVS)