Add kvs to builder as generic .#21
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
85e4fbb to
6ef3d97
Compare
6ef3d97 to
496d8ad
Compare
496d8ad to
6ed54b9
Compare
|
Can we please wait with this PR until the template refactoring (Rust and CPP coexistence) with my CPP implementation PR #20 is completed, since this PR moves us further away from the aligned cpp/rust template? |
guysagnes
left a comment
There was a problem hiding this comment.
Alignment requested about reorganization of the structure to be managed after C++ Implementation. Deviation from initial agreed templates.
Yeah , i discussed with Joshua , that i will wait until his PR is merged , then i will rebase this. |
99c1ec7 to
caa8b75
Compare
|
@guysagnes rebased it . |
- Added kvstype as default for builder - Added kvstrait as a type
- Substituted some libs to core and alloc from std.
- To enable cargo test again - Since kvs and kvs_tool have different deps.
- Build files format fixed
- Aligned to folder structure for cpp and rust.
caa8b75 to
627f84e
Compare
guysagnes
left a comment
There was a problem hiding this comment.
Looks okay -
Good approach to get test folder on the same level as source in context of the language specific implementation -
Alignment planned during https://github.com/orgs/eclipse-score/discussions/1231
Add kvs to builder as generic .
Add kvs to builder as generic and substitute possible std dependencies with core and alloc.