Skip to content

Add kvs to builder as generic .#21

Merged
vinodreddy-g merged 5 commits intoeclipse-score:mainfrom
qorix-group:vinod_kvs_generics
Jun 27, 2025
Merged

Add kvs to builder as generic .#21
vinodreddy-g merged 5 commits intoeclipse-score:mainfrom
qorix-group:vinod_kvs_generics

Conversation

@vinodreddy-g
Copy link
Contributor

@vinodreddy-g vinodreddy-g commented Jun 24, 2025

Add kvs to builder as generic and substitute possible std dependencies with core and alloc.

@vinodreddy-g vinodreddy-g changed the title Add kvs to builder as generic and substitute possible std dependencies with core and alloc. Add kvs to builder as generic . Jun 24, 2025
@github-actions
Copy link

github-actions bot commented Jun 24, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 602f5526-28c3-46c5-97ee-a20e0d5fcba4
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost~' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-7N1yXHXevuoJ1NWzjjzliNuRzyn2TgPJdC0uwAsVt68="
DEBUG: Repository rules_boost~ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:387:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version googletest@1.14.0, but got googletest@1.15.0 in the resolved dependency graph.
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.4.2 in the resolved dependency graph.
Loading: 
Loading: 1 packages loaded
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)

Analyzing: target //:license-check (55 packages loaded, 10 targets configured)

Analyzing: target //:license-check (102 packages loaded, 10 targets configured)

Analyzing: target //:license-check (157 packages loaded, 989 targets configured)

Analyzing: target //:license-check (169 packages loaded, 1968 targets configured)

Analyzing: target //:license-check (170 packages loaded, 2895 targets configured)

Analyzing: target //:license-check (170 packages loaded, 2895 targets configured)

Analyzing: target //:license-check (173 packages loaded, 4901 targets configured)

Analyzing: target //:license-check (175 packages loaded, 5145 targets configured)

Analyzing: target //:license-check (175 packages loaded, 5145 targets configured)

INFO: Analyzed target //:license-check (176 packages loaded, 7064 targets configured).
[8 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_dash_license_checker~/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:30:21: Generating Dash formatted dependency file ... failed: missing input file '//:cargo_lock'
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:30:21: Generating Dash formatted dependency file ... failed: 1 input file(s) do not exist
Target //:license.check.license_check failed to build
Use --verbose_failures to see the command lines of failed build steps.
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:30:21 Generating Dash formatted dependency file ... failed: 1 input file(s) do not exist
INFO: Elapsed time: 184.073s, Critical Path: 0.42s
INFO: 12 processes: 2 disk cache hit, 10 internal.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@vinodreddy-g vinodreddy-g requested a review from qor-lb June 24, 2025 12:24
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@vinodreddy-g vinodreddy-g removed the request for review from qor-lb June 24, 2025 12:28
@vinodreddy-g vinodreddy-g marked this pull request as draft June 24, 2025 12:29
@vinodreddy-g vinodreddy-g marked this pull request as ready for review June 24, 2025 14:23
@vinodreddy-g vinodreddy-g requested a review from qor-lb June 24, 2025 14:26
@joshualicht
Copy link
Contributor

joshualicht commented Jun 24, 2025

Can we please wait with this PR until the template refactoring (Rust and CPP coexistence) with my CPP implementation PR #20 is completed, since this PR moves us further away from the aligned cpp/rust template?

@guysagnes guysagnes self-requested a review June 25, 2025 09:56
Copy link

@guysagnes guysagnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment requested about reorganization of the structure to be managed after C++ Implementation. Deviation from initial agreed templates.

@vinodreddy-g
Copy link
Contributor Author

Alignment requested about reorganization of the structure to be managed after C++ Implementation. Deviation from initial agreed templates.

Yeah , i discussed with Joshua , that i will wait until his PR is merged , then i will rebase this.

@vinodreddy-g vinodreddy-g force-pushed the vinod_kvs_generics branch 2 times, most recently from 99c1ec7 to caa8b75 Compare June 25, 2025 13:24
@vinodreddy-g vinodreddy-g requested a review from guysagnes June 25, 2025 13:26
@vinodreddy-g
Copy link
Contributor Author

@guysagnes rebased it .

- Added kvstype as default for builder
- Added kvstrait as a type
- Substituted some libs to core and alloc from std.
- To enable cargo test again
- Since kvs and kvs_tool have different deps.
- Build files format fixed
- Aligned to folder structure for cpp and rust.
@vinodreddy-g vinodreddy-g dismissed guysagnes’s stale review June 26, 2025 11:38

rebased it and ci builds

Copy link

@guysagnes guysagnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay -
Good approach to get test folder on the same level as source in context of the language specific implementation -
Alignment planned during https://github.com/orgs/eclipse-score/discussions/1231

@vinodreddy-g vinodreddy-g merged commit 249848b into eclipse-score:main Jun 27, 2025
10 checks passed
atarekra pushed a commit to Valeo-S-CORE-Organization/persistency that referenced this pull request Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments