Skip to content

Commit 064df1e

Browse files
committed
Remove git submodules generation
This does not work, since submodules require also commit tracking in the top-level repository. This would by default pollute reference_integration, which is certainly not what we want.
1 parent dc384a8 commit 064df1e

File tree

3 files changed

+1
-14
lines changed

3 files changed

+1
-14
lines changed

.devcontainer/prepare_workspace.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ export GITA_PROJECT_HOME
1919

2020
# Generate a few workspace metadata files from known_good.json:
2121
# - .gita-workspace.csv
22-
# - .gitmodules
23-
python3 tools/known_good_to_workspace_metadata.py --known-good known_good.json --gita-workspace .gita-workspace.csv --git-submodules .gitmodules
22+
python3 tools/known_good_to_workspace_metadata.py --known-good known_good.json --gita-workspace .gita-workspace.csv
2423

2524
# Replace git_overrides with local_path_overrides for Bazel
2625
python3 tools/update_module_from_known_good.py --override-type local_path

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,3 @@ __pycache__/
2727
/score_*/
2828
/.gita/
2929
/.gita-workspace.csv
30-
/.gitmodules

tools/known_good_to_workspace_metadata.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ def main():
1717

1818
parser.add_argument("--known-good", dest="known_good", default="known_good.json", help="Path to known_good.json")
1919
parser.add_argument("--gita-workspace", dest="gita_workspace", default=".gita-workspace.csv", help="File to output gita workspace metadata")
20-
parser.add_argument("--git-submodules", dest="git_submodules", default=".gitmodules", help="File to output git submodules metadata")
2120
args = parser.parse_args()
2221

2322
with open(args.known_good, "r") as f:
@@ -49,15 +48,5 @@ def main():
4948
for row in gita_metadata:
5049
writer.writerow(row)
5150

52-
with open(args.git_submodules, "w") as f:
53-
for name, info in modules.items():
54-
repo_url = info.get("repo", "")
55-
branch = info.get("branch", "main")
56-
workspace_path = name
57-
f.write(f"[submodule \"{name}\"]\n")
58-
f.write(f"\tpath = {workspace_path}\n")
59-
f.write(f"\turl = {repo_url}\n")
60-
f.write(f"\tbranch = {branch}\n")
61-
6251
if __name__ == "__main__":
6352
main()

0 commit comments

Comments
 (0)