Skip to content

Commit 349693a

Browse files
authored
Initial proposal for feature request
Initial proposal for feature request
2 parents bd5ef16 + 408517a commit 349693a

File tree

3 files changed

+139
-0
lines changed

3 files changed

+139
-0
lines changed
Lines changed: 129 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,129 @@
1+
..
2+
# *******************************************************************************
3+
# Copyright (c) 2024 Contributors to the Eclipse Foundation
4+
#
5+
# See the NOTICE file(s) distributed with this work for additional
6+
# information regarding copyright ownership.
7+
#
8+
# This program and the accompanying materials are made available under the
9+
# terms of the Apache License Version 2.0 which is available at
10+
# https://www.apache.org/licenses/LICENSE-2.0
11+
#
12+
# SPDX-License-Identifier: Apache-2.0
13+
# *******************************************************************************
14+
15+
16+
Feature Request Guideline
17+
##############################
18+
19+
.. document:: Feature Request Guideline
20+
:id: doc__feature_request_guideline
21+
:status: valid
22+
23+
This Feature Request Guideline is a "How-To for Dummies" for proposing/contributing a new feature or changes to an existing feature.
24+
This Guideline is based on or references following documents:
25+
26+
* :ref:`Contribution Guideline <contribute_contribution_guideline>`
27+
* :ref:`Change Management Plan <change_mgmt_plan>`
28+
* :ref:`Feature Template <chm_feature_templates>`
29+
30+
Creation of Feature Request
31+
================================
32+
1. As the very first step, you will need to become an official contributor, as described in
33+
`Actions to Ensure Proper Contribution <https://eclipse-score.github.io/score/main/contribute/general/contribution_attribution.html#contribution-attribution>`_
34+
35+
2. Afterwards you will be able to create a GitHub Issue in the main `score repository <https://github.com/eclipse-score>`_
36+
and mark it
37+
38+
* with label *feature_request* if you want to propose a new feature, or
39+
* with label *feature_modification* if you want to propose changes to an existing feature,
40+
41+
as described in the :ref:`Change Management Plan <change_mgmt_plan>`.
42+
43+
Please put a short description of your *feature request* into the GitHub Issue description, so that
44+
everyone can immediately understand, what the *feature request* is about.
45+
46+
The acceptance criteria for a feature request to be accepted are:
47+
48+
.. code-block:: markdown
49+
50+
- Feature Request is written according to the [Change Management](https://eclipse-score.github.io/score/main/process/process_areas/change_management/change_management_concept.html) & [Feature Request Template](https://eclipse-score.github.io/score/main/process/process_areas/change_management/guidance/change_management_feature_template.html)
51+
- Feature requirements written according to the [Requirements Engineering](https://eclipse-score.github.io/score/main/process/process_areas/requirements_engineering/requirements_concept.html)
52+
- If necessary: extend the stakeholder requirements written according to the [Requirements Engineering](https://eclipse-score.github.io/score/main/process/process_areas/requirements_engineering/requirements_concept.html)
53+
54+
55+
Technical Leads review regularly all new incoming *feature requests* (GitHub Issues labeled as *feature_request* or *feature_modification*).
56+
This happens normally on Monday in the `Technical Lead circle <https://github.com/orgs/eclipse-score/discussions/104>`_.
57+
As soon as you've labeled your GitHub Issue with *feature request*/*feature_modification* label,
58+
TLs will see the *feature request* and will add it to the special GitHub project,
59+
`Feature Request GitHub Project <https://github.com/orgs/eclipse-score/projects/4>`_.
60+
Inside of this *Feature Request GitHub Project* additional states, as shown in the table below,
61+
are used for a better tracking of the *feature requests*.
62+
These states symbolize the status of the *feature request* and not the "GitHub" states of the issue, therefore we will further speak about
63+
*feature request status*. The initial status of every *feature request* is set to "Draft".
64+
65+
====================== ====================
66+
FR status Description
67+
====================== ====================
68+
**Draft** Feature Request is in the initial state
69+
**In Progress** This is actively being worked on
70+
**In Review** Feature Request should be reviewed by the technical leads
71+
**Accepted** Feature Request was accepted
72+
**Rejected** Feature request was rejected
73+
**Changes Requested** Changes requested
74+
**POC Needed** "Proof of concept" in incubation repository is needed
75+
====================== ====================
76+
77+
3. After you have created a GitHub Issue, next step would be to start working on the *feature request*.
78+
First of all, change the status of *Feature Request* to "in Progress" state.
79+
*Feature Requests*, that stay in the status "Draft" longer as 4 weeks, will be deleted.
80+
Afterwards create a PR with your proposal in the `/docs/features <https://github.com/eclipse-score/score/tree/main/docs/features>`_ score repository.
81+
There you will find currently existing features as subfolders. Please choose the one that fits your *feature request* the most or
82+
create a new subfolder, if none of existing feature match your *feature request*. Please take care, that the PR follows the :ref:`Feature Template <chm_feature_templates>`.
83+
You should try to put as much information as possible, as a good exhaustive description is a prerequisite for *feature request* to be accepted.
84+
85+
It is important to understand, that *feature request* consists of an GitHub Issue, that is used to track organizational information and
86+
PR, that contains the technical content. This is explained once again in detailed in the :ref:`Change Management Worlflow <change_mgmt_workflow>`
87+
chapter of :ref:`Change Management Plan <change_mgmt_plan>` document. GitHub Issue always stays assigned to the owner of the *feature request*.
88+
*Feature Request* PR will always be assigned to the owner of the *feature request* as well, but will additionally get the list of reviewers, that
89+
should review this *feature request* PR.
90+
91+
92+
Review of Feature Request
93+
================================
94+
* As soon as you're done with description of your *feature request*, please put the status into "Ready for Review" so that Technical Leads know,
95+
that they can start with the process of reviewing the *feature request*. Technical Leads will first do a short review of your *feature request*:
96+
97+
* In case the impact of your *feature request* is trivial, then TLs can process your *feature request* immediately.
98+
* Normally, TL circle will put the lead of the appropriate *FT* or *Community* as reviewer to the corresponding PR of the *feature request* for better analysis.
99+
The CTF/Community lead will change the status of the *feature request* issue to "in Review" as soon as they will start reviewing your *feature request*.
100+
The review can be delegated to any other participants of the FT or Community.
101+
102+
* In case *feature request* can not be clearly assigned to any already existing team, Technical Lead circle will pick at least two suitable candidates
103+
from the project to review the *feature request* PR. In that case, *feature request* should be reviewed by all reviewers.
104+
105+
* In case of big architectural impact, Technical Lead circle can additionally decide to request a review for *feature request* PR from software architecture community.
106+
107+
* After the review is done, the TL circle will set the status of the *feature request* accordingly and will
108+
also put all further necessary information as GitHub Issue comments. The outcome of the review could be like following:
109+
110+
* **Accepted** - You *feature request* is accepted. The *feature request* GitHub Issue should contain now a link to a new GitHub issue of type 'Epic',
111+
that was created by Technical Leads, where detailed information regarding your feature is documented.
112+
The epic should be also already assigned to the corresponding team (FT/Community).
113+
If none of the FTs/Communities match the new *feature request*, then a new FT/Community will be founded.
114+
You will be invited to the FT/Community for break down of the *feature request* and planning.
115+
You can now merge the *feature request* PR and close the *feature request* issue.
116+
* **Rejected** - You *feature request* was rejected. It could be either because your description was
117+
not mature enough or because the proposal technically doesn't fit into S-CORE roadmap or architecture.
118+
You will be able to find the summary of the review in the corresponding *feature request* issue comments.
119+
The review comments will be done directly in the *feature request* PR.
120+
* **Changes Requested** - We like your idea, but we would like to request some modifications.
121+
This could be rather technical topics or also syntax issues in the description.
122+
You will be able to find the summary of the review in the corresponding *feature request* issue comments.
123+
The review comments will be done directly in the *feature request* PR.
124+
* **POC needed** - We generally like your idea, but we don't have enough technical understanding of the *feature request*,
125+
e.g. technical scope is too big, and we need a POC to be able to understand better,
126+
how the proposed *feature request* fits into the overall solution. You will find in the GitHub issue comments
127+
the decsription for both the scope of the PoC and the requirements and the acceptance criteria for the requested PoC.
128+
Also, a so called *incubation repository* will be created by the reviewers of the *feature request*, where you should implement your POC.
129+
Please be aware, that POC is not a guarantee, that you *feature request* will be accepted.

docs/contribute/contribution_request/index.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,3 +176,9 @@ The figure below shows options to report something.
176176
:alt: Reporting options overview
177177

178178
Reporting options overview
179+
180+
.. toctree::
181+
:hidden:
182+
:maxdepth: 2
183+
184+
feature_request

docs/platform_management_plan/change_management.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
:tags: platform_management
2020
:realizes: wp__chm_plan
2121

22+
.. _change_mgmt_plan:
23+
2224
Change Management / Change Management Plan
2325
------------------------------------------
2426

@@ -139,6 +141,8 @@ description.
139141
:need:`[[title]] <gd_req__change__attr_milestone>` is defined by the Milestone of a ISSUE.
140142

141143

144+
.. _change_mgmt_workflow:
145+
142146
Change Request Workflow
143147
^^^^^^^^^^^^^^^^^^^^^^^
144148

0 commit comments

Comments
 (0)