Skip to content

Commit d2aee7e

Browse files
Fix build Errors (#150)
1 parent 3a25666 commit d2aee7e

File tree

6 files changed

+14
-16
lines changed

6 files changed

+14
-16
lines changed

native/chromium_jni_macro/src/utils/jni_utils.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,20 @@ fn get_type_parameter(p: &Path) -> Punctuated<GenericArgument, Comma> {
5858
/// Extracts Args from an Option function pointer path Option<*mut fn(Args...)>
5959
pub fn extract_arguments(p: &Path) -> syn::punctuated::Punctuated<BareFnArg, Comma> {
6060
let bracket_args = get_type_parameter(p);
61-
return match bracket_args.first().unwrap() {
61+
match bracket_args.first().unwrap() {
6262
GenericArgument::Type(Type::BareFn(t)) => t.inputs.clone(),
6363
_ => panic!("Not a type"),
64-
};
64+
}
6565
}
6666

6767
/// Extracts the result type from an Option function pointer path Option<*mut fn(...) -> Result>
6868
pub fn extract_result(p: &Path) -> Option<syn::Type> {
6969
let bracket_args = get_type_parameter(p);
70-
return match bracket_args.first().unwrap() {
70+
match bracket_args.first().unwrap() {
7171
GenericArgument::Type(Type::BareFn(t)) => match t.output.clone() {
7272
ReturnType::Type(_, ty) => Some(*ty),
7373
ReturnType::Default => None,
7474
},
7575
_ => panic!("Not a type (result)"),
76-
};
76+
}
7777
}

native/chromium_jni_macro/src/utils/unzip4.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* which accompanies this distribution, and is available at
77
* http://www.eclipse.org/legal/epl-v20.html
88
*/
9-
109
/// Trait for unzipping 4-tuples
1110
pub trait Unzip4<A, B, C, D> {
1211
fn unzip4<FromA, FromB, FromC, FromD>(self) -> (FromA, FromB, FromC, FromD)

native/chromium_jni_utils/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ impl<T> FromJavaValue for *mut T {
8585
impl FromJavaMember for usize {
8686
fn from_java_member(env: JNIEnv, object: JObject, name: &str) -> usize {
8787
// Read an integer field
88-
return env
88+
env
8989
.get_field(object, name, "I")
9090
.and_then(|v| v.i())
91-
.unwrap() as usize;
91+
.unwrap() as usize
9292
}
9393
}
9494

native/chromium_subp/build.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
* Contributors:
1212
* Guillermo Zunino, Equo - initial implementation
1313
*/
14-
1514
fn main() {
1615
link();
1716
}

native/chromium_swt/src/cef_cookie.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ pub extern "C" fn Java_org_eclipse_set_browser_lib_cefswt_1cookie_1visitor_1t_ce
2020
cookie: *mut chromium::cef::_cef_cookie_t,
2121
) -> jstring {
2222
let value = unsafe { CStr::from_ptr(cefswt_cookie_value(cookie)) };
23-
return env
23+
env
2424
.new_string(value.to_str().unwrap())
2525
.unwrap()
26-
.into_inner();
26+
.into_inner()
2727
}
2828

2929
#[no_mangle]
@@ -33,10 +33,10 @@ pub extern "C" fn Java_org_eclipse_set_browser_lib_cefswt_1cookie_1visitor_1t_ce
3333
cookie: *mut chromium::cef::_cef_cookie_t,
3434
) -> jstring {
3535
let value = unsafe { CStr::from_ptr(cefswt_cookie_to_java(cookie)) };
36-
return env
36+
env
3737
.new_string(value.to_str().unwrap())
3838
.unwrap()
39-
.into_inner();
39+
.into_inner()
4040
}
4141

4242
fn cefswt_cookie_to_java(cookie: *mut chromium::cef::_cef_cookie_t) -> *mut c_char {

native/chromium_swt/src/cef_download_item.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ pub unsafe extern "C" fn get_full_path(
2424
let path = (*item).get_full_path.unwrap()(item);
2525

2626
let value = CStr::from_ptr(crate::cefswt_cefstring_to_java(path));
27-
return env
27+
env
2828
.new_string(value.to_str().unwrap())
2929
.unwrap()
30-
.into_inner();
30+
.into_inner()
3131
}
3232

3333
#[jni_name("org.eclipse.set.browser.lib.cef_download_item_t")]
@@ -56,10 +56,10 @@ pub unsafe extern "C" fn get_url(
5656
) -> jstring {
5757
let url = (*item).get_url.unwrap()(item);
5858
let value = CStr::from_ptr(crate::cefswt_cefstring_to_java(url));
59-
return env
59+
env
6060
.new_string(value.to_str().unwrap())
6161
.unwrap()
62-
.into_inner();
62+
.into_inner()
6363
}
6464

6565
#[jni_name("org.eclipse.set.browser.lib.cef_download_item_t")]

0 commit comments

Comments
 (0)