-
Notifications
You must be signed in to change notification settings - Fork 18
Description
The variable result in org.eclipse.sirius.ui.tools.internal.views.common.navigator.SiriusCommonContentProvider.RefreshViewerTriggerScope.isSemanticChange is never set (see line 1071):
Lines 1068 to 1074 in a0a0e0a
| private boolean isSemanticChange(Resource resource) { | |
| boolean result = false; | |
| if (resource != null) { | |
| allSemanticResources.contains(resource); | |
| } | |
| return result; | |
| } |
A consequence is the model explorer is not refreshed by RefreshViewerTrigger on semantic change.
The Model Explorer still works with raw Sirius because contributions to the Model Explorer in Sirius use the AdapterFactoryContentProvider which is able to refresh the viewer on semantic changes.
If another plugin (outside of Sirius) contributes new content providers to the Model Explorer without using AdapterFactoryContentProvider then it has to manage the refresh on semantic changes (by copying the whole refresh process which can be error prone).