Skip to content

Refresh issue in Model Explorer with custom Content Provider #101

@ymortier

Description

@ymortier

The variable result in org.eclipse.sirius.ui.tools.internal.views.common.navigator.SiriusCommonContentProvider.RefreshViewerTriggerScope.isSemanticChange is never set (see line 1071):

private boolean isSemanticChange(Resource resource) {
boolean result = false;
if (resource != null) {
allSemanticResources.contains(resource);
}
return result;
}

A consequence is the model explorer is not refreshed by RefreshViewerTrigger on semantic change.

The Model Explorer still works with raw Sirius because contributions to the Model Explorer in Sirius use the AdapterFactoryContentProvider which is able to refresh the viewer on semantic changes.

If another plugin (outside of Sirius) contributes new content providers to the Model Explorer without using AdapterFactoryContentProvider then it has to manage the refresh on semantic changes (by copying the whole refresh process which can be error prone).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions