[5924] Prevent a simple move on its parent from triggering a diagram drop

Bug: #5924
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>

Author: frouene

CHANGELOG.adoc

@@ -1,6 +1,6 @@
 = Changelog
 
-== 2026.1.0
+== 2026.1.0 (work in progress)
 
 === Shapes
 
@@ -41,7 +41,7 @@ On the backend, the node and edge's `deleteHandler` can now be `null` if no sema
 - https://github.com/eclipse-sirius/sirius-web/issues/5720[#5720] [explorer] Fixed an issue where the initial search for an element with the Omnibox would not reveal the selected element in the _Explorer_
 - https://github.com/eclipse-sirius/sirius-web/issues/5896[#5896] Add missing translations for edge appearance menu
 - https://github.com/eclipse-sirius/sirius-web/issues/5912[#5912] [diagram] Fix an issue where edge handles could be rendered in the wrong position
-
+- https://github.com/eclipse-sirius/sirius-web/issues/5924[#5924] [diagram] Prevent a simple move on its parent from triggering a diagram drop
 
 === New Features
 
@@ -64,7 +64,7 @@ Downstream applications can now implement the following interfaces:
 * `IIndexUpdateServiceDelegate` to customize how the content of the indices is updated
 Sirius Web provides a default implementation for all these services, which creates an index per editing context, and indexes all the features of the elements in the editing context (this can be customized by implementing `IIndexEntryProviderDelegate`).
 - https://github.com/eclipse-sirius/sirius-web/issues/3486[#3486] [diagram] Do not open delete confirmation dialog when a node/edge is not deletable
-- https://github.com/eclipse-sirius/sirius-web/issues/5768[#5768] [diagram] Group tools are now using the same palette as others tools 
+- https://github.com/eclipse-sirius/sirius-web/issues/5768[#5768] [diagram] Group tools are now using the same palette as others tools
 
 
 

packages/diagrams/frontend/sirius-components-diagrams/src/renderer/dropNode/useDropNodes.ts

@@ -152,7 +152,7 @@ export const useDropNodes = (): UseDropNodesValue => {
     return node;
   };
 
-  const onNodeDragStart: OnNodeDrag<Node<NodeData>> = useCallback(
+  const onNodesDragStart: OnNodeDrag<Node<NodeData>> = useCallback(
     (_event, _node, nodes) => {
       if (nodes.length === 0) {
         return;
@@ -232,7 +232,7 @@ export const useDropNodes = (): UseDropNodesValue => {
     [getNodes]
   );
 
-  const onNodeDrag: OnNodeDrag<Node<NodeData>> = useCallback(
+  const onNodesDrag: OnNodeDrag<Node<NodeData>> = useCallback(
     (event, _node, nodes) => {
       if (nodes.length === 0) {
         return;
@@ -293,8 +293,11 @@ export const useDropNodes = (): UseDropNodesValue => {
     [droppableOnDiagram, getNodes]
   );
 
-  const onNodeDragStop: OnNodeDrag<Node<NodeData>> = useCallback(
-    (_event, draggedNode, draggedNodes) => {
+  const onNodesDragStop: OnNodeDrag<Node<NodeData>> = useCallback(
+    (_event, node, _nodes) => {
+      const draggedNodes: Node<NodeData>[] = getNodes().filter((node) => node.data.isDraggedNode);
+      const draggedNode: Node<NodeData> | undefined =
+        draggedNodes.find((draggedNode) => draggedNode.id === node.id) || undefined;
       if (draggedNode) {
         const dropPosition = evaluateAbsolutePosition(draggedNode, storeApi.getState().nodeLookup);
         const targetNode = getNodes().find((node) => node.data.isDropNodeTarget);
@@ -372,8 +375,8 @@ export const useDropNodes = (): UseDropNodesValue => {
   );
 
   return {
-    onNodesDragStart: onNodeDragStart,
-    onNodesDrag: onNodeDrag,
-    onNodesDragStop: onNodeDragStop,
+    onNodesDragStart,
+    onNodesDrag,
+    onNodesDragStop,
   };
 };