Skip to content

Commit c863b7b

Browse files
committed
Merge branch 'main' into linker_simplification
2 parents 53dcb23 + caf3cf5 commit c863b7b

File tree

5 files changed

+31
-14
lines changed

5 files changed

+31
-14
lines changed

.github/workflows/cibuildwheel.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,4 +147,5 @@ jobs:
147147
needs: [generate-matrix, pure-python-wheels, build-wheels]
148148
uses: ./.github/workflows/test-wheels.yml
149149
with:
150-
matrix: ${{ fromJSON(needs.generate-matrix.outputs.test_matrix) }}
150+
matrix: ${{ needs.generate-matrix.outputs.test_matrix }}
151+
wheel_source: 'python-wheels'

.github/workflows/test-wheels.yml

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,38 @@
11
name: Test wheels
22

33
on:
4+
push:
5+
paths:
6+
- '.github/workflows/test-wheels.yml'
47
workflow_call:
58
inputs:
69
matrix:
710
type: string
8-
required: true
11+
required: false
12+
wheel_source:
13+
type: string
14+
required: false
15+
workflow_dispatch:
16+
inputs:
17+
wheel_source:
18+
type: string
19+
required: false
20+
schedule:
21+
- cron: '5 6 * * *'
922

1023
jobs:
24+
maybe-generate-matrix:
25+
if: inputs.matrix == ''
26+
uses: ./.github/workflows/generate-matrix.yml
27+
1128
test-wheels:
29+
needs: [maybe-generate-matrix]
1230
strategy:
1331
fail-fast: false
14-
matrix: ${{ fromJSON(inputs.matrix) }}
32+
matrix: ${{ fromJSON(inputs.matrix || needs.maybe-generate-matrix.outputs.test_matrix) }}
1533
runs-on: ${{ matrix.os }}
34+
env:
35+
WHEEL_SOURCE: ${{ inputs.wheel_source || 'https://sumo.dlr.de/daily/ciwheels' }}
1636

1737
steps:
1838
- name: Cloning SUMO
@@ -46,11 +66,11 @@ jobs:
4666
run: python -m pip install -r tools/req_ci.txt -r tools/requirements.txt
4767

4868
- name: Installing sumo wheels (macos / windows)
49-
if: ${{ !startsWith(matrix.os, 'ubuntu') }}
69+
if: ${{ !startsWith(matrix.os, 'ubuntu') || inputs.wheel_source != 'python-wheels'}}
5070
shell: bash
5171
run: |
5272
source testenv/*/activate
53-
python -m pip install --no-index -f python-wheels eclipse_sumo
73+
python -m pip install --no-index -f $WHEEL_SOURCE eclipse_sumo
5474
python -c "import sumo; print('SUMO_HOME=' + sumo.SUMO_HOME)" >> $GITHUB_ENV
5575
5676
- name: Installing sumo wheels (linux)
@@ -97,11 +117,11 @@ jobs:
97117
python -m pip install texttest
98118
99119
- name: Installing libsumo wheels (macos / windows)
100-
if: ${{ !startsWith(matrix.os, 'ubuntu') }}
120+
if: ${{ !startsWith(matrix.os, 'ubuntu') || inputs.wheel_source != 'python-wheels' }}
101121
shell: bash
102122
run: |
103123
if [[ "${{ matrix.os }}" != "windows-latest" ]]; then source libsumo_testenv/*/activate; fi
104-
python -m pip install --no-index -f python-wheels libsumo
124+
python -m pip install --no-index -f $WHEEL_SOURCE libsumo
105125
106126
- name: Installing libsumo wheels (linux)
107127
if: ${{ startsWith(matrix.os, 'ubuntu') }}

src/netedit/GNEApplicationWindowHelper.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2289,8 +2289,7 @@ GNEApplicationWindowHelper::GNESumoConfigHandler::loadSumoConfig() {
22892289
// GNENetconvertConfigHandler - methods
22902290
// ---------------------------------------------------------------------------
22912291

2292-
GNEApplicationWindowHelper::GNENetconvertConfigHandler::GNENetconvertConfigHandler(GNEApplicationWindow* applicationWindow, const std::string& sumoConfigFile) :
2293-
myApplicationWindow(applicationWindow),
2292+
GNEApplicationWindowHelper::GNENetconvertConfigHandler::GNENetconvertConfigHandler(const std::string& sumoConfigFile) :
22942293
myNetconvertConfigFile(sumoConfigFile) {
22952294
}
22962295

src/netedit/GNEApplicationWindowHelper.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1133,15 +1133,12 @@ struct GNEApplicationWindowHelper {
11331133

11341134
public:
11351135
/// @brief Constructor
1136-
GNENetconvertConfigHandler(GNEApplicationWindow* applicationWindow, const std::string& file);
1136+
GNENetconvertConfigHandler(const std::string& file);
11371137

11381138
/// @brief load netconvert config
11391139
bool loadNetconvertConfig();
11401140

11411141
private:
1142-
/// @brief pointer to current GNEApplicationWindow
1143-
GNEApplicationWindow* myApplicationWindow;
1144-
11451142
/// @brief netconvert config file
11461143
const std::string myNetconvertConfigFile;
11471144

src/netedit/GNELoadThread.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ GNELoadThread::run() {
132132
}
133133
} else if (type == GNEEvent_FileLoaded::Type::NETCCFG) {
134134
// declare parser for netedit config file
135-
GNEApplicationWindowHelper::GNENetconvertConfigHandler confighandler(myApplicationWindow, loadedFile);
135+
GNEApplicationWindowHelper::GNENetconvertConfigHandler confighandler(loadedFile);
136136
// if there is an error loading sumo config, stop
137137
if (!confighandler.loadNetconvertConfig()) {
138138
return submitEndAndCleanup(type, nullptr, loadedFile);

0 commit comments

Comments
 (0)