fix(clearingrequest): surface CR cleanup failure in response body

When project deletion succeeds but the clearing request removal fails,
the previous code silently logged the error and returned 200 — leaving
callers unaware that an orphaned CR exists. Return a 200 with an
explanatory body instead so the caller knows to take action.

Also restructure with early returns to make the success path clearer.

Author: Aman-Cool

rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java

@@ -765,28 +765,38 @@ public ResponseEntity deleteProject(
             log.info("No clearing request found for project: " + id + " (exception: " + e.getMessage() + ")");
         }
 
+        // Delete the project first. If this fails the clearing request is left
+        // completely untouched — no data loss.
         RequestStatus requestStatus = projectService.deleteProject(id, sw360User);
-        if (requestStatus == RequestStatus.SUCCESS) {
-            if (clearingRequest != null && !isClosedClearingRequest(clearingRequest)) {
-                try {
-                    RequestStatus clearingRequestStatus = moderationClient.deleteClearingRequest(clearingRequest.getId(), sw360User);
-                    if (clearingRequestStatus != RequestStatus.SUCCESS) {
-                        log.error("Project deleted but failed to delete open clearing request for project: " + id);
-                    } else {
-                        log.info("Successfully deleted the open clearing request for project: " + id);
-                    }
-                } catch (TException e) {
-                    log.error("Project deleted but error while deleting clearing request for project: " + id, e);
-                }
-            }
-            return new ResponseEntity<>(HttpStatus.OK);
-        } else if (requestStatus == RequestStatus.IN_USE) {
+        if (requestStatus == RequestStatus.IN_USE) {
             return new ResponseEntity<>(HttpStatus.CONFLICT);
         } else if (requestStatus == RequestStatus.SENT_TO_MODERATOR) {
             return new ResponseEntity<>(RESPONSE_BODY_FOR_MODERATION_REQUEST, HttpStatus.ACCEPTED);
-        } else {
+        } else if (requestStatus != RequestStatus.SUCCESS) {
             throw new SW360Exception("Something went wrong.");
         }
+
+        // Project is gone. Now remove the open clearing request if one existed.
+        // The backend already orphaned it during project cleanup, so deleting by ID
+        // is still safe at this point.
+        if (clearingRequest != null && !isClosedClearingRequest(clearingRequest)) {
+            try {
+                RequestStatus crStatus = moderationClient.deleteClearingRequest(clearingRequest.getId(), sw360User);
+                if (crStatus != RequestStatus.SUCCESS) {
+                    log.warn("Project {} deleted but clearing request {} could not be removed",
+                            id, clearingRequest.getId());
+                    return ResponseEntity.ok()
+                            .body("Project deleted successfully, but the associated clearing request could not be removed.");
+                }
+                log.info("Clearing request {} deleted after project {}", clearingRequest.getId(), id);
+            } catch (TException e) {
+                log.warn("Project {} deleted but clearing request cleanup threw an exception", id, e);
+                return ResponseEntity.ok()
+                        .body("Project deleted successfully, but the associated clearing request could not be removed.");
+            }
+        }
+
+        return new ResponseEntity<>(HttpStatus.OK);
     }
 
     private boolean isClosedClearingRequest(ClearingRequest clearingRequest) {