Skip to content

Commit c0150b3

Browse files
authored
Merge pull request #2436 from Siemens-Healthineers/fix/pkgUpdationCausingInconsistency-2428
fix(importCDX) : Fix package's linked release updation when an SBOM is imported Reviewed by: afsah.syeda@siemens-healthineers.com Tested by: sameed.ahmad@siemens-healthineers.com
2 parents 883571a + dfabecd commit c0150b3

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -647,10 +647,12 @@ private Map<String, String> importAllComponentsAsPackages(Map<String, List<org.c
647647
pkg.setId(pkgAddSummary.getId());
648648
if (AddDocumentRequestStatus.DUPLICATE.equals(pkgAddSummary.getRequestStatus())) {
649649
Package dupPkg = packageDatabaseHandler.getPackageById(pkg.getId());
650-
if (!release.getId().equals(dupPkg.getReleaseId())) {
651-
log.error("Release Id of Package from BOM: '%s' and Database: '%s' is not equal!", release.getId(), dupPkg.getReleaseId());
652-
dupPkg.setReleaseId(release.getId());
650+
String dupPkgReleaseId = dupPkg.getReleaseId();
651+
String releaseId = release.getId();
652+
if (!releaseId.equals(dupPkgReleaseId) && CommonUtils.isNullEmptyOrWhitespace(dupPkgReleaseId)) {
653+
dupPkg.setReleaseId(releaseId);
653654
packageDatabaseHandler.updatePackage(dupPkg, user);
655+
log.error("Release Id of Package from BOM: '%s' and Database: '%s' is not equal!", releaseId, dupPkgReleaseId);
654656
}
655657
if(!CommonUtils.nullToEmptySet(project.getPackageIds()).contains(pkg.getId())){
656658
pkgReuseCount++;

0 commit comments

Comments
 (0)