[1080] Improve import and resolution of ConjugatedPort

Bug: #1080
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>

Author: adaussy

CHANGELOG.adoc

@@ -32,6 +32,7 @@ A new dra & drop tool is available on the diagram, allowing moving `Satisfy Requ
 - https://github.com/eclipse-syson/syson/issues/1030[#1030] [metamodel] `ConnectorAsUsage.getSourceFeature` and `ConnectorAsUsage.getTargetFeature` should redefine `Relationship.source` and `Relationship.target` features
 - https://github.com/eclipse-syson/syson/issues/1042[#1042] [import] Improve textual import of `SuccessionAsUsage` which define a new target action directly after the 'then' keyword.
 - https://github.com/eclipse-syson/syson/issues/1045[#1045] [export] Improve textual export by properly handle named `SuccessionAsUsage`.
+- https://github.com/eclipse-syson/syson/issues/1080[#1080] [import] Improve textual import and resolution against `ConjugatedPorts`.
 
 === New features
 

backend/application/syson-application/src/test/java/org/eclipse/syson/application/export/ImportExportTests.java

@@ -55,6 +55,26 @@ public void setUp() {
         this.checker = new SysmlImportExportChecker(this.sysmlLoader, this.editingDomainFactory, this.exporter, this.sysMLEditingContextProcessor);
     }
 
+    @Test
+    @DisplayName("Given a model with a PortDefinition, when importing/exporting the file, then check that the conjugated port reference is kept during the process.")
+    public void checkConjugatedPortUse() throws IOException {
+        var input = """
+                package Conjugated {
+                    attribute def Temp;
+                    port def TempPort {
+                        attribute temperature : Temp;
+                    }
+                    part def TempPortClassic {
+                        port tempPortClassic : TempPort;
+                    }
+                    part def TempPortConj {
+                        port tempPortConj : ~TempPort;
+                    }
+                }""";
+
+        this.checker.check(input, input);
+    }
+
     @Test
     @DisplayName("Given a named SuccessionAsUsage, when importing and exporting the model, then the exported text file should be the same as the imported one.")
     public void checkNamedSuccessionAsUsageInActionDefinitionTest() throws IOException {

backend/application/syson-application/src/test/java/org/eclipse/syson/application/imports/ImportSysMLModelTest.java

@@ -24,8 +24,11 @@
 import org.eclipse.syson.AbstractIntegrationTests;
 import org.eclipse.syson.application.configuration.SysMLEditingContextProcessor;
 import org.eclipse.syson.services.UtilService;
+import org.eclipse.syson.sysml.ConjugatedPortDefinition;
 import org.eclipse.syson.sysml.Feature;
 import org.eclipse.syson.sysml.Membership;
+import org.eclipse.syson.sysml.PortDefinition;
+import org.eclipse.syson.sysml.PortUsage;
 import org.eclipse.syson.sysml.ReferenceUsage;
 import org.eclipse.syson.sysml.SuccessionAsUsage;
 import org.eclipse.syson.sysml.helper.EMFUtils;
@@ -62,6 +65,41 @@ public void setUp() {
         this.checker = new SysMLv2SemanticImportChecker(this.sysmlResourceLoader, this.editingDomainFactory, this.sysMLEditingContextProcessor);
     }
 
+    @Test
+    @DisplayName("Given a model with PortDefinitions, when importing the model, then a conjugated port is create for each conjugated ports")
+    public void checkConjugatedPortCreation() throws IOException {
+        var input = """
+                package Conjugated {
+                    attribute def Temp;
+                    port def TempPort {
+                        attribute temperature : Temp;
+                    }
+                    part def TempPortClassic {
+                        port tempPortClassic : TempPort;
+                    }
+                    part def TempPortConj {
+                        port tempPortConj : ~TempPort;
+                    }
+                }""";
+
+
+        this.checker.checkImportedModel(resource -> {
+            PortDefinition tempPort = EMFUtils.allContainedObjectOfType(resource, PortDefinition.class)
+                    .filter(pod -> "TempPort".equals(pod.getDeclaredName()))
+                    .findFirst().get();
+
+            ConjugatedPortDefinition conjugatedPortDefinition = tempPort.getConjugatedPortDefinition();
+            assertThat(conjugatedPortDefinition).isNotNull();
+
+            PortUsage tempPortConj = EMFUtils.allContainedObjectOfType(resource, PortUsage.class)
+                    .filter(pou -> "tempPortConj".equals(pou.getDeclaredName()))
+                    .findFirst().get();
+
+            assertThat(tempPortConj.getType()).hasSize(1).allMatch(e -> e == conjugatedPortDefinition);
+
+        }).check(input);
+    }
+
     @Test
     @DisplayName("Given a SuccessionAsUsage using the syntax that create a new target action, when importing and exporting the model, then the source and target should be correctly computed.")
     public void checkSuccessionToDefinedActionSourceTest() throws IOException {

backend/application/syson-sysml-import/src/main/java/org/eclipse/syson/sysml/ASTTransformer.java

@@ -91,6 +91,7 @@ public Resource convertResource(final InputStream input, final ResourceSet resou
     private void preResolvingFixingPhase(List<EObject> rootSysmlObjects) {
         for (EObject root : rootSysmlObjects) {
             this.fixSuccessionUsageImplicitSource(root);
+            this.fixConjugatedPorts(root);
         }
     }
 
@@ -107,6 +108,31 @@ private void fixSuccessionUsageImplicitSource(EObject root) {
         this.fixImplicitTarget(succesionAsUsage);
     }
 
+    /**
+     * Add all missing conjugate ports on PortDefinitions.
+     *
+     * @param root
+     *            a root element
+     */
+    private void fixConjugatedPorts(EObject root) {
+        List<PortDefinition> portDefinitions = EMFUtils.allContainedObjectOfType(root, PortDefinition.class).toList();
+
+        for (PortDefinition portDef : portDefinitions) {
+            if (portDef.getConjugatedPortDefinition() == null) {
+                OwningMembership owningMembership = SysmlFactory.eINSTANCE.createOwningMembership();
+                portDef.getOwnedRelationship().add(owningMembership);
+                // No need to set the declaredName for the ConjugatedPortDefinition here, it is always the same than its
+                // originalPortDefinition and computed elsewhere
+                ConjugatedPortDefinition conjugatedPortDefinition = SysmlFactory.eINSTANCE.createConjugatedPortDefinition();
+                owningMembership.getOwnedRelatedElement().add(conjugatedPortDefinition);
+                PortConjugation portConjugation = SysmlFactory.eINSTANCE.createPortConjugation();
+                conjugatedPortDefinition.getOwnedRelationship().add(portConjugation);
+                portConjugation.setConjugatedType(conjugatedPortDefinition);
+                portConjugation.setOriginalPortDefinition(portDef);
+            }
+        }
+    }
+
     /**
      * Try to fix all {@link SuccessionAsUsage} elements contained in the given root to workaround
      * https://github.com/eclipse-syson/syson/issues/1042 and https://github.com/sensmetry/sysml-2ls/issues/13.

backend/application/syson-sysml-import/src/test/java/org/eclipse/syson/sysml/ASTTransformerTest.java

@@ -293,11 +293,13 @@ void convertFeatureTypingTest() {
         PortDefinition typedPortDefinition = (PortDefinition) portDefinition;
         assertEquals("portDefinition", typedPortDefinition.getDeclaredName());
 
-        assertEquals(1, typedPortDefinition.getOwnedMember().size());
+        assertEquals(2, typedPortDefinition.getOwnedMember().size());
         EObject referenceUsage = typedPortDefinition.getOwnedMember().get(0);
         assertInstanceOf(ReferenceUsage.class, referenceUsage);
         ReferenceUsage typedReferenceUsage = (ReferenceUsage) referenceUsage;
         assertEquals("referenceUsage", typedReferenceUsage.getDeclaredName());
+        EObject conjugatedPortDefinition = typedPortDefinition.getOwnedMember().get(1);
+        assertInstanceOf(ConjugatedPortDefinition.class, conjugatedPortDefinition);
 
         assertEquals(1, typedReferenceUsage.getOwnedTyping().size());
         FeatureTyping featureTyping = typedReferenceUsage.getOwnedTyping().get(0);

doc/content/modules/user-manual/pages/release-notes/2025.4.0.adoc

@@ -70,6 +70,7 @@ action def ActionDef1 {
     succession s1 first a1 then a2;
 }
 ```
+- Improve `PortDefinition` textual import by creating the required `ConjugatedPort` during the import process.
 
 == Dependency update