[982] Implement Membership#isDistinguishableFrom

Bug: #982
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>

Author: AxelRICHARD

CHANGELOG.adoc

@@ -36,6 +36,7 @@ The changes are:
 * New class TerminateActionUsage
 ** with new derived reference `terminatedOccurrenceArgument : Expression`
 - https://github.com/eclipse-syson/syson/issues/946[#946] [libraries] All standard libraries have been updated to comply with the SysML Beta 2.3 specification.
+- https://github.com/eclipse-syson/syson/issues/982[#982] [metamodel] `Membership#isDistinguishableFrom` derived attribute has been implemented.
 
 === New features
 

backend/metamodel/syson-sysml-metamodel/src/main/java/org/eclipse/syson/sysml/impl/MembershipImpl.java

@@ -15,6 +15,7 @@
 import java.lang.reflect.InvocationTargetException;
 import java.util.Collection;
 import java.util.Iterator;
+import java.util.Objects;
 
 import org.eclipse.emf.common.notify.Notification;
 import org.eclipse.emf.common.util.EList;
@@ -300,13 +301,31 @@ public void setVisibility(VisibilityKind newVisibility) {
     }
 
     /**
-     * <!-- begin-user-doc --> <!-- end-user-doc -->
+     * <!-- begin-user-doc --> not (memberElement.oclKindOf(other.memberElement.oclType()) or
+     * other.memberElement.oclKindOf(memberElement.oclType())) or (shortMemberName = null or (shortMemberName <>
+     * other.shortMemberName and shortMemberName <> other.memberName)) and (memberName = null or (memberName <>
+     * other.shortMemberName and memberName <> other.memberName)))<!-- end-user-doc -->
      *
      * @generated NOT
      */
     @Override
     public boolean isDistinguishableFrom(Membership other) {
-        return false;
+        boolean isDistinguishableFrom = true;
+        var member = this.getMemberElement();
+        var otherMember = other.getMemberElement();
+        if (member != null && otherMember != null) {
+            var memberElementClass = member.eClass();
+            var otherMemberElementClass = otherMember.eClass();
+            var memberElementSuperClasses = memberElementClass.getEAllSuperTypes();
+            var otherMemberElementSuperClasses = otherMemberElementClass.getEAllSuperTypes();
+            boolean compatibleMembers = Objects.equals(memberElementClass, otherMemberElementClass) || memberElementSuperClasses.contains(otherMemberElementClass)
+                    || otherMemberElementSuperClasses.contains(memberElementClass);
+            boolean diffMemberShortName = this.getMemberShortName() == null
+                    || (!this.getMemberShortName().equals(other.getMemberShortName()) && !this.getMemberShortName().equals(other.getMemberName()));
+            boolean diffMemberName = this.getMemberName() == null || (!this.getMemberName().equals(other.getMemberShortName()) && !this.getMemberName().equals(other.getMemberName()));
+            isDistinguishableFrom = !compatibleMembers || (diffMemberShortName && diffMemberName);
+        }
+        return isDistinguishableFrom;
     }
 
     /**

backend/metamodel/syson-sysml-metamodel/src/test/java/org/eclipse/syson/sysml/impl/MembershipImplTest.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2024 Obeo.
+ * Copyright (c) 2024, 2025 Obeo.
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v2.0
  * which accompanies this distribution, and is available at
@@ -24,8 +24,14 @@
 import org.eclipse.syson.sysml.Element;
 import org.eclipse.syson.sysml.Membership;
 import org.eclipse.syson.sysml.Namespace;
+import org.eclipse.syson.sysml.Package;
+import org.eclipse.syson.sysml.PartDefinition;
+import org.eclipse.syson.sysml.PartUsage;
 import org.eclipse.syson.sysml.SysmlFactory;
 import org.eclipse.syson.sysml.SysmlPackage;
+import org.eclipse.syson.sysml.util.ModelBuilder;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -35,6 +41,47 @@
  */
 public class MembershipImplTest {
 
+    private ModelBuilder builder;
+
+    private PartUsage p1;
+
+    private PartUsage p2;
+
+    private PartUsage p3;
+
+    private PartUsage p4;
+
+    /**
+     * <pre>
+     * .
+     *  package Pkg1 {
+     *    part def Def1 {
+     *      part p1 : Def1;
+     *      part p2 : Def1;
+     *      part p1 : Def2;
+     *      part p1 : Def1;
+     *    }
+     *
+     *    part def Def2;
+     *  }
+     * </pre>
+     */
+    @BeforeEach
+    public void setUp() {
+        this.builder = new ModelBuilder();
+        Package pkg1 = this.builder.createWithName(Package.class, "Pkg1");
+        PartDefinition def1 = this.builder.createInWithName(PartDefinition.class, pkg1, "Def1");
+        PartDefinition def2 = this.builder.createInWithName(PartDefinition.class, pkg1, "Def2");
+        this.p1 = this.builder.createInWithName(PartUsage.class, def1, "p1");
+        this.builder.setType(this.p1, def1);
+        this.p2 = this.builder.createInWithName(PartUsage.class, def1, "p2");
+        this.builder.setType(this.p2, def1);
+        this.p3 = this.builder.createInWithName(PartUsage.class, def1, "p1");
+        this.builder.setType(this.p3, def2);
+        this.p4 = this.builder.createInWithName(PartUsage.class, def1, "p1");
+        this.builder.setType(this.p4, def1);
+    }
+
     @Test
     public void testSource() {
         Namespace namespace = SysmlFactory.eINSTANCE.createNamespace();
@@ -61,4 +108,43 @@ public void testTarget() {
         assertFalse(membership.getTarget().isEmpty());
         assertNotNull(membership.getMemberElement());
     }
+
+    @DisplayName("Given two memberships containg different name and different type, when isDistinguishableFrom is called, then the result is true")
+    @Test
+    public void isDistinguishableFromTest1() {
+        var lhs = this.p1.getOwningMembership();
+        var rhs = this.p2.getOwningMembership();
+        assertTrue(lhs.isDistinguishableFrom(rhs));
+    }
+
+    @DisplayName("Given two memberships containg different name but same type, when isDistinguishableFrom is called, then the result is true")
+    @Test
+    public void isDistinguishableFromTest2() {
+        var lhs = this.p1.getOwningMembership();
+        var rhs = this.p2.getOwningMembership();
+        assertTrue(lhs.isDistinguishableFrom(rhs));
+    }
+
+    @DisplayName("Given two memberships containg same name but different type, when isDistinguishableFrom is called, then the result is false")
+    @Test
+    public void isDistinguishableFromTest3() {
+        var lhs = this.p1.getOwningMembership();
+        var rhs = this.p3.getOwningMembership();
+        assertFalse(lhs.isDistinguishableFrom(rhs));
+    }
+
+    @DisplayName("Given two memberships containg same name and same type, when isDistinguishableFrom is called, then the result is false")
+    @Test
+    public void isDistinguishableFromTest4() {
+        var lhs = this.p1.getOwningMembership();
+        var rhs = this.p4.getOwningMembership();
+        assertFalse(lhs.isDistinguishableFrom(rhs));
+    }
+
+    @DisplayName("Given same memberships, when isDistinguishableFrom is called, then the result is false")
+    @Test
+    public void isDistinguishableFromTest5() {
+        var lhs = this.p1.getOwningMembership();
+        assertFalse(lhs.isDistinguishableFrom(lhs));
+    }
 }

doc/content/modules/user-manual/pages/release-notes/2025.2.0.adoc

@@ -88,6 +88,9 @@ The changes are:
 
 image::release-notes-diagrams-export-as-png.png[Export diagram as PNG, width=50%,height=50%]
 
+- `Membership#isDistinguishableFrom` derived attribute has been implemented in the metamodel.
+
+
 == Dependency update
 
 - Switch to Sirius Web 2025.1.3