[1030] Makes sourceFeature and targetFeature redefine source and target

It also:

* Fix the diagram with using the new semantic (creation and
reconnection) since the "virtual" membership can no longer be used in
the source/target feature
* Add IMigrationParticipant to avoid any model breakage
* Fix the Importer to be able to keep tracks of the "virtual" membership
used to "import" 'start'/'done' ActionUsage

Bug: #1030
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>

Author: adaussy

CHANGELOG.adoc

@@ -8,6 +8,8 @@
 
 === Breaking changes
 
+- https://github.com/eclipse-syson/syson/issues/1030[#1030] [metamodel] The _source_ and _target_ features are no longer editable on all concepts inheriting from `ConnectorAsUsage`.
+
 === Dependency update
 
 - [releng] Switch to https://github.com/spring-projects/spring-boot/releases/tag/v3.4.3[Spring Boot 3.4.3].
@@ -27,6 +29,7 @@ A new creation tool is available in the `Requirements` section of the palette, a
 A new dra & drop tool is available on the diagram, allowing moving `Satisfy Requirement Usage` graphical nodes on the diagram.
 - [explorer] The `General View` diagram is now proposed first when creating a diagram.
 - https://github.com/eclipse-syson/syson/issues/1024[#1024] [diagrams] Allow `Usage` and `Definition` graphical node labels to be wrapped to handle long names more easily.
+- https://github.com/eclipse-syson/syson/issues/1030[#1030] [metamodel] `ConnectorAsUsage.getSourceFeature` and `ConnectorAsUsage.getTargetFeature` should redefine `Relationship.source` and `Relationship.target` features
 
 === New features
 
@@ -91,7 +94,6 @@ The changes are:
 - https://github.com/eclipse-syson/syson/issues/1018[#1018] [libraries] Make customizing the default metamodels and libraries available in SysML projects easier by making default implementation `SysONDefaultLibrariesConfiguration.java` more extensible.
 To do so, create a `@Primary @Configuration` component that extend `SysMLDefaultLibrariesConfiguration`, and optionally redefine `getDefaultLibraries()` method and/or `getDefaultEPackages()`.
 
-
 === New features
 
 - https://github.com/eclipse-syson/syson/issues/977[#977] [validation] SysON now implements the constraints (a.k.a. validation rules) from the SysMLv2 specification.

backend/application/syson-application-configuration/src/main/java/org/eclipse/syson/application/migration/SuccessionAsUsageMigrationParticipant.java

@@ -0,0 +1,117 @@
+/*******************************************************************************
+ * Copyright (c) 2025 Obeo.
+ * This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *
+ * Contributors:
+ *     Obeo - initial API and implementation
+ *******************************************************************************/
+package org.eclipse.syson.application.migration;
+
+import com.google.gson.JsonArray;
+import com.google.gson.JsonElement;
+import com.google.gson.JsonObject;
+import com.google.gson.JsonPrimitive;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.eclipse.emf.ecore.EClass;
+import org.eclipse.emf.ecore.EClassifier;
+import org.eclipse.sirius.components.emf.migration.api.IMigrationParticipant;
+import org.eclipse.sirius.emfjson.resource.JsonResource;
+import org.eclipse.syson.sysml.SuccessionAsUsage;
+import org.eclipse.syson.sysml.SysmlPackage;
+import org.springframework.stereotype.Service;
+
+/**
+ * Migration participant used to migrate SysON SysMLv2 models previous to 2025.4.0.
+ *
+ * <p>
+ * It is intended to overcome the previous implementation that serialized data in <i>source</i> and <i>target</i>
+ * features of {@link SuccessionAsUsage} whereas now those features are derived and non editable. See detail at
+ * https://github.com/eclipse-syson/syson/issues/1030
+ * </p>
+ *
+ * @author Arthur Daussy
+ */
+@Service
+public class SuccessionAsUsageMigrationParticipant implements IMigrationParticipant {
+
+    private static final String PARTICIPANT_VERSION = "2025.4.0-202502270000";
+
+    @Override
+    public String getVersion() {
+        return PARTICIPANT_VERSION;
+    }
+
+    @Override
+    public void preDeserialization(JsonResource resource, JsonObject jsonObject) {
+        if (this.isSysMLResource(jsonObject)) {
+            this.collectElementsOfType(jsonObject, SysmlPackage.eINSTANCE.getConnectorAsUsage()).forEach(successionNode -> {
+                successionNode.remove("source");
+                successionNode.remove("target");
+            });
+        }
+    }
+
+    private boolean isSysMLResource(JsonObject jsonObject) {
+        JsonElement nsElements = jsonObject.get("ns");
+        if (nsElements instanceof JsonObject nsElementObjects) {
+            for (String currentKey : nsElementObjects.keySet()) {
+                JsonPrimitive nsURI = nsElementObjects.getAsJsonPrimitive(currentKey);
+                return SysmlPackage.eNS_URI.equals(nsURI.getAsString());
+            }
+        }
+        return false;
+    }
+
+    private List<JsonObject> collectElementsOfType(JsonObject jsonObject, EClass eClass) {
+        List<JsonObject> successionAsUsages = new ArrayList<>();
+        this.collectElementsOfType(jsonObject, eClass, successionAsUsages);
+        return successionAsUsages;
+    }
+
+    private void collectElementsOfType(JsonObject jsonObject, EClass eClass, List<JsonObject> accumulator) {
+        for (String currentKey : jsonObject.keySet()) {
+            Object value = jsonObject.get(currentKey);
+
+            if (value instanceof JsonObject child) {
+                if (this.isInstanceOf(jsonObject, eClass)) {
+                    accumulator.add(child);
+                }
+                this.collectElementsOfType(child, eClass, accumulator);
+            } else if (value instanceof JsonArray jsonArray) {
+                this.collectElementsOfTypeInArray(jsonArray, eClass, accumulator);
+            }
+        }
+    }
+
+    private boolean isInstanceOf(JsonObject child, EClass expectedEClass) {
+        JsonElement eClassQn = child.get("eClass");
+        if (eClassQn instanceof JsonPrimitive jsonPrimitive) {
+            String eClassQualifedName = jsonPrimitive.getAsString();
+            if (eClassQualifedName != null && eClassQualifedName.startsWith("sysml:")) {
+                EClassifier objectEClassier = SysmlPackage.eINSTANCE.getEClassifier(eClassQualifedName.replaceFirst("sysml:", ""));
+                if (objectEClassier instanceof EClass objectEClass && expectedEClass.isSuperTypeOf(objectEClass)) {
+                    return true;
+                }
+            }
+        }
+        return false;
+    }
+
+    private void collectElementsOfTypeInArray(JsonArray jsonArray, EClass eClass, List<JsonObject> accumulator) {
+        for (Object obj : jsonArray) {
+            if (obj instanceof JsonArray) {
+                this.collectElementsOfTypeInArray((JsonArray) obj, eClass, accumulator);
+            } else if (obj instanceof JsonObject) {
+                this.collectElementsOfType((JsonObject) obj, eClass, accumulator);
+            }
+        }
+    }
+}

backend/application/syson-application-configuration/src/main/java/org/eclipse/syson/application/migration/SysONEditingContextMigrationParticipantPredicate.java

@@ -0,0 +1,31 @@
+/*******************************************************************************
+ * Copyright (c) 2025 Obeo.
+ * This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *
+ * Contributors:
+ *     Obeo - initial API and implementation
+ *******************************************************************************/
+package org.eclipse.syson.application.migration;
+
+import org.eclipse.sirius.web.application.editingcontext.services.api.IEditingContextMigrationParticipantPredicate;
+import org.springframework.stereotype.Service;
+
+/**
+ * {@link IEditingContextMigrationParticipantPredicate} used to plug the migration mechanism on SysON SysMLv2 projects.
+ *
+ * @author Arthur Daussy
+ */
+@Service
+public class SysONEditingContextMigrationParticipantPredicate implements IEditingContextMigrationParticipantPredicate {
+
+    @Override
+    public boolean test(String editingContextId) {
+        // No Sysml/Syson project nature at the time of writing to restrict the number of impacted projects.
+        return true;
+    }
+}

backend/application/syson-application-configuration/src/main/resources/templates/Batmobile.json

@@ -12,13 +12,20 @@
  *******************************************************************************/
 package org.eclipse.syson.application.controller.editingContext.checkers;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.Optional;
+import java.util.function.Consumer;
+import java.util.function.Supplier;
+
 import org.eclipse.emf.ecore.EClass;
 import org.eclipse.emf.ecore.EReference;
 import org.eclipse.sirius.components.collaborative.diagrams.dto.DiagramRefreshedEventPayload;
 import org.eclipse.sirius.components.core.api.IObjectSearchService;
 import org.eclipse.sirius.components.graphql.tests.ExecuteEditingContextFunctionSuccessPayload;
 import org.eclipse.syson.application.data.SysMLv2Identifiers;
 import org.eclipse.syson.services.SemanticRunnableFactory;
+import org.eclipse.syson.sysml.Element;
 
 import reactor.test.StepVerifier.Step;
 
@@ -33,9 +40,12 @@ public class SemanticCheckerService {
 
     private final IObjectSearchService objectSearchService;
 
-    public SemanticCheckerService(SemanticRunnableFactory semanticRunnableFactory, IObjectSearchService objectSearchService) {
+    private final String editingContextId;
+
+    public SemanticCheckerService(SemanticRunnableFactory semanticRunnableFactory, IObjectSearchService objectSearchService, String editingContextId) {
         this.semanticRunnableFactory = semanticRunnableFactory;
         this.objectSearchService = objectSearchService;
+        this.editingContextId = editingContextId;
     }
 
     public ISemanticChecker getElementInParentSemanticChecker(String parentLabel, EReference containmentReference, EClass childEClass) {
@@ -45,8 +55,34 @@ public ISemanticChecker getElementInParentSemanticChecker(String parentLabel, ER
                 .hasType(childEClass);
     }
 
+    /**
+     * Do some checks on the element identified by the given id.
+     *
+     * @param <T>
+     *            the type element under test
+     * @param verifier
+     *            the verifier
+     * @param type
+     *            the type of the element under test
+     * @param idSupplier
+     *            a supplier that returns the id of the semantic object
+     * @param semanticChecker
+     *            the checks that needs to be run
+     */
+    public <T extends Element> void checkElement(Step<DiagramRefreshedEventPayload> verifier, Class<T> type, Supplier<String> idSupplier, Consumer<T> semanticChecker) {
+        ISemanticChecker checker = editingContext -> {
+            Optional<Object> optElement = this.objectSearchService.getObject(editingContext, idSupplier.get());
+            assertThat(optElement).isPresent();
+            Object element = optElement.get();
+            assertThat(element).isInstanceOf(type);
+            T castedElement = type.cast(element);
+            semanticChecker.accept(castedElement);
+        };
+        this.checkEditingContext(checker, verifier);
+    }
+
     public void checkEditingContext(ISemanticChecker semanticChecker, Step<DiagramRefreshedEventPayload> verifier) {
-        Runnable runnableChecker = this.semanticRunnableFactory.createRunnable(SysMLv2Identifiers.GENERAL_VIEW_WITH_TOP_NODES_EDITING_CONTEXT_ID,
+        Runnable runnableChecker = this.semanticRunnableFactory.createRunnable(this.editingContextId,
                 (editingContext, executeEditingContextFunctionInput) -> {
                     semanticChecker.check(editingContext);
                     return new ExecuteEditingContextFunctionSuccessPayload(executeEditingContextFunctionInput.id(), true);