[1002] Fix Feature labels using an initial FeatureValue relationship

Bug: #1002
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>

Author: adaussy

CHANGELOG.adoc

@@ -27,6 +27,7 @@ New default names now includes a number, this number corresponding to the count
 They are now properly downloaded.
 Export to textual SysMLv2 is not fully implemented yet so there are still unhandled cases.
 - https://github.com/eclipse-syson/syson/issues/998[#998] Fix `Port Usage` labels in diagrams.
+- https://github.com/eclipse-syson/syson/issues/1002[#1002] Invalid label for Feature (e.g.: `Attribute Usage`) when the `Feature Value` aims to define "initial" value.
 
 === Improvements
 

backend/application/syson-application/src/test/java/org/eclipse/syson/application/export/ImportExportTests.java

@@ -16,6 +16,7 @@
 
 import org.eclipse.sirius.web.application.editingcontext.services.api.IEditingDomainFactory;
 import org.eclipse.syson.AbstractIntegrationTests;
+import org.eclipse.syson.application.configuration.SysMLEditingContextProcessor;
 import org.eclipse.syson.application.export.checker.SysmlImportExportChecker;
 import org.eclipse.syson.sysml.export.SysMLv2DocumentExporter;
 import org.eclipse.syson.sysml.upload.SysMLExternalResourceLoaderService;
@@ -44,11 +45,15 @@ public class ImportExportTests extends AbstractIntegrationTests {
     @Autowired
     private SysMLv2DocumentExporter exporter;
 
+    @Autowired
+    private SysMLEditingContextProcessor sysMLEditingContextProcessor;
+
+
     private SysmlImportExportChecker checker;
 
     @BeforeEach
     public void setUp() {
-        this.checker = new SysmlImportExportChecker(this.sysmlLoader, this.editingDomainFactory, this.exporter);
+        this.checker = new SysmlImportExportChecker(this.sysmlLoader, this.editingDomainFactory, this.exporter, this.sysMLEditingContextProcessor);
     }
 
     /**
@@ -157,6 +162,27 @@ public void checkImportPort() throws IOException {
         this.checker.check(input, input);
     }
 
+    /**
+     * Test import/export of AttributeUsages with FeatureValue with different combination of default or initial value.
+     *
+     * @throws IOException
+     */
+    @DisplayName("Given a model with AttributeUsages with default and initial value, when importing and exporting the model, then the exported text file should be the same as the imported one.")
+    @Test
+    public void checkScalarValueAttribute() throws IOException {
+        var input = """
+                package Occurrences {
+                  private import ScalarValues::*;
+                  occurrence def Occurrence1 {
+                      attribute a : Integer;
+                      attribute b : Integer default = 1;
+                      attribute c : Integer = 1;
+                      attribute d : Integer := 3;
+                  }
+                }""";
+        this.checker.check(input, input);
+    }
+
     /**
      * Test import/export on test file ImportTest.sysml.
      *

backend/application/syson-application/src/test/java/org/eclipse/syson/application/export/checker/SysmlImportExportChecker.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2024 Obeo.
+ * Copyright (c) 2024, 2025 Obeo.
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v2.0
  * which accompanies this distribution, and is available at
@@ -18,6 +18,7 @@
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.util.List;
+import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
 import java.util.UUID;
@@ -26,8 +27,10 @@
 import org.eclipse.emf.ecore.resource.Resource;
 import org.eclipse.emf.edit.domain.AdapterFactoryEditingDomain;
 import org.eclipse.sirius.components.events.ICause;
+import org.eclipse.sirius.web.application.editingcontext.EditingContext;
 import org.eclipse.sirius.web.application.editingcontext.services.api.IEditingDomainFactory;
 import org.eclipse.sirius.web.domain.boundedcontexts.project.Project;
+import org.eclipse.syson.application.configuration.SysMLEditingContextProcessor;
 import org.eclipse.syson.sysml.export.SysMLv2DocumentExporter;
 import org.eclipse.syson.sysml.upload.SysMLExternalResourceLoaderService;
 import org.springframework.http.MediaType;
@@ -45,8 +48,13 @@ public class SysmlImportExportChecker {
 
     private final SysMLv2DocumentExporter exporter;
 
-    public SysmlImportExportChecker(SysMLExternalResourceLoaderService sysmlLoader, IEditingDomainFactory editingDomainFactory, SysMLv2DocumentExporter exporter) {
+    private final SysMLEditingContextProcessor sysMLEditingContextProcessor;
+
+
+
+    public SysmlImportExportChecker(SysMLExternalResourceLoaderService sysmlLoader, IEditingDomainFactory editingDomainFactory, SysMLv2DocumentExporter exporter, SysMLEditingContextProcessor sysMLEditingContextProcessor) {
         super();
+        this.sysMLEditingContextProcessor = Objects.requireNonNull(sysMLEditingContextProcessor);
         this.sysmlLoader = Objects.requireNonNull(sysmlLoader);
         this.editingDomainFactory = editingDomainFactory;
         this.exporter = exporter;
@@ -56,6 +64,8 @@ public void check(String importedText, String expectedResult) throws IOException
 
         UUID uuid = UUID.randomUUID();
         AdapterFactoryEditingDomain editingDomain = this.editingDomainFactory.createEditingDomain(this.createFakeProject(uuid));
+        EditingContext editingContext = new EditingContext(UUID.randomUUID().toString(), editingDomain, Map.of(), List.of());
+        this.sysMLEditingContextProcessor.preProcess(editingContext);
 
         try (var inputStream = new ByteArrayInputStream(importedText.getBytes())) {
             Optional<Resource> optLoadedResources = this.sysmlLoader.getResource(inputStream, this.createFakeURI(uuid), editingDomain.getResourceSet(), false);

backend/services/syson-services/src/main/java/org/eclipse/syson/services/LabelService.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2023, 2024 Obeo.
+ * Copyright (c) 2023, 2025 Obeo.
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v2.0
  * which accompanies this distribution, and is available at
@@ -555,13 +555,24 @@ protected String getValueLabel(Usage usage) {
             }
             label
                     .append(LabelConstants.SPACE)
-                    .append(LabelConstants.EQUAL)
+                    .append(getFeatureValueRelationshipSymbol(featureValue.get()))
                     .append(LabelConstants.SPACE)
                     .append(valueAsString);
         }
         return label.toString();
     }
 
+    private String getFeatureValueRelationshipSymbol(FeatureValue featureValueMembership) {
+        final String affectationSymbole;
+
+        if (featureValueMembership.isIsInitial()) {
+            affectationSymbole = ":=";
+        } else {
+            affectationSymbole = LabelConstants.EQUAL;
+        }
+        return affectationSymbole;
+    }
+
     /**
      * Get the value of the given {@link Expression} as a string.
      *

backend/views/syson-diagram-common-view/src/test/java/org/eclipse/syson/diagram/common/view/services/ViewLabelServiceTest.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2024 Obeo.
+ * Copyright (c) 2024, 2025 Obeo.
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v2.0
  * which accompanies this distribution, and is available at
@@ -84,6 +84,26 @@ void testItemCompartmentLabelWithNameAndShortName() {
                 this.viewLabelService.getCompartmentItemLabel(attributeUsage));
     }
 
+    @DisplayName("Given a FeatureValue to an attribute, when it is an initial FeatureValue relationship, then the label should use the symbole ':=' instead of '='")
+    @Test
+    public void testInitalFeatureValueSymboleLabel() {
+        AttributeUsage attributeUsage = SysmlFactory.eINSTANCE.createAttributeUsage();
+        attributeUsage.setDeclaredName(ATTRIBUTE_USAGE_NAME);
+
+        LiteralInteger literal = SysmlFactory.eINSTANCE.createLiteralInteger();
+        literal.setValue(1);
+        FeatureValue featureValue = SysmlFactory.eINSTANCE.createFeatureValue();
+        featureValue.getOwnedRelatedElement().add(literal);
+        attributeUsage.getOwnedRelationship().add(featureValue);
+
+        assertEquals("myAttributeUsage = 1", this.viewLabelService.getCompartmentItemLabel(attributeUsage));
+
+        featureValue.setIsInitial(true);
+
+        assertEquals("myAttributeUsage := 1", this.viewLabelService.getCompartmentItemLabel(attributeUsage));
+
+    }
+
     @DisplayName("Check Attribute Usage item label with no name")
     @Test
     void testItemCompartmentLabelWithoutName() {

doc/content/modules/user-manual/pages/release-notes/2025.2.0.adoc

@@ -33,6 +33,7 @@ For example, if a `PartDefinition` already defines 5 parts, then a new `Part` cr
 They are now properly downloaded.
 Export to textual SysMLv2 is not fully implemented yet so there are still unhandled cases.
 - Fix `Port Usage` labels in diagrams (feature typing was incorrectly duplicated).
+- In diagrams, labels of `Usages` (e.g.: `Attribute Usages`) with a `FeatureValue` relationship having an _initial_ property set to true now use the ":=" symbole instead of "=".
 
 == New features