[1052] Fix New Port In/Inout/Out tools in GeneralView

Bug: #1052
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>

Author: AxelRICHARD

CHANGELOG.adoc

@@ -35,6 +35,7 @@ Export to textual SysMLv2 is not fully implemented yet so there are still unhand
 - https://github.com/eclipse-syson/syson/issues/1003[#1003] Invalid label for `Usages` (e.g.: `Attribute Usage`) when their `Feature Value` aims to define "default" value.
 - https://github.com/eclipse-syson/syson/issues/1020[#1020] [general-view] The multiplicity should not be displayed on edges.
 - https://github.com/eclipse-syson/syson/issues/1009[#1009] [metamodel] Fix an issue where the diagram direct edit on graphical nodes could raise a backend error on unsettable enum attributes.
+- https://github.com/eclipse-syson/syson/issues/1052[#1052] [general-view] Fix an issue where the execution of "New Port In/Inout/Out" tools was failing.
 
 === Improvements
 
@@ -95,7 +96,7 @@ The _Validation_ view show the results of the execution of the constraints on yo
 
 === Dependency update
 
-- [releng] Switch to Sirius Web 2025.1.0
+- [releng] Switch to Sirius Web 2025.1.7
 - [releng] Upgrade `turbo` to version 2.3.3 (from 1.13.3 before)
 The `start` task used in our turbo configuration is now marked as `persistent` and as a result we have separated the `start` script from `syson` used to run the frontend in dev from from the `start` script from other packages used to build them in development mode by renaming the later to `build-dev`.
 - [releng] Switch to https://github.com/spring-projects/spring-boot/releases/tag/v3.4.1[Spring Boot 3.4.1].

backend/application/syson-application/src/test/java/org/eclipse/syson/application/controllers/diagrams/general/view/GVSubNodeStructureCreationTests.java

@@ -236,6 +236,14 @@ private static Stream<Arguments> partUsageSiblingNodeParameters() {
                 .map(TestNameGenerator::namedArguments);
     }
 
+    private static Stream<Arguments> directedPortsInPartDefinitionChildNodeParameters() {
+        return Stream.of(
+                Arguments.of(SysmlPackage.eINSTANCE.getPortUsage(), "ports", SysmlPackage.eINSTANCE.getDefinition_OwnedPort(), "New Port In"),
+                Arguments.of(SysmlPackage.eINSTANCE.getPortUsage(), "ports", SysmlPackage.eINSTANCE.getDefinition_OwnedPort(), "New Port Inout"),
+                Arguments.of(SysmlPackage.eINSTANCE.getPortUsage(), "ports", SysmlPackage.eINSTANCE.getDefinition_OwnedPort(), "New Port Out"))
+                .map(TestNameGenerator::namedArguments);
+    }
+
     @BeforeEach
     public void setUp() {
         this.givenInitialServerState.initialize();
@@ -431,4 +439,18 @@ public void createPartUsageSiblingNodes(EClass childEClass, EReference containme
                 this.diagram, this.verifier);
         this.semanticCheckerService.checkEditingContext(this.semanticCheckerService.getElementInParentSemanticChecker(parentLabel, containmentReference, childEClass), this.verifier);
     }
+
+    @Sql(scripts = { "/scripts/syson-test-database.sql" }, executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD)
+    @Sql(scripts = { "/scripts/cleanup.sql" }, executionPhase = Sql.ExecutionPhase.AFTER_TEST_METHOD, config = @SqlConfig(transactionMode = SqlConfig.TransactionMode.ISOLATED))
+    @ParameterizedTest
+    @MethodSource("directedPortsInPartDefinitionChildNodeParameters")
+    public void createDirectedPortsInPartDefinitionChildNodeParameters(EClass childEClass, String compartmentName, EReference containmentReference, String creationToolName) {
+        EClass parentEClass = SysmlPackage.eINSTANCE.getPartDefinition();
+        String parentLabel = "PartDefinition";
+        this.creationTestsService.createNode(this.verifier, this.diagramDescriptionIdProvider, this.diagram, parentEClass, parentLabel, creationToolName);
+        this.diagramCheckerService.checkDiagram(
+                this.diagramCheckerService.getCompartmentNodeGraphicalChecker(this.diagram, this.diagramDescriptionIdProvider, parentLabel, parentEClass, containmentReference, compartmentName),
+                this.diagram, this.verifier);
+        this.semanticCheckerService.checkEditingContext(this.semanticCheckerService.getElementInParentSemanticChecker(parentLabel, containmentReference, childEClass), this.verifier);
+    }
 }

backend/views/syson-diagram-common-view/src/main/java/org/eclipse/syson/diagram/common/view/services/ViewCreateService.java

@@ -237,9 +237,9 @@ public Element createCompartmentItemWithDirection(Element element, String eRefer
             if (item instanceof Element elementItem) {
                 var membership = this.createAppropriateMembership(structuralFeature);
                 element.getOwnedRelationship().add(membership);
-                membership.getOwnedRelatedElement().add(result);
+                membership.getOwnedRelatedElement().add(elementItem);
                 result = this.elementInitializer(elementItem);
-                if (directionLiteral != null && item instanceof Feature feature) {
+                if (directionLiteral != null && elementItem instanceof Feature feature) {
                     feature.setDirection(FeatureDirectionKind.get(directionLiteral));
                     result.setDeclaredName(result.getName() + StringUtils.capitalize(directionLiteral));
                 }

doc/content/modules/user-manual/pages/release-notes/2025.2.0.adoc

@@ -28,6 +28,7 @@ Export to textual SysMLv2 is not fully implemented yet so there are still unhand
 - In diagrams, labels of `Usages` (e.g.: `Attribute Usages`) with a `Feature Value` relationship having the _initial_ property set to true now use the ":=" symbol instead of "=".
 - In diagrams, labels of `Usages` (e.g.: `Attribute Usages`) with a `Feature Value` relationship having the _default_ property set to true now display the _default_ keyword.
 - In the `General View` diagram, the multiplicity is no longer displayed on graphical edges to conform to the SysMLv2 specification.
+- In the `General View` diagram, fix an issue where the execution of `New Port In/Inout/Out` tools was failing.
 
 == New features
 
@@ -128,7 +129,7 @@ To do so, create a `@Primary @Configuration` that extend `SysMLDefaultLibrariesC
 
 == Dependency update
 
-- Switch to Sirius Web 2025.1.6
+- Switch to Sirius Web 2025.1.7
 - Switch to SysIDE 0.8.0
 - Upgrade `turbo` to version 2.3.3
 - Switch to Spring Boot 3.4.1