feat(terminal): synchronize onOutput with buffer updates using onWriteParsed#16934
Open
Fangoling wants to merge 2 commits intoeclipse-theia:masterfrom
Open
feat(terminal): synchronize onOutput with buffer updates using onWriteParsed#16934Fangoling wants to merge 2 commits intoeclipse-theia:masterfrom
Fangoling wants to merge 2 commits intoeclipse-theia:masterfrom
Conversation
Member
|
Hi @Fangoling, could you add a few test instructions in the PR description please? TIA! |
Signed-off-by: Fangxing Liu <fx.liu@tum.de>
9468d5d to
977a081
Compare
Signed-off-by: Fangxing Liu <fx.liu@tum.de>
Contributor
Author
I added two logs on debug level to the event for testing purposes of this pr. I would remove them before the merge of this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This implements the feature proposed in #16874.
Previously, the onOutput event fired immediately when
write()orwriteln()was called. This change buffers the output data and defers the event emission until xterm firesonWriteParsed.This prevents race conditions by ensuring the
onOutputevent fires only after xterm has fully parsed and synchronized the buffer, rather than immediately upon the method call.How to test
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers