Conversation
Remove header to align with other quick-picks. Render a placeholder that provides information. Show opened image files as options. Always show clipboard option as the last option. Signed-off-by: Simon Graband <sgraband@eclipsesource.com>
|
@ndoschek What would you think about showing the 10 first found files, if no images are currently open? This would make it more explicit to the user that he can also search for files without reading the placeholder. |
ndoschek
left a comment
ndoschek
left a comment
There was a problem hiding this comment.
Hi @sgraband, thanks, this is a nice improvement!
The removal of the header, the placeholder text, and showing opened image files all look good.
A few suggestions:
- Instead of only showing currently opened image files, I'd suggest showing "recently opened" files filtered by images. This is the pattern we use elsewhere in Theia's quick input selecting files and would automatically include currently opened files as well. It should also show the blue "recently opened" label as we have for the file picker I'd suggest. This would then not need a new concept like searching and showing N images.
- Consider adding
QuickPickSeparators to visually separate the sections - e.g. between "recently opened" images and the clipboard entry.
This also partially addresses #15946. Could you link that issue as well, so the remaining items are easier to track?
| const mainWidgets = this.shell.getWidgets('main'); | ||
|
|
||
| // Use NavigatableWidget.get() helper to find widgets with URIs | ||
| for (const [uri] of NavigatableWidget.get(mainWidgets)) { |
There was a problem hiding this comment.
Could be simplified by using the filter parameter of NavigatableWidget.get() instead of filtering manually afterwards
2 participants
What it does
Remove header to align with other quick-picks.
Render a placeholder that provides information.
Show opened image files as options.
Always show clipboard option as the last option.
Fixes #16707
How to test
Click the + in the chat and select image file.
Search for files and ensure that open files are shown right away.
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers