Skip to content

Commit 2ee7d0b

Browse files
authored
Merge pull request #99 from eclipse-thingweb/refactor-has-client
chore!(servient): remove `hasClientFor` method
2 parents f252675 + 8b40a72 commit 2ee7d0b

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

lib/src/core/implementation/consumed_thing.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ class ConsumedThing implements scripting_api.ConsumedThing {
5959
/// Determines the id of this [ConsumedThing].
6060
String get identifier => thingDescription.identifier;
6161

62-
/// Checks if the [Servient] of this [ConsumedThing] supports a protocol
63-
/// [scheme].
64-
bool hasClientFor(String scheme) => servient.hasClientFor(scheme);
65-
6662
(ProtocolClient client, AugmentedForm form) _getClientFor(
6763
List<Form> forms,
6864
OperationType operationType,

lib/src/core/implementation/servient.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,6 @@ class Servient {
208208
ProtocolClientFactory? removeClientFactory(String scheme) =>
209209
_clientFactories.remove(scheme);
210210

211-
/// Checks whether a [ProtocolClient] is avaiable for a given [scheme].
212-
bool hasClientFor(String scheme) => _clientFactories.containsKey(scheme);
213-
214211
/// Returns the [ProtocolClient] associated with a given [scheme].
215212
ProtocolClient clientFor(String scheme) {
216213
final clientFactory = _clientFactories[scheme];

test/core/servient_test.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ void main() {
4444
);
4545

4646
expect(servient.clientSchemes, [testUriScheme]);
47-
expect(servient.hasClientFor(testUriScheme), true);
4847
});
4948

5049
test(
@@ -53,11 +52,11 @@ void main() {
5352
final servient = Servient()
5453
..addClientFactory(MockedProtocolClientFactory());
5554

56-
expect(servient.hasClientFor(testUriScheme), true);
55+
expect(servient.clientSchemes.contains(testUriScheme), true);
5756

5857
servient.removeClientFactory(testUriScheme);
5958

60-
expect(servient.hasClientFor(testUriScheme), false);
59+
expect(servient.clientSchemes.contains(testUriScheme), false);
6160
expect(servient.clientSchemes.length, 0);
6261
},
6362
);

0 commit comments

Comments
 (0)