chore(binding-opcua): fix floating promise issues

Author: erossignon

packages/binding-opcua/src/certificate-manager-singleton.ts

@@ -47,7 +47,9 @@ export class CertificateManagerSingleton {
         if (CertificateManagerSingleton._certificateManager) {
             CertificateManagerSingleton._certificateManager.referenceCounter--;
             // dispose is degined to free resources if referenceCounter==0;
-            CertificateManagerSingleton._certificateManager.dispose();
+            CertificateManagerSingleton._certificateManager.dispose().catch((err) => {
+                console.error("Error disposing CertificateManager", err);
+            });
             CertificateManagerSingleton._certificateManager = null;
         }
     }

packages/binding-opcua/src/factory.ts

@@ -54,7 +54,9 @@ export class OPCUAClientFactory implements ProtocolClientFactory {
             for (const client of clients) {
                 await client.stop();
             }
-        })();
+        })().catch((err) => {
+            console.error("Error destroying clients", err);
+        });
         return true;
     }
 }

packages/binding-opcua/src/opcua-protocol-client.ts

@@ -495,7 +495,7 @@ export class OPCUAProtocolClient implements ProtocolClient {
 
     async unlinkResource(form: OPCUAForm): Promise<void> {
         debug(`unlinkResource: form ${OPCUAProtocolClient.getNodeId(form)}`);
-        this._withSubscription<void>(form, async (session, subscription) => {
+        await this._withSubscription<void>(form, async (session, subscription) => {
             const nodeId = await this._resolveNodeId(form);
             await this._unmonitor(nodeId);
         });

packages/binding-opcua/test/client-test.ts

@@ -170,10 +170,18 @@ describe("OPCUA Client", function () {
                     resolve();
                 }
             };
-            client.subscribeResource(form, onSubscribedValueChanged);
-            client.subscribeResource(form, onSubscribedValueChanged);
-            client.subscribeResource(form, onSubscribedValueChanged);
-            client.subscribeResource(form, onSubscribedValueChanged);
+            client.subscribeResource(form, onSubscribedValueChanged).catch((err) => {
+                console.error("Error in subscribeResource 1:", err);
+            });
+            client.subscribeResource(form, onSubscribedValueChanged).catch((err) => {
+                console.error("Error in subscribeResource 2:", err);
+            });
+            client.subscribeResource(form, onSubscribedValueChanged).catch((err) => {
+                console.error("Error in subscribeResource 3:", err);
+            });
+            client.subscribeResource(form, onSubscribedValueChanged).catch((err) => {
+                console.error("Error in subscribeResource 4:", err);
+            });
         });
     });
 

packages/binding-opcua/test/fixture/basic-opcua-server.ts

@@ -295,10 +295,12 @@ export async function startServer(): Promise<OPCUAServer> {
 }
 
 if (require.main === module) {
-    (async () => {
+    const main = async () => {
         const server = await startServer();
-        process.once("SIGINT", () => {
-            server.shutdown();
-        });
-    })();
+        await new Promise<void>((resolve) => process.once("SIGINT", resolve));
+        await server.shutdown();
+    };
+    main().catch((err) => {
+        console.error("Error = ", err);
+    });
 }

packages/binding-opcua/test/full-opcua-thing-test.ts

@@ -345,7 +345,9 @@ describe("Full OPCUA Thing Test", () => {
         const wot = await servient.start();
         const thing = await wot.produce(thingDescription);
 
-        thing.expose();
+        thing.expose().catch((err) => {
+            console.error(`Cannot expose thing: ${err}`);
+        });
 
         let temperature = 10;
         const readHandler = async () => temperature;

packages/binding-opcua/test/opcua-security-test.ts

@@ -337,13 +337,13 @@ describe("Testing OPCUA Security Combination", () => {
 
         // Client should trust client certificate
         const serverCertificate = opcuaServer.getCertificate();
-        clientCertificateManager.trustCertificate(serverCertificate);
+        await clientCertificateManager.trustCertificate(serverCertificate);
 
         // Server should trust application client certificate
         const client = OPCUAClient.create({ clientCertificateManager });
         await client.createDefaultCertificate();
         const clientCertificate = client.getCertificateChain();
-        serverCertificateManager.trustCertificate(clientCertificate);
+        await serverCertificateManager.trustCertificate(clientCertificate);
 
         // let's create the x509 Certificate for User JoeDoe
         const joedoeX509CertificateFilename = path.join(
@@ -363,7 +363,7 @@ describe("Testing OPCUA Security Combination", () => {
 
         // server should trust x509 User certificate
         const userCertificateManager = opcuaServer.userCertificateManager;
-        userCertificateManager.trustCertificate(joedoeX509Cerficate);
+        await userCertificateManager.trustCertificate(joedoeX509Cerficate);
 
         // adjust thingDescription x509 parameters with generated certficate info
         const joedoeX509CertificatePem = readCertificatePEM(joedoeX509CertificateFilename);