Improved opcua example #1452
Improved opcua example #1452
Conversation
erossignon
requested review from
JKRhb,
danielpeintner and
relu91
as code owners
|
Improve client example , by making it more comprehensive with a CLI dashboard 
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1452 +/- ##
==========================================
- Coverage 77.58% 77.44% -0.14%
==========================================
Files 79 83 +4
Lines 15331 15826 +495
Branches 1445 1506 +61
==========================================
+ Hits 11894 12256 +362
- Misses 3414 3545 +131
- Partials 23 25 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erossignon
force-pushed
the
ImprovedOPCUAExample
branch
from
646f6c5 to
3582c49
Compare
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
Thanks. That's a good addition!
See some of my comments below
erossignon
force-pushed
the
ImprovedOPCUAExample
branch
2 times, most recently
from
05ec392 to
8c5068c
Compare
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
LGTM
@relu91 @egekorkan @JKRhb others?
Any comment?
|
Shall we merge it to main branch ? |
|
Let's ping @relu91 @egekorkan @JKRhb and others again? |
packages/examples/src/bindings/opcua/opcua-coffee-machine-thing-description.ts
Show resolved
Hide resolved
|
@erossignon can you take a look at the points @egekorkan raised... thanks! |
|
Yes, I did already. |
packages/examples/src/bindings/opcua/opcua-coffee-machine-demo.ts
Outdated
Show resolved
Hide resolved
erossignon
force-pushed
the
ImprovedOPCUAExample
branch
from
8c5068c to
a213417
Compare
|
Ok given that @danielpeintner already approved, we can merge this. |
4 participants
No description provided.