@@ -4505,10 +4505,6 @@ UINT temp_realm_length = 0;
45054505 if ((length - consumed_length) > length)
45064506 {
45074507 /* Underflow error has occurred.*/
4508- /* TODO: Should an HTTP Internal Error response be sent? Here? Would have to
4509- duplicate it at the other length calculations. Or, do so in put_process_end label?
4510- */
4511- // TODO write tests against this
45124508
45134509 /* Send response back to HTTP Client. */
45144510 _nx_web_http_server_response_send(server_ptr, NX_WEB_HTTP_STATUS_INTERNAL_ERROR,
@@ -4522,7 +4518,6 @@ UINT temp_realm_length = 0;
45224518 status = NX_UNDERFLOW;
45234519 goto put_process_end;
45244520 }
4525- //length = length - ((ULONG)(packet_ptr -> nx_packet_append_ptr - packet_ptr -> nx_packet_prepend_ptr) - offset);
45264521 length -= consumed_length;
45274522
45284523 /* Increment the bytes received count. */
@@ -4564,9 +4559,6 @@ UINT temp_realm_length = 0;
45644559 if ((length - consumed_length) > length)
45654560 {
45664561 /* Underflow error has occurred.*/
4567- /* TODO: Should an HTTP Internal Error response be sent? Here? Would have to
4568- duplicate it at the other length calculations. Do in put_process_end label?
4569- */
45704562
45714563 /* Send response back to HTTP Client. */
45724564 _nx_web_http_server_response_send(server_ptr, NX_WEB_HTTP_STATUS_INTERNAL_ERROR,
@@ -4580,7 +4572,6 @@ UINT temp_realm_length = 0;
45804572 status = NX_UNDERFLOW;
45814573 goto put_process_end;
45824574 }
4583- //length = length - (ULONG)(next_packet_ptr -> nx_packet_append_ptr - next_packet_ptr -> nx_packet_prepend_ptr);
45844575 length -= consumed_length;
45854576
45864577 /* Increment the bytes received count. */
@@ -4658,9 +4649,6 @@ UINT temp_realm_length = 0;
46584649 if ((length - consumed_length) > length)
46594650 {
46604651 /* Underflow error has occurred.*/
4661- /* TODO: Should an HTTP Internal Error response be sent? Here? Would have to
4662- duplicate it at the other length calculations. Do in put_process_end label?
4663- */
46644652
46654653 /* Send response back to HTTP Client. */
46664654 _nx_web_http_server_response_send(server_ptr, NX_WEB_HTTP_STATUS_INTERNAL_ERROR,
@@ -4674,8 +4662,6 @@ UINT temp_realm_length = 0;
46744662 status = NX_UNDERFLOW;
46754663 goto put_process_end;
46764664 }
4677- // TODO: is UINT correct? Should be ULONG?
4678- //length = length - (UINT)(next_packet_ptr -> nx_packet_append_ptr - next_packet_ptr -> nx_packet_prepend_ptr);
46794665 length -= consumed_length;
46804666
46814667 /* Increment the bytes received count. */
@@ -4716,7 +4702,6 @@ UINT temp_realm_length = 0;
47164702 }
47174703 put_process_end:
47184704 /* Always attempt cleanup by closing the file. */
4719- // TODO: Write tests against this
47204705 fx_file_close(&(server_ptr -> nx_web_http_server_file));
47214706 return;
47224707}
0 commit comments