Skip to content

Fix the issue of byte pool alloc fail when compile with -O3 optimization #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the issue of byte pool alloc fail when compile with -O3 optimization #367

wants to merge 1 commit into from

Conversation

yuhiping
Copy link

@yuhiping yuhiping commented Feb 28, 2024 •
edited
Loading

#334

PR checklist

  • Updated function header with a short description and version number
  • Added test case for bug fix or new feature
  • Validated on real hardware

@freyc
Copy link

freyc commented Apr 30, 2024

It seems that the root-cause for this issue is a missing memory-clobber/compiler-barrier in the TX_DISABLE and TX_RESTORE macros (#334 (comment)).
I would suggest fixing this issue in the cpu-specific ports instead. There might be other places in the code with possible issues because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@amgross amgross amgross approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuhiping @freyc @amgross