Skip to content

Commit 9d9cca7

Browse files
committed
server: simplify swagger definition and stubs for xValues of SeriesModel
Signed-off-by: Bernd Hufmann <[email protected]>
1 parent c6fce71 commit 9d9cca7

File tree

9 files changed

+114
-289
lines changed

9 files changed

+114
-289
lines changed

trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests/src/org/eclipse/tracecompass/incubator/trace/server/jersey/rest/core/tests/services/GenericXYDataProviderServiceTest.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,14 @@
3434
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.EntryStub;
3535
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.ExperimentModelStub;
3636
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.IAxisDomainStub;
37+
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.RangeStub;
38+
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.TmfXYAxisDescriptionStub;
3739
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.XyEntryModelStub;
3840
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.XyEntryStub;
39-
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.XyTreeOutputResponseStub;
40-
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.ISamplingStub;
41-
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.ISamplingStub.RangesStub.RangeStub;
42-
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.TmfXYAxisDescriptionStub;
4341
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.XyModelStub;
4442
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.XyOutputResponseStub;
4543
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.XySeriesStub;
44+
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.XyTreeOutputResponseStub;
4645
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.utils.RestServerTest;
4746
import org.eclipse.tracecompass.internal.tmf.core.Activator;
4847
import org.eclipse.tracecompass.tmf.core.model.StyleProperties;
@@ -231,12 +230,12 @@ public void testCallStackFunctionDensityDataProvider() throws InterruptedExcepti
231230
List<RangeStub> xValues = seriesStub.getXRanges();
232231
assertNotNull(xValues);
233232
assertFalse(xValues.isEmpty());
234-
List<ISamplingStub.RangesStub.RangeStub> expectedRanges = Arrays.asList(
235-
new ISamplingStub.RangesStub.RangeStub(0L, 1195708549L),
236-
new ISamplingStub.RangesStub.RangeStub(1195708550L, 2391417098L),
237-
new ISamplingStub.RangesStub.RangeStub(2391417099L, 3587125647L),
238-
new ISamplingStub.RangesStub.RangeStub(3587125648L, 4782834196L),
239-
new ISamplingStub.RangesStub.RangeStub(4782834197L, 5978542746L)
233+
List<RangeStub> expectedRanges = Arrays.asList(
234+
new RangeStub(0L, 1195708549L),
235+
new RangeStub(1195708550L, 2391417098L),
236+
new RangeStub(2391417099L, 3587125647L),
237+
new RangeStub(3587125648L, 4782834196L),
238+
new RangeStub(4782834197L, 5978542746L)
240239
);
241240
List<RangeStub> actualRanges = xValues;
242241
assertEquals("Range size mismatch", expectedRanges.size(), actualRanges.size());

trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests/src/org/eclipse/tracecompass/incubator/trace/server/jersey/rest/core/tests/stubs/ISamplingStub.java

Lines changed: 0 additions & 197 deletions
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
/**********************************************************************
2+
* Copyright (c) 2025 Ericsson
3+
*
4+
* All rights reserved. This program and the accompanying materials are
5+
* made available under the terms of the Eclipse Public License 2.0 which
6+
* accompanies this distribution, and is available at
7+
* https://www.eclipse.org/legal/epl-2.0/
8+
*
9+
* SPDX-License-Identifier: EPL-2.0
10+
**********************************************************************/
11+
package org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs;
12+
13+
import java.io.Serializable;
14+
import java.util.Objects;
15+
16+
import org.eclipse.jdt.annotation.Nullable;
17+
import org.eclipse.tracecompass.tmf.core.model.ISampling.Range;
18+
19+
import com.fasterxml.jackson.annotation.JsonCreator;
20+
import com.fasterxml.jackson.annotation.JsonProperty;
21+
22+
/**
23+
* Stub version of {@link Range}.
24+
*
25+
* @author Siwei Zhang
26+
*/
27+
public final class RangeStub implements Serializable {
28+
private static final long serialVersionUID = 1L;
29+
30+
private final long fStart;
31+
private final long fEnd;
32+
33+
/**
34+
* Constructor
35+
*
36+
* @param start
37+
* the start value
38+
* @param end
39+
* the end value
40+
*/
41+
@JsonCreator
42+
public RangeStub(@JsonProperty("start") Long start, @JsonProperty("end") Long end) {
43+
this.fStart = start;
44+
this.fEnd = end;
45+
}
46+
47+
/**
48+
* @return the start value
49+
*/
50+
public long getStart() {
51+
return fStart;
52+
}
53+
54+
/**
55+
* @return the end value
56+
*/
57+
public long getEnd() {
58+
return fEnd;
59+
}
60+
61+
@Override
62+
public boolean equals(@Nullable Object obj) {
63+
return (this == obj) || (obj instanceof RangeStub other &&
64+
fStart == other.fStart && fEnd == other.fEnd);
65+
}
66+
67+
@Override
68+
public int hashCode() {
69+
return Objects.hash(fStart, fEnd);
70+
}
71+
72+
@Override
73+
public String toString() {
74+
return "[" + fStart + ", " + fEnd + "]"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
75+
}
76+
}

trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests/src/org/eclipse/tracecompass/incubator/trace/server/jersey/rest/core/tests/stubs/XySeriesStub.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import java.util.Objects;
1616

1717
import org.eclipse.jdt.annotation.Nullable;
18-
import org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests.stubs.ISamplingStub.RangesStub.RangeStub;
1918

2019
import com.fasterxml.jackson.annotation.JsonCreator;
2120
import com.fasterxml.jackson.annotation.JsonProperty;

trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core.tests/src/org/eclipse/tracecompass/incubator/trace/server/jersey/rest/core/tests/webapp/SamplingSerializerTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,4 @@ public void serialize(TestSampling value, JsonGenerator gen, SerializerProvider
136136
gen.writeEndObject();
137137
}
138138
}
139-
140-
141139
}

trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/model/StartEndRange.java renamed to trace-server/org.eclipse.tracecompass.incubator.trace.server.jersey.rest.core/src/org/eclipse/tracecompass/incubator/internal/trace/server/jersey/rest/core/model/Range.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,17 @@
77
* Represents a closed interval [start, end] for a sampling range.
88
*/
99
@Schema(
10-
name = "StartEndRange",
10+
name = "Range",
1111
description = "An object representing a closed interval with a start and end."
1212
)
13-
class StartEndRange {
13+
class Range {
1414
@Schema(description = "Start of the range (inclusive).", requiredMode = RequiredMode.REQUIRED)
1515
private final long start;
1616

1717
@Schema(description = "End of the range (inclusive).", requiredMode = RequiredMode.REQUIRED)
1818
private final long end;
1919

20-
public StartEndRange(long start, long end) {
20+
public Range(long start, long end) {
2121
this.start = start;
2222
this.end = end;
2323
}

0 commit comments

Comments
 (0)