tmf:refresh open state system analysis

Refresh open state system analysis during fetchTree

Signed-off-by: Yassine Ibhir <[email protected]>

pr review suggestions

Author: theibhir

tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/statesystem/provider/StateSystemDataProvider.java

@@ -102,7 +102,7 @@ public class StateSystemDataProvider extends AbstractTmfTraceDataProvider implem
     private final Map<ITmfStateSystem, Long> fSsToId = new HashMap<>();
     private final List<ModuleEntryModel> fModuleEntryModelList = new ArrayList<>();
 
-    private final Map<ITmfAnalysisModuleWithStateSystems, Boolean> fModulesToStatus = new HashMap<>();
+    private final Map<ITmfAnalysisModuleWithStateSystems, Boolean> fModulesToStatus = new ConcurrentHashMap<>();
 
     /*
      * Entry Builder is a table to stash the entries so it won't duplicate the
@@ -176,8 +176,19 @@ public class StateSystemDataProvider extends AbstractTmfTraceDataProvider implem
      */
     public StateSystemDataProvider(ITmfTrace trace) {
         super(trace);
+        updateRegisteredAnalysisModules(trace);
+    }
+
+    private void updateRegisteredAnalysisModules(ITmfTrace trace) {
+        Set<ITmfAnalysisModuleWithStateSystems> traceAnalyses = new HashSet<>(fModulesToStatus.keySet());
         for (ITmfAnalysisModuleWithStateSystems module : Objects.requireNonNull(Iterables.filter(trace.getAnalysisModules(), ITmfAnalysisModuleWithStateSystems.class))) {
-            fModulesToStatus.put(module, false);
+            traceAnalyses.remove(module);
+            fModulesToStatus.putIfAbsent(module, false);
+        }
+
+        // Remove any deleted state system modules
+        for (ITmfAnalysisModuleWithStateSystems module : traceAnalyses) {
+            fModulesToStatus.remove(module);
         }
     }
 
@@ -506,6 +517,7 @@ public int getQuark() {
 
     @Override
     public @NonNull TmfModelResponse<TmfTreeModel<TimeGraphEntryModel>> fetchTree(Map<String, Object> fetchParameters, @Nullable IProgressMonitor monitor) {
+
         // need to create the tree
         boolean fetchTreeIsComplete;
         synchronized (fEntryBuilder) {
@@ -529,6 +541,8 @@ public int getQuark() {
     private boolean addTrace(@Nullable IProgressMonitor monitor) {
         boolean fetchTreeIsComplete = true;
         ITmfTrace trace = getTrace();
+        // Add newly created analysis and remove deleted analysis/add newly created analysis
+        updateRegisteredAnalysisModules(trace);
 
         // look if the trace entry already exist
         String traceName = Objects.requireNonNull(trace.getName());