tmf: remove unnecessary cast

arfio · MatthewKhouzam · commit 871c45049cd8 · 2024-11-04T18:29:08.000-05:00
Signed-off-by: Arnaud Fiorini &lt;fiorini.arnaud@gmail.com&gt;
diff --git a/analysis/org.eclipse.tracecompass.analysis.os.linux.core.tests/src/org/eclipse/tracecompass/analysis/os/linux/core/tests/inputoutput/AbstractTestInputOutput.java b/analysis/org.eclipse.tracecompass.analysis.os.linux.core.tests/src/org/eclipse/tracecompass/analysis/os/linux/core/tests/inputoutput/AbstractTestInputOutput.java
@@ -31,7 +31,6 @@
 import org.eclipse.tracecompass.tmf.core.exceptions.TmfTraceException;
 import org.eclipse.tracecompass.tmf.core.signal.TmfTraceOpenedSignal;
 import org.eclipse.tracecompass.tmf.core.trace.ITmfTrace;
-import org.eclipse.tracecompass.tmf.core.trace.TmfTrace;
 import org.eclipse.tracecompass.tmf.core.trace.TmfTraceManager;
 import org.eclipse.tracecompass.tmf.core.trace.TmfTraceUtils;
 
@@ -131,7 +130,7 @@ protected void deleteTrace() {
         }
 
         deleteSuppFiles(trace);
-        ((TmfTrace) trace).traceOpened(new TmfTraceOpenedSignal(this, trace, null));
+        trace.traceOpened(new TmfTraceOpenedSignal(this, trace, null));
         fTrace = trace;
 
         /* Start the kernel analysis module */
diff --git a/analysis/org.eclipse.tracecompass.analysis.profiling.core/src/org/eclipse/tracecompass/internal/analysis/profiling/core/instrumented/FlameChartDataProviderFactory.java b/analysis/org.eclipse.tracecompass.analysis.profiling.core/src/org/eclipse/tracecompass/internal/analysis/profiling/core/instrumented/FlameChartDataProviderFactory.java
@@ -73,7 +73,7 @@ public class FlameChartDataProviderFactory implements IDataProviderFactory {
         // The trace can be an experiment, so we need to know if there are
         // multiple analysis modules with the same ID
         Iterable<IFlameChartProvider> modules = TmfTraceUtils.getAnalysisModulesOfClass(trace, IFlameChartProvider.class);
-        Iterable<IFlameChartProvider> filteredModules = Iterables.filter(modules, m -> ((IAnalysisModule) m).getId().equals(secondaryId));
+        Iterable<IFlameChartProvider> filteredModules = Iterables.filter(modules, m -> m.getId().equals(secondaryId));
         Iterator<IFlameChartProvider> iterator = filteredModules.iterator();
         if (iterator.hasNext()) {
             IFlameChartProvider module = iterator.next();
@@ -82,7 +82,7 @@ public class FlameChartDataProviderFactory implements IDataProviderFactory {
                 // the factory can try with individual traces
                 return null;
             }
-            ((IAnalysisModule) module).schedule();
+            module.schedule();
             return new FlameChartDataProvider(trace, module, secondaryId);
         }
         return null;
diff --git a/releng/org.eclipse.tracecompass.integration.swtbot.tests/src/org/eclipse/tracecompass/integration/swtbot/tests/markers/MarkerSetSwtBotTest.java b/releng/org.eclipse.tracecompass.integration.swtbot.tests/src/org/eclipse/tracecompass/integration/swtbot/tests/markers/MarkerSetSwtBotTest.java
@@ -30,7 +30,6 @@
 import org.eclipse.tracecompass.tmf.core.signal.TmfWindowRangeUpdatedSignal;
 import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimeRange;
 import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimestamp;
-import org.eclipse.tracecompass.tmf.ctf.core.trace.CtfTmfTrace;
 import org.eclipse.tracecompass.tmf.ui.swtbot.tests.shared.ConditionHelpers;
 import org.eclipse.tracecompass.tmf.ui.swtbot.tests.shared.SWTBotUtils;
 import org.eclipse.tracecompass.tmf.ui.tests.shared.WaitUtils;
@@ -92,7 +91,7 @@ public static void setUp() {
 
         final CtfTestTrace cygProfile = CtfTestTrace.CYG_PROFILE;
         LttngUstTrace trace = LttngUstTestTraceUtils.getTrace(cygProfile);
-        fStart = ((CtfTmfTrace) trace).getStartTime().toNanos();
+        fStart = trace.getStartTime().toNanos();
         fFullRange = new TmfTimeRange(TmfTimestamp.fromNanos(fStart), TmfTimestamp.fromNanos(fStart + 100l));
         final File file = new File(trace.getPath());
         LttngUstTestTraceUtils.dispose(cygProfile);
diff --git a/tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/ui/views/xychart/XmlXYView.java b/tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/ui/views/xychart/XmlXYView.java
@@ -68,7 +68,7 @@ public XmlXYView() {
 
                     TmfXYChartViewer chart = getChartViewer();
                     if (chart instanceof XmlXYViewer) {
-                        ((XmlXYViewer) chart).reset();
+                        chart.reset();
                     }
 
                     loadTrace();
diff --git a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/statesystem/backends/partial/PartialHistoryBackend.java b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/statesystem/backends/partial/PartialHistoryBackend.java
@@ -36,7 +36,6 @@
 import org.eclipse.tracecompass.internal.provisional.datastore.core.condition.IntegerRangeCondition;
 import org.eclipse.tracecompass.internal.provisional.datastore.core.condition.TimeRangeCondition;
 import org.eclipse.tracecompass.internal.tmf.core.Activator;
-import org.eclipse.tracecompass.statesystem.core.ITmfStateSystem;
 import org.eclipse.tracecompass.statesystem.core.backend.IPartialStateHistoryBackend;
 import org.eclipse.tracecompass.statesystem.core.backend.IStateHistoryBackend;
 import org.eclipse.tracecompass.statesystem.core.exceptions.StateSystemDisposedException;
@@ -303,7 +302,7 @@ public void doQuery(List<@Nullable ITmfStateInterval> currentStateInfo, long t)
          * Now, we have the intervals with their real end times written to the
          * backend, we should be able to get them from there
          */
-        List<ITmfStateInterval> intervalsList = ((ITmfStateSystem) fPartialSS).queryFullState(t);
+        List<ITmfStateInterval> intervalsList = fPartialSS.queryFullState(t);
 
         for (int i = 0; i < currentStateInfo.size(); i++) {
             ITmfStateInterval interval = currentStateInfo.get(i);
@@ -320,7 +319,7 @@ public void doQuery(List<@Nullable ITmfStateInterval> currentStateInfo, long t)
          * upper checkpoint exists
          */
         if (fCheckpoints.ceilingKey(t) != null) {
-            intervalsList = prepareIntervalList(((ITmfStateSystem) fPartialSS).getNbAttributes());
+            intervalsList = prepareIntervalList(fPartialSS.getNbAttributes());
             filledStateInfo.clear();
             try {
                 fInnerHistory.doQuery(intervalsList, checkpointTime2);
@@ -366,7 +365,7 @@ public ITmfStateInterval doSingularQuery(long t, int attributeQuark) throws Time
 
         /* Reload the previous checkpoint */
         long checkpointTime = fCheckpoints.floorKey(t);
-        int nbAtributes = ((ITmfStateSystem)fPartialSS).getNbAttributes();
+        int nbAtributes = fPartialSS.getNbAttributes();
         List<ITmfStateInterval> intervalsList = prepareIntervalList(nbAtributes);
 
         /* Checking if the interval was stored in the real backend */
@@ -416,7 +415,7 @@ public ITmfStateInterval doSingularQuery(long t, int attributeQuark) throws Time
         }
 
         /* Querying the partial history at the lowerCheckpoint */
-        List<@Nullable ITmfStateInterval> currentStateInfo = prepareIntervalList(((ITmfStateSystem)fPartialSS).getNbAttributes());
+        List<@Nullable ITmfStateInterval> currentStateInfo = prepareIntervalList(fPartialSS.getNbAttributes());
         try {
             fInnerHistory.doQuery(currentStateInfo, lowerCheckpoint);
         } catch (StateSystemDisposedException e) {
@@ -469,7 +468,7 @@ public ITmfStateInterval doSingularQuery(long t, int attributeQuark) throws Time
             Logger logger = Logger.getAnonymousLogger();
             try {
                 synchronized (fPartialSS) {
-                    for (ITmfStateInterval interval : ((ITmfStateSystem) fPartialSS).query2D(quarksColletion, min, max)) {
+                    for (ITmfStateInterval interval : fPartialSS.query2D(quarksColletion, min, max)) {
                         fCurrentIntervals.add(interval);
                     }
                 }
diff --git a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/trace/experiment/TmfExperiment.java b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/trace/experiment/TmfExperiment.java
@@ -481,7 +481,7 @@ public synchronized ITmfContext seekEvent(final ITmfLocation location) {
             traceContext.setRank(ranks[i]);
             // update location after seek
             locations[i] = traceContext.getLocation();
-            context.setContent(i, traceContext, ((ITmfTrace) getChild(i)).getNext(traceContext));
+            context.setContent(i, traceContext, getChild(i).getNext(traceContext));
             rank += ranks[i];
         }
 
@@ -627,7 +627,7 @@ public synchronized ITmfEvent getNext(ITmfContext context) {
                         trace, traceContext.getLocation(), traceContext.getRank());
                 experimentContext.setLocation(new TmfExperimentLocation(locationArray));
                 // queue the next event
-                ITmfEvent nextEvent = ((ITmfTrace) getChild(trace)).getNext(traceContext);
+                ITmfEvent nextEvent = getChild(trace).getNext(traceContext);
                 experimentContext.setContent(trace, traceContext, nextEvent);
             }
         }
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/tracepkg/importexport/ImportTracePackageWizardPage.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/tracepkg/importexport/ImportTracePackageWizardPage.java
@@ -481,15 +481,15 @@ private boolean handleTracesConflict(List<TracePackageTraceElement> traceElement
     private static void uncheckTraceElement(TracePackageTraceElement traceElement) {
         for (TracePackageElement e : traceElement.getChildren()) {
             if (e instanceof TracePackageFilesElement) {
-                ((TracePackageFilesElement) e).setChecked(false);
+                e.setChecked(false);
             }
         }
     }
 
     private static void uncheckExperimentElement(TracePackageExperimentElement experimentElement, List<TracePackageTraceElement> expTraceElements) {
         for (TracePackageElement e : experimentElement.getChildren()) {
             if (e instanceof TracePackageFilesElement) {
-                ((TracePackageFilesElement) e).setChecked(false);
+                e.setChecked(false);
             }
         }
 
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TmfAnalysisElement.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TmfAnalysisElement.java
@@ -118,7 +118,7 @@ protected synchronized void refreshChildren() {
         IPath path = tracesFolder.getPath();
         IResource resource = getResource();
         if (resource instanceof IFolder) {
-            path = ((IFolder) resource).getFullPath();
+            path = resource.getFullPath();
         }
 
         IAnalysisModule module = getAnalysisModule();
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsCache.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsCache.java
@@ -25,7 +25,6 @@
 import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.tracecompass.internal.tmf.core.filter.TmfCollapseFilter;
 import org.eclipse.tracecompass.internal.tmf.ui.Activator;
-import org.eclipse.tracecompass.tmf.core.component.ITmfEventProvider;
 import org.eclipse.tracecompass.tmf.core.event.ITmfEvent;
 import org.eclipse.tracecompass.tmf.core.event.ITmfEventField;
 import org.eclipse.tracecompass.tmf.core.event.ITmfEventType;
@@ -354,7 +353,7 @@ public int getFilteredIndex() {
         }
 
         request = new DataRequest(ITmfEvent.class, filter, startRank, ITmfEventRequest.ALL_DATA);
-        ((ITmfEventProvider) fTrace).sendRequest(request);
+        fTrace.sendRequest(request);
         try {
             request.waitForCompletion();
             return ((DataRequest) request).getFilteredIndex();
@@ -461,7 +460,7 @@ public void handleData(ITmfEvent event) {
                     }
                 };
 
-                ((ITmfEventProvider) fTrace).sendRequest(request);
+                fTrace.sendRequest(request);
                 try {
                     request.waitForCompletion();
                 } catch (InterruptedException e) {
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/xychart/XYChartLegendImageProvider.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/xychart/XYChartLegendImageProvider.java
@@ -90,7 +90,7 @@ private void drawStyleLine(GC gc, Color lineColor, int imageWidth, int imageHeig
         LineStyle lineStyle = LineStyle.valueOf((String) presProvider.getStyleOrDefault(appearance, StyleProperties.SERIES_STYLE, StyleProperties.SeriesStyle.SOLID));
         if (lineStyle != LineStyle.NONE) {
             gc.setForeground(lineColor);
-            gc.setLineWidth(((Number) presProvider.getFloatStyleOrDefault(appearance, StyleProperties.WIDTH, 1.0f)).intValue());
+            gc.setLineWidth(presProvider.getFloatStyleOrDefault(appearance, StyleProperties.WIDTH, 1.0f).intValue());
             gc.setLineStyle(lineStyle.ordinal());
             gc.drawLine(0, imageHeight / 2, imageWidth, imageHeight / 2);
             gc.setForeground(prev);
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/xychart/linechart/TmfCommonXAxisChartViewer.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/xychart/linechart/TmfCommonXAxisChartViewer.java
@@ -637,7 +637,7 @@ private double[] extractXValuesToDisplay(long[] xValuesRequested) {
             lineSeries.setLineColor(color);
             lineSeries.setSymbolColor(color);
             lineSeries.setVisible(true);
-            lineSeries.setLineWidth(((Number) presProvider.getFloatStyleOrDefault(appearance, StyleProperties.WIDTH, 1.0f)).intValue());
+            lineSeries.setLineWidth(presProvider.getFloatStyleOrDefault(appearance, StyleProperties.WIDTH, 1.0f).intValue());
             return lineSeries;
         }
 
@@ -674,7 +674,7 @@ private double[] extractXValuesToDisplay(long[] xValuesRequested) {
             lineSeries.setLineColor(color);
             lineSeries.setSymbolColor(color);
             lineSeries.setVisible(true);
-            lineSeries.setLineWidth(((Number) presProvider.getFloatStyleOrDefault(appearance, StyleProperties.WIDTH, 1.0f)).intValue());
+            lineSeries.setLineWidth(presProvider.getFloatStyleOrDefault(appearance, StyleProperties.WIDTH, 1.0f).intValue());
             return lineSeries;
         }
 
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/timegraph/TimeGraphFindDialog.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/timegraph/TimeGraphFindDialog.java
@@ -945,7 +945,7 @@ private SearchOptions getSearchOptions(boolean forwardSearch) {
      */
     private static void setGridData(Control component, int horizontalAlignment, boolean grabExcessHorizontalSpace, int verticalAlignment, boolean grabExcessVerticalSpace) {
         GridData gd;
-        if (component instanceof Button && (((Button) component).getStyle() & SWT.PUSH) != 0) {
+        if (component instanceof Button && (component.getStyle() & SWT.PUSH) != 0) {
             gd = (GridData) component.getLayoutData();
             gd.horizontalAlignment = GridData.FILL;
             gd.widthHint = 100;
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/SDWidget.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/SDWidget.java
@@ -1936,7 +1936,7 @@ public void widgetDisposed(DisposeEvent e) {
         if (fSite instanceof SDView) {
             ((SDView) fSite).resetProviders();
             if (lm != null) {
-                lm.resetLoader(((SDView) fSite).getViewSite().getId());
+                lm.resetLoader(fSite.getViewSite().getId());
             }
         }
     }
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/ScrollView.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/ScrollView.java
@@ -751,7 +751,7 @@ public void setOverviewSize(int size) {
      */
     public boolean isOverviewEnabled() {
         if (fCornerControl instanceof Button) {
-            Object data = ((Button) fCornerControl).getData();
+            Object data = fCornerControl.getData();
             // overview alreay
             if (data instanceof Overview) {
                 return true;
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/core/Frame.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/core/Frame.java
@@ -769,7 +769,7 @@ protected GraphNode getCloserLeavingMessage(Lifeline lifeline, BaseMessage messa
             int event = getMaxEventOccurrence();
             if (message != null) {
                 if (message instanceof AsyncMessage) {
-                    event = ((AsyncMessage) message).getStartOccurrence();
+                    event = message.getStartOccurrence();
                 } else {
                     event = message.getEventOccurrence();
                 }
@@ -829,7 +829,7 @@ protected GraphNode getCloserEnteringMessage(Lifeline lifeline, BaseMessage mess
             int event = getMaxEventOccurrence();
             if (message != null) {
                 if (message instanceof AsyncMessage) {
-                    event = ((AsyncMessage) message).getStartOccurrence();
+                    event = message.getStartOccurrence();
                 } else {
                     event = message.getEventOccurrence();
                 }
@@ -864,8 +864,8 @@ protected int distanceFromEvent(GraphNode node, int event) {
         if (node instanceof SyncMessage) {
             distance = ((SyncMessage) node).getEventOccurrence() - event;
         } else if (node instanceof AsyncMessage) {
-            int start = ((AsyncMessage) node).getStartOccurrence();
-            int end = ((AsyncMessage) node).getEndOccurrence();
+            int start = node.getStartOccurrence();
+            int end = node.getEndOccurrence();
             if ((start - event) < (end - event)) {
                 distance = start - event;
             } else {
@@ -993,7 +993,7 @@ public GraphNode getPrevLifelineMessage(Lifeline lifeline, BaseMessage startMess
         int event = getMaxEventOccurrence();
         if (startMessage != null) {
             if (startMessage instanceof AsyncMessage) {
-                event = ((AsyncMessage) startMessage).getStartOccurrence();
+                event = startMessage.getStartOccurrence();
             } else {
                 event = startMessage.getEventOccurrence();
             }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public XmlXYView() {`
`68`	`68`
`69`	`69`	`TmfXYChartViewer chart = getChartViewer();`
`70`	`70`	`if (chart instanceof XmlXYViewer) {`
`71`		`- ((XmlXYViewer) chart).reset();`
	`71`	`+ chart.reset();`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`loadTrace();`
Original file line number	Diff line number	Diff line change
`@@ -481,7 +481,7 @@ public synchronized ITmfContext seekEvent(final ITmfLocation location) {`
`481`	`481`	`traceContext.setRank(ranks[i]);`
`482`	`482`	`// update location after seek`
`483`	`483`	`locations[i] = traceContext.getLocation();`
`484`		`- context.setContent(i, traceContext, ((ITmfTrace) getChild(i)).getNext(traceContext));`
	`484`	`+ context.setContent(i, traceContext, getChild(i).getNext(traceContext));`
`485`	`485`	`rank += ranks[i];`
`486`	`486`	`}`
`487`	`487`
`@@ -627,7 +627,7 @@ public synchronized ITmfEvent getNext(ITmfContext context) {`
`627`	`627`	`trace, traceContext.getLocation(), traceContext.getRank());`
`628`	`628`	`experimentContext.setLocation(new TmfExperimentLocation(locationArray));`
`629`	`629`	`// queue the next event`
`630`		`- ITmfEvent nextEvent = ((ITmfTrace) getChild(trace)).getNext(traceContext);`
	`630`	`+ ITmfEvent nextEvent = getChild(trace).getNext(traceContext);`
`631`	`631`	`experimentContext.setContent(trace, traceContext, nextEvent);`
`632`	`632`	`}`
`633`	`633`	`}`
Original file line number	Diff line number	Diff line change
`@@ -481,15 +481,15 @@ private boolean handleTracesConflict(List<TracePackageTraceElement> traceElement`
`481`	`481`	`private static void uncheckTraceElement(TracePackageTraceElement traceElement) {`
`482`	`482`	`for (TracePackageElement e : traceElement.getChildren()) {`
`483`	`483`	`if (e instanceof TracePackageFilesElement) {`
`484`		`- ((TracePackageFilesElement) e).setChecked(false);`
	`484`	`+ e.setChecked(false);`
`485`	`485`	`}`
`486`	`486`	`}`
`487`	`487`	`}`
`488`	`488`
`489`	`489`	`private static void uncheckExperimentElement(TracePackageExperimentElement experimentElement, List<TracePackageTraceElement> expTraceElements) {`
`490`	`490`	`for (TracePackageElement e : experimentElement.getChildren()) {`
`491`	`491`	`if (e instanceof TracePackageFilesElement) {`
`492`		`- ((TracePackageFilesElement) e).setChecked(false);`
	`492`	`+ e.setChecked(false);`
`493`	`493`	`}`
`494`	`494`	`}`
`495`	`495`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ protected synchronized void refreshChildren() {`
`118`	`118`	`IPath path = tracesFolder.getPath();`
`119`	`119`	`IResource resource = getResource();`
`120`	`120`	`if (resource instanceof IFolder) {`
`121`		`- path = ((IFolder) resource).getFullPath();`
	`121`	`+ path = resource.getFullPath();`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`IAnalysisModule module = getAnalysisModule();`