fix: replace logs with appropriate handler #1072
Conversation
manojava-gk
left a comment
manojava-gk
left a comment
There was a problem hiding this comment.
notes related change. rest looks good to me
CHANGELOG.md
Outdated
| - fixed technical user selection | ||
|
|
||
| ## 2.2.0-RC2 | ||
| ## Unreleased 2.2.0-RC3 |
There was a problem hiding this comment.
this is not related to RC3 changes. Kindly put this change note at the top with title - unreleased
|
evegufy
changed the base branch from
release/v2.3.0-RC2
to
release/v2.3.0-RC3
|
@charmi-v kindly resolve the conflicts |
charmi-v
force-pushed
the
fix/701-replace-logs
branch
from
db22d95 to
d9e1508
Compare
|
|
@manojava-gk conflicts are resolved now |
evegufy
changed the base branch from
release/v2.3.0-RC3
to
release/v2.3.0-RC4
|
@charmi-v do we still need this PR? we have conflicts in it. Also please add the label and milestone. |
|
@saadanzari I need to resolve the merge conflict with the base branch to ensure the changes are up to date. I'll update the PR shortly. |
|
@charmi-v pls resolve conflicts |
|
@saadanzari conflicts are resolved now |
|
@charmi-v I can still see the conflicts. |
6 participants
Description
Added Notify.error for operations without error handling
Added LogService.info for logging responses
Added LogService.error for logging API failures.
Why
The changes were required to improve the error handling and logging within our operations & for operations without error handling, we can ensure that any unexpected issues are properly communicated to the user.
Issue
#701
Checklist