feat: introduced field of customer contact in service #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usmanfee
changed the title
Usmanfee
force-pushed
the
new/user-contact-field-in-service
branch
from
89cb552 to
7152151
Compare
shubhamv-ss
reviewed
Oct 22, 2024
Usmanfee
force-pushed
the
new/user-contact-field-in-service
branch
from
bc55cee to
6afcde5
Compare
Usmanfee
force-pushed
the
new/user-contact-field-in-service
branch
from
6afcde5 to
f2d8b82
Compare
evegufy
changed the title
manojava-gk
reviewed
Nov 12, 2024
Contributor
manojava-gk
left a comment
manojava-gk
left a comment
There was a problem hiding this comment.
Check regex length condition once again
Usmanfee
force-pushed
the
new/user-contact-field-in-service
branch
from
6c7561b to
13fe166
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/components/pages/ServiceReleaseProcess/components/ServiceDetails.tsx
Fixed
Show fixed
Hide fixed
src/components/pages/ServiceReleaseProcess/components/ServiceDetails.tsx
Fixed
Show fixed
Hide fixed
src/components/pages/ServiceReleaseProcess/components/ServiceDetails.tsx
Fixed
Show fixed
Hide fixed
Usmanfee
force-pushed
the
new/user-contact-field-in-service
branch
from
71776a2 to
82811f9
Compare
|
Usmanfee
changed the title
Usmanfee
force-pushed
the
new/user-contact-field-in-service
branch
from
2b4b459 to
54b80a7
Compare
|
Member
|
@Usmanfee pls resolve conflicts |
Usmanfee
force-pushed
the
new/user-contact-field-in-service
branch
from
54b80a7 to
ed667ed
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced new input field for user contact in
Register New Serviceand also made changes to display it inServiceDetailandValid and Publishat last step ofRegister New Service.Changelog entry:
Why
Previously, we were displaying the empty field for the user phone number because we didn't have any mechanism to take contact from the user but now we are taking it and also displaying it.
Issue
#1215
Checklist