fix: table messages for no record #1284
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
|
Please also review dependent PR from shared-component: eclipse-tractusx/portal-shared-components#369. Thanks |
Member
|
@Usmanfee pls resolve conflicts |
Usmanfee
force-pushed
the
fix/table-messages-for-no-record
branch
from
064f63e to
1d308d8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Translation of messages for
PageLoadingcomponent for both EN and DE.Change made in this PR will be a breaking changes since the PageLoading component from the shared-component expect a new prop of
mappedTableSearchTranslationwhich is already done in another PR of shared-component repo:eclipse-tractusx/portal-shared-components#369
Changelog entry:
Why
PageLoadingcomponent displaying the hardcoded message for no data for to shown in Table component and for no data based on search text.Issue
#1286
Checklist