feat: Creating a GitHub actions workflow which spins up the Umbrella #1484
Conversation
…al-frontend into umbrella-Sandbox
|
|
@charmi-v The umbrella Sandbox and Cypress Dependencies are installed in the GH Action. As the next step in a Different PR I will add the implemented tests to launch automatically. |
|
Thanks for the update @mgarciaLKS 🙌 Let me know if you've created a subtask to mention the improvement in the main issue thread 1228. I recommend creating a new subtask referencing the main thread to keep all contributors informed about the development. |
evegufy
left a comment
evegufy
left a comment
There was a problem hiding this comment.
Thanks for providing the workflow! Looks very good in generally.
| username: ${{ secrets.DOCKER_HUB_USER }} | ||
| password: ${{ secrets.DOCKER_HUB_TOKEN }} | ||
| repository: ${{ env.IMAGE_NAMESPACE }}/${{ env.IMAGE_NAME }} | ||
| readme-filepath: '.conf/docker-notice-portal.md' |
There was a problem hiding this comment.
please undo changes to build.yml
| helm install \ | ||
| --set portal.enabled=true,centralidp.enabled=true,sharedidp.enabled=true umbrella tractusx-dev/umbrella \ | ||
| --set portal.frontend.image.repository=kind-registry:5000/portal-frontend --set portal.frontend.image.tag=testing \ | ||
| --namespace umbrella --create-namespace |
There was a problem hiding this comment.
Please add this, otherwise we try to start testing and the keycloak realms and/or the portal db migrations are not ready yet
| --namespace umbrella --create-namespace | |
| --namespace umbrella --create-namespace \ | |
| -- wait --wait-for-jobs |
| push: | ||
| branches: | ||
| - 'main' |
There was a problem hiding this comment.
we should restrict the triggering of the workflow to only when really needed (it runs about 6 minutes or longer and otherwise just waste resources)
| push: | |
| branches: | |
| - 'main' |
| branches: | ||
| - 'main' |
There was a problem hiding this comment.
we should restrict the triggering of the workflow to only when really needed (it runs about 6 minutes or longer and otherwise just waste resources)
| branches: | |
| - 'main' | |
| branches: | |
| - 'main' | |
| paths: | |
| - 'src/**' |
| name: Umbrella Sandbox Setup | ||
|
|
||
| on: | ||
| #for testing purpouses |
| name: Umbrella Sandbox Setup | ||
|
|
||
| on: | ||
| #for testing purpouses |
| name: Umbrella Sandbox Setup | ||
|
|
||
| on: | ||
| #for testing purpouses |
| # SPDX-License-Identifier: Apache-2.0 | ||
| ############################################################### | ||
|
|
||
| name: Umbrella Sandbox Setup |
There was a problem hiding this comment.
| name: Umbrella Sandbox Setup | |
| name: E2E Testing (Umbrella Sandbox) |
Please also rename file to e2e-tests.yml
| - name: Install Cypress Dependencies | ||
| run: | | ||
| npm install cypress --legacy-peer-deps |
There was a problem hiding this comment.
I think this is ready to execute the cypress tests yet, right? could you please have a look at the cypress docs to gh actions
As I mentioned in the last portal sync, I assume that all the addresses in umbrella for portal, centralidp and sharedidp will be needed to be overwritten to the k8s cluster internal services, example, because the ingress isn't enabled with the gh actions k8s cluster.
3 participants
Description
Creating a GitHub action workflow which spins up the Umbrella in a Kind Cluster with the necessary components.
Why
The umbrella sandbox will be necessary in order to be able to implement Cypress as the automated E2E testing.
Issue
#1342
Checklist
Please delete options that are not relevant.