ftr: romved old title translation approach

TRACEFOSS-891

Author: fbedarf

src/app/modules/core/layout/header/header.component.html

@@ -45,7 +45,7 @@
   </div>
 
   <div class="header--app-header">
-    <h3>{{ 'routing.' + activeMenu | i18n }}</h3>
+    <h3>{{ 'pageTitle.' + activeMenu | i18n }}</h3>
   </div>
 
   <img src="/assets/images/header-subtract.png" class="header--stylish-curve" alt="" />

src/app/modules/core/layout/header/header.component.ts

@@ -51,6 +51,6 @@ export class HeaderComponent {
   }
 
   public openDocumentation(): void {
-    window.open('https://eclipse-tractusx.github.io/traceability-foss-backend/docs/', '_blank');
+    window.open('https://eclipse-tractusx.github.io/traceability-foss-backend/docs/', '_blank', 'noopener');
   }
 }

src/app/modules/core/layout/sidenav/sidenav.component.html

@@ -29,7 +29,6 @@
   <mat-sidenav
     #sidenav
     [fixedInViewport]="true"
-    [fixedTopGap]="64"
     (openedChange)="sidenavAction($event)"
     mode="over"
     class="sidenav--content"

src/app/modules/page/dashboard/presentation/dashboard.component.html

@@ -65,7 +65,7 @@
           <div class="flex justify-between items-center">
             <h3 class="mb-4 flex items-center">
               <mat-icon>find_in_page</mat-icon>
-              {{ 'commonInvestigation.title' | i18n }}
+              {{ 'pageTitle.investigations' | i18n }}
             </h3>
             <app-button
               [color]="'primary'"

src/app/modules/page/dashboard/presentation/dashboard.component.spec.ts

@@ -76,12 +76,6 @@ describe('Dashboard', () => {
   });
 
   describe('investigations', () => {
-    it('should render investigation component', async () => {
-      await renderDashboard();
-
-      expect(await screen.findByText('commonInvestigation.title')).toBeInTheDocument();
-    });
-
     it('should render count for investigations', async () => {
       await renderDashboard();
 

src/app/modules/page/investigations/detail/investigation-detail.component.spec.ts

@@ -47,11 +47,6 @@ describe('InvestigationDetailComponent', () => {
     });
   };
 
-  it('should render', async () => {
-    await renderInvestigationDetail();
-    expect(await screen.getByText('commonInvestigation.title')).toBeInTheDocument();
-  });
-
   it('should render specific text and additional table for received investigation', async () => {
     await renderInvestigationDetail();
     await waitFor(() => expect(screen.getByText('pageInvestigation.subHeadline.affectedParts')).toBeInTheDocument());

src/app/modules/page/investigations/presentation/investigations.component.spec.ts

@@ -34,11 +34,6 @@ describe('InvestigationsComponent', () => {
     });
   };
 
-  it('should render', async () => {
-    await renderInvestigations();
-    expect(await waitFor(() => screen.getByText('commonInvestigation.title'))).toBeInTheDocument();
-  });
-
   it('should call detail page with correct ID', async () => {
     const { fixture } = await renderInvestigations();
     fireEvent.click((await waitFor(() => screen.getAllByTestId('table-menu-button')))[0]);

src/app/modules/page/other-parts/presentation/other-parts.component.spec.ts

@@ -51,12 +51,6 @@ describe('Other Parts', () => {
       roles,
     });
 
-  it('should render part header', async () => {
-    await renderOtherParts();
-
-    expect(screen.getByText('pageOtherParts.title')).toBeInTheDocument();
-  });
-
   it('should render part table', async () => {
     await renderOtherParts();
 

src/app/modules/page/parts/presentation/parts.component.spec.ts

@@ -39,12 +39,6 @@ describe('Parts', () => {
     });
   };
 
-  it('should render part header', async () => {
-    await renderParts();
-
-    expect(screen.getByText('pageParts.title')).toBeInTheDocument();
-  });
-
   it('should render part table', async () => {
     await renderParts();
 

src/assets/locales/de/common.json

@@ -10,6 +10,15 @@
     "admin": "Verwaltung",
     "investigations": "Quality Investigation"
   },
+  "pageTitle": {
+    "dashboard": "Dashboard",
+    "parts": "Meine Produkte",
+    "otherParts": "Andere Produkte",
+    "about": "Über Catena-X Open-Source Rückverfolgbarkeit",
+    "relations": "Beziehungen",
+    "admin": "Verwaltung Catena-X",
+    "investigations": "Qualitätsuntersuchung"
+  },
   "layout": {
     "nav": {
       "openUserMenu": "Benutzermenü öffnen",
@@ -115,7 +124,6 @@
     "range": "{{startIndex}} – {{endIndex}} von {{length}}"
   },
   "commonInvestigation": {
-    "title": "Qualitätsuntersuchung",
     "viewAll": "Alle anzeigen",
     "tabs": {
       "received": "Zugewiesene",
@@ -148,14 +156,12 @@
       "declineTitle": "Ablehnung der Untersuchung",
       "declineDescription": "Sind Sie sicher, dass Sie diese Untersuchung ablehnen wollen?",
       "declineReasonHint": "Geben Sie den Grund für die Ablehnung dieser Untersuchung ein.",
-
       "successfullyAccepted": "Untersuchung wurde erfolgreich angenommen.",
       "successfullyAcknowledged": "Untersuchung wurde erfolgreich bestätigt",
       "successfullyApproved": "Untersuchung wurde erfolgreich genehmigt.",
       "successfullyCanceled": "Untersuchung wurde erfolgreich gelöscht.",
       "successfullyClosed": "Untersuchung wurde erfolgreich geschlossen.",
       "successfullyDeclined": "Untersuchung wurde erfolgreich abgelehnt.",
-
       "failedAccept": "Untersuchung konnte nicht akzeptiert werden, bitte versuchen Sie es erneut.",
       "failedAcknowledge": "Untersuchung konnte nicht bestätigt werden, bitte versuchen Sie es erneut.",
       "failedApprove": "Die Untersuchung konnte nicht genehmigt werden, bitte versuchen Sie es erneut.",