Merge branch 'main' of github.com:catenax-ng/tx-traceability-foss-frontend into feature/TRACEFOSS-893_UUX_FE_Rework_user_menu_to_align_with_CX_guidelines

Author: fbedarf

.github/workflows/test.yml

@@ -9,7 +9,6 @@ jobs:
   build:
 
     runs-on: ubuntu-latest
-    continue-on-error: true
 
     steps:
     - uses: actions/checkout@v3
@@ -25,9 +24,8 @@ jobs:
         cmd: install # will run `yarn install` command
     - name: Run npm test:ci
       run: CHROMIUM_BIN=$(which chrome) npm run test:ci # will run `test:ci` command
-      continue-on-error: true
     - name: Run SonarCloud with organzation and project key from environment
-      if: always() && ${{ vars.SONAR_ORGANIZATION != '' && vars.SONAR_PROJECT_KEY != '' }}
+      if: ${{ vars.SONAR_ORGANIZATION != '' && vars.SONAR_PROJECT_KEY != '' }}
       uses: SonarSource/sonarcloud-github-action@master
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any

DEPENDENCIES

@@ -8,8 +8,7 @@ npm/npmjs/-/acorn-node/1.8.2, Apache-2.0, approved, clearlydefined
 npm/npmjs/-/acorn-walk/7.2.0, MIT, approved, clearlydefined
 npm/npmjs/-/acorn-walk/8.2.0, MIT, approved, clearlydefined
 npm/npmjs/-/acorn/7.4.1, MIT, approved, clearlydefined
-npm/npmjs/-/acorn/8.7.1, MIT, approved, clearlydefined
-npm/npmjs/-/acorn/8.8.1, MIT, approved, #6951
+npm/npmjs/-/acorn/8.8.2, MIT, approved, #6951
 npm/npmjs/-/adjust-sourcemap-loader/4.0.0, MIT, approved, clearlydefined
 npm/npmjs/-/agent-base/6.0.2, MIT, approved, clearlydefined
 npm/npmjs/-/agentkeepalive/4.2.1, MIT, approved, clearlydefined
@@ -135,6 +134,7 @@ npm/npmjs/-/color/3.2.1, MIT, approved, clearlydefined
 npm/npmjs/-/colord/2.9.3, MIT, approved, clearlydefined
 npm/npmjs/-/colorette/2.0.19, MIT, approved, clearlydefined
 npm/npmjs/-/colors/1.0.3, MIT, approved, clearlydefined
+npm/npmjs/-/colors/1.4.0, MIT, approved, clearlydefined
 npm/npmjs/-/colorspace/1.1.4, MIT, approved, clearlydefined
 npm/npmjs/-/combined-stream/1.0.8, MIT, approved, clearlydefined
 npm/npmjs/-/commander/2.20.3, MIT, approved, clearlydefined
@@ -578,7 +578,6 @@ npm/npmjs/-/json-schema/0.4.0, AFL-2.1 OR BSD-3-Clause, approved, #2410
 npm/npmjs/-/json-stable-stringify-without-jsonify/1.0.1, MIT, approved, clearlydefined
 npm/npmjs/-/json-stringify-safe/5.0.1, ISC, approved, clearlydefined
 npm/npmjs/-/json5/1.0.2, MIT, approved, CQ22351
-npm/npmjs/-/json5/2.2.1, MIT, approved, #2126
 npm/npmjs/-/json5/2.2.3, MIT, approved, #2126
 npm/npmjs/-/jsonc-parser/3.2.0, MIT, approved, clearlydefined
 npm/npmjs/-/jsonfile/4.0.0, MIT, approved, clearlydefined
@@ -590,6 +589,7 @@ npm/npmjs/-/karma-coverage/2.2.0, MIT, approved, clearlydefined
 npm/npmjs/-/karma-jasmine/5.1.0, MIT, approved, clearlydefined
 npm/npmjs/-/karma-sonarqube-reporter/1.4.0, MIT, approved, clearlydefined
 npm/npmjs/-/karma-source-map-support/1.4.0, MIT, approved, clearlydefined
+npm/npmjs/-/karma-spec-reporter/0.0.36, MIT, approved, clearlydefined
 npm/npmjs/-/karma/6.4.1, MIT, approved, clearlydefined
 npm/npmjs/-/kdbush/3.0.0, ISC, approved, clearlydefined
 npm/npmjs/-/keycloak-angular/13.0.0, , restricted, clearlydefined
@@ -609,7 +609,7 @@ npm/npmjs/-/lint-staged/13.1.2, , restricted, clearlydefined
 npm/npmjs/-/listr2/3.14.0, MIT, approved, clearlydefined
 npm/npmjs/-/listr2/5.0.7, MIT, approved, clearlydefined
 npm/npmjs/-/loader-runner/4.3.0, MIT, approved, clearlydefined
-npm/npmjs/-/loader-utils/2.0.2, MIT, approved, #4986
+npm/npmjs/-/loader-utils/2.0.4, MIT, approved, #4986
 npm/npmjs/-/loader-utils/3.2.1, MIT, approved, clearlydefined
 npm/npmjs/-/locate-path/5.0.0, MIT, approved, clearlydefined
 npm/npmjs/-/locate-path/6.0.0, MIT, approved, clearlydefined
@@ -623,7 +623,6 @@ npm/npmjs/-/lodash.merge/4.6.2, MIT, approved, clearlydefined
 npm/npmjs/-/lodash.mergewith/4.6.2, MIT, approved, clearlydefined
 npm/npmjs/-/lodash.once/4.1.1, MIT, approved, clearlydefined
 npm/npmjs/-/lodash.snakecase/4.1.1, MIT, approved, clearlydefined
-npm/npmjs/-/lodash.sortby/4.7.0, MIT, approved, clearlydefined
 npm/npmjs/-/lodash.startcase/4.4.0, MIT, approved, clearlydefined
 npm/npmjs/-/lodash.truncate/4.4.2, MIT, approved, clearlydefined
 npm/npmjs/-/lodash.uniq/4.5.0, MIT, approved, clearlydefined
@@ -934,7 +933,6 @@ npm/npmjs/-/source-map-resolve/0.6.0, MIT, approved, clearlydefined
 npm/npmjs/-/source-map-support/0.5.21, MIT, approved, clearlydefined
 npm/npmjs/-/source-map/0.6.1, BSD-3-Clause, approved, #2417
 npm/npmjs/-/source-map/0.7.4, BSD-3-Clause, approved, #2416
-npm/npmjs/-/source-map/0.8.0-beta.0, BSD-3-Clause, approved, #2984
 npm/npmjs/-/spdx-correct/3.1.1, Apache-2.0, approved, #990
 npm/npmjs/-/spdx-exceptions/2.3.0, CC-BY-3.0, approved, clearlydefined
 npm/npmjs/-/spdx-expression-parse/3.0.1, MIT, approved, #1127
@@ -988,7 +986,6 @@ npm/npmjs/-/tailwindcss/3.2.7, , restricted, clearlydefined
 npm/npmjs/-/tapable/2.2.1, MIT, approved, clearlydefined
 npm/npmjs/-/tar/6.1.11, ISC, approved, #4566
 npm/npmjs/-/terser-webpack-plugin/5.3.1, MIT, approved, clearlydefined
-npm/npmjs/-/terser/5.13.1, BSD-2-Clause, approved, clearlydefined
 npm/npmjs/-/terser/5.16.1, BSD-2-Clause AND BSD-3-Clause AND BSD-2-Clause AND ISC, approved, #7045
 npm/npmjs/-/test-exclude/6.0.0, ISC, approved, clearlydefined
 npm/npmjs/-/text-extensions/1.9.0, MIT, approved, clearlydefined
@@ -1007,7 +1004,6 @@ npm/npmjs/-/toidentifier/1.0.1, MIT, approved, clearlydefined
 npm/npmjs/-/totalist/1.1.0, MIT, approved, clearlydefined
 npm/npmjs/-/tough-cookie/2.5.0, BSD-3-Clause, approved, clearlydefined
 npm/npmjs/-/tr46/0.0.3, MIT, approved, clearlydefined
-npm/npmjs/-/tr46/1.0.1, MIT, approved, clearlydefined
 npm/npmjs/-/tree-kill/1.2.2, MIT, approved, clearlydefined
 npm/npmjs/-/trim-newlines/3.0.1, MIT, approved, clearlydefined
 npm/npmjs/-/triple-beam/1.3.0, MIT, approved, clearlydefined
@@ -1068,7 +1064,6 @@ npm/npmjs/-/wbuf/1.7.3, MIT, approved, clearlydefined
 npm/npmjs/-/wcwidth/1.0.1, MIT, approved, #944
 npm/npmjs/-/web-encoding/1.1.5, MIT, approved, clearlydefined
 npm/npmjs/-/webidl-conversions/3.0.1, BSD-2-Clause, approved, clearlydefined
-npm/npmjs/-/webidl-conversions/4.0.2, BSD-2-Clause, approved, clearlydefined
 npm/npmjs/-/webpack-bundle-analyzer/4.8.0, , restricted, clearlydefined
 npm/npmjs/-/webpack-dev-middleware/5.3.3, MIT, approved, clearlydefined
 npm/npmjs/-/webpack-dev-middleware/6.0.1, MIT, approved, clearlydefined
@@ -1080,7 +1075,6 @@ npm/npmjs/-/webpack/5.75.0, MIT, approved, #5005
 npm/npmjs/-/websocket-driver/0.7.4, Apache-2.0, approved, clearlydefined
 npm/npmjs/-/websocket-extensions/0.1.4, Apache-2.0, approved, CQ23021
 npm/npmjs/-/whatwg-url/5.0.0, MIT, approved, clearlydefined
-npm/npmjs/-/whatwg-url/7.1.0, MIT, approved, clearlydefined
 npm/npmjs/-/which-boxed-primitive/1.0.2, MIT, approved, clearlydefined
 npm/npmjs/-/which-collection/1.0.1, MIT, approved, clearlydefined
 npm/npmjs/-/which-typed-array/1.1.9, MIT, approved, #4864
@@ -1097,7 +1091,7 @@ npm/npmjs/-/wrap-ansi/7.0.0, MIT, approved, clearlydefined
 npm/npmjs/-/wrappy/1.0.2, ISC, approved, clearlydefined
 npm/npmjs/-/write-file-atomic/5.0.0, ISC, approved, clearlydefined
 npm/npmjs/-/ws/7.5.7, MIT, approved, #1940
-npm/npmjs/-/ws/8.12.1, , restricted, clearlydefined
+npm/npmjs/-/ws/8.12.1, MIT, approved, clearlydefined
 npm/npmjs/-/ws/8.2.3, MIT, approved, clearlydefined
 npm/npmjs/-/xmlcreate/2.0.4, Apache-2.0, approved, clearlydefined
 npm/npmjs/-/xtend/4.0.2, MIT, approved, clearlydefined
@@ -1300,9 +1294,9 @@ npm/npmjs/@commitlint/to-lines/17.4.0, MIT, approved, clearlydefined
 npm/npmjs/@commitlint/top-level/17.4.0, MIT, approved, clearlydefined
 npm/npmjs/@commitlint/types/17.4.4, , restricted, clearlydefined
 npm/npmjs/@cspotcode/source-map-support/0.8.1, MIT, approved, clearlydefined
-npm/npmjs/@csstools/css-parser-algorithms/2.0.1, , restricted, clearlydefined
+npm/npmjs/@csstools/css-parser-algorithms/2.0.1, MIT, approved, clearlydefined
 npm/npmjs/@csstools/css-tokenizer/2.0.2, , restricted, clearlydefined
-npm/npmjs/@csstools/media-query-list-parser/2.0.1, , restricted, clearlydefined
+npm/npmjs/@csstools/media-query-list-parser/2.0.1, MIT, approved, clearlydefined
 npm/npmjs/@csstools/selector-specificity/2.1.1, CC0-1.0, approved, #7043
 npm/npmjs/@cucumber/cucumber-expressions/16.1.1, MIT, approved, clearlydefined
 npm/npmjs/@cucumber/gherkin/24.1.0, MIT, approved, clearlydefined
@@ -1396,11 +1390,12 @@ npm/npmjs/@istanbuljs/schema/0.1.3, MIT, approved, clearlydefined
 npm/npmjs/@jridgewell/gen-mapping/0.1.1, MIT, approved, clearlydefined
 npm/npmjs/@jridgewell/gen-mapping/0.3.2, MIT, approved, clearlydefined
 npm/npmjs/@jridgewell/resolve-uri/3.0.6, MIT, approved, clearlydefined
+npm/npmjs/@jridgewell/resolve-uri/3.1.0, MIT, approved, clearlydefined
 npm/npmjs/@jridgewell/set-array/1.1.0, MIT, approved, clearlydefined
 npm/npmjs/@jridgewell/set-array/1.1.2, MIT, approved, clearlydefined
 npm/npmjs/@jridgewell/source-map/0.3.2, MIT, approved, clearlydefined
-npm/npmjs/@jridgewell/sourcemap-codec/1.4.12, MIT, approved, clearlydefined
 npm/npmjs/@jridgewell/sourcemap-codec/1.4.14, MIT, approved, clearlydefined
+npm/npmjs/@jridgewell/trace-mapping/0.3.17, MIT, approved, clearlydefined
 npm/npmjs/@jridgewell/trace-mapping/0.3.9, MIT, approved, clearlydefined
 npm/npmjs/@leichtgewicht/ip-codec/2.0.4, MIT, approved, clearlydefined
 npm/npmjs/@loaders.gl/core/3.2.12, MIT, approved, clearlydefined
@@ -1475,7 +1470,7 @@ npm/npmjs/@material/textfield/15.0.0-canary.684e33d25.0, MIT, approved, clearlyd
 npm/npmjs/@material/theme/15.0.0-canary.684e33d25.0, MIT, approved, clearlydefined
 npm/npmjs/@material/tokens/15.0.0-canary.684e33d25.0, MIT, approved, clearlydefined
 npm/npmjs/@material/tooltip/15.0.0-canary.684e33d25.0, , restricted, clearlydefined
-npm/npmjs/@material/top-app-bar/15.0.0-canary.684e33d25.0, , restricted, clearlydefined
+npm/npmjs/@material/top-app-bar/15.0.0-canary.684e33d25.0, MIT, approved, clearlydefined
 npm/npmjs/@material/touch-target/15.0.0-canary.684e33d25.0, MIT, approved, clearlydefined
 npm/npmjs/@material/typography/15.0.0-canary.684e33d25.0, MIT, approved, clearlydefined
 npm/npmjs/@math.gl/core/3.6.3, MIT, approved, clearlydefined
@@ -1582,7 +1577,7 @@ npm/npmjs/@types/mkdirp/1.0.2, MIT, approved, clearlydefined
 npm/npmjs/@types/ms/0.7.31, MIT, approved, clearlydefined
 npm/npmjs/@types/node/14.18.34, MIT, approved, #4611
 npm/npmjs/@types/node/18.11.9, MIT, approved, #5746
-npm/npmjs/@types/node/18.14.0, , restricted, clearlydefined
+npm/npmjs/@types/node/18.14.0, MIT, approved, clearlydefined
 npm/npmjs/@types/normalize-package-data/2.4.1, MIT, approved, clearlydefined
 npm/npmjs/@types/offscreencanvas/2019.7.0, MIT, approved, clearlydefined
 npm/npmjs/@types/parse-json/4.0.0, MIT, approved, clearlydefined

cypress.config.ts

@@ -27,7 +27,7 @@ export default defineConfig({
     specPattern: '**/*.feature',
     supportFile: false,
     viewportWidth: 1366,
-    viewportHeight: 768,
+    viewportHeight: 900,
     experimentalWebKitSupport: true, // https://docs.cypress.io/guides/guides/launching-browsers#WebKit-Experimental
     setupNodeEvents,
   },

karma.conf.js

@@ -30,6 +30,7 @@ module.exports = function (config) {
       require('karma-coverage'),
       require('karma-sonarqube-reporter'),
       require('@angular-devkit/build-angular/plugins/karma'),
+      'karma-spec-reporter',
     ],
     client: {
       jasmine: {
@@ -52,7 +53,7 @@ module.exports = function (config) {
         { type: 'lcov', subdir: 'lcov-report' },
       ],
     },
-    reporters: ['sonarqube'],
+    reporters: ['spec', 'sonarqube'],
     sonarqubeReporter: {
       basePath: 'src', // test files folder
       filePattern: '**/*spec.ts', // test files glob pattern

package.json

@@ -108,6 +108,7 @@
     "karma-coverage": "2.2.0",
     "karma-jasmine": "5.1.0",
     "karma-sonarqube-reporter": "1.4.0",
+    "karma-spec-reporter": "^0.0.36",
     "lint-staged": "13.1.2",
     "msw": "1.0.1",
     "playwright-webkit": "^1.30.0",

src/app/mocks/services/parts-mock/parts.handler.ts

@@ -42,9 +42,11 @@ export const partsHandlers = [
     return res(ctx.status(200), ctx.json(applyPagination(mockBmwAssets, pagination)));
   }),
 
-  rest.post(`*${environment.apiUrl}/assets/detail-information`, (req, res, ctx) => {
-    const { assetIds } = typeof req.body === 'string' ? JSON.parse(req.body) : req.body;
-    return res(ctx.status(200), ctx.json(assetIds.map(id => getAssetById(id))));
+  rest.post(`*${environment.apiUrl}/assets/detail-information`, async (req, res, ctx) => {
+    const { assetIds } = await req.json();
+
+    const response = assetIds.map(id => getAssetById(id));
+    return res(ctx.status(200), ctx.json(response.filter(data => !!data)));
   }),
 
   rest.get(`*${environment.apiUrl}/assets/:partId`, (req, res, ctx) => {
@@ -56,7 +58,7 @@ export const partsHandlers = [
   rest.patch(`*${environment.apiUrl}/assets/:partId`, (req, res, ctx) => {
     const { partId } = req.params;
     const currentPart = getAssetById(partId as string);
-    return res(ctx.status(200), ctx.json({ ...currentPart, ...(req.body as Record<string, any>) }));
+    return res(ctx.status(200), ctx.json({ ...currentPart, ...req.json() }));
   }),
 
   rest.get(`*${environment.apiUrl}/assets/:assetId/children/:childId`, (req, res, ctx) => {
@@ -81,7 +83,9 @@ export const partsHandlersTest = [
 
   rest.post(`*${environment.apiUrl}/assets/detail-information`, async (req, res, ctx) => {
     const { assetIds } = await req.json();
-    return res(ctx.status(200), ctx.json(assetIds.map(id => mockAssetList[id] || getAssetById(id))));
+
+    const response = assetIds.map(id => mockAssetList[id] || getAssetById(id));
+    return res(ctx.status(200), ctx.json(response.filter(data => !!data)));
   }),
 
   rest.get(`*${environment.apiUrl}/assets/:partId`, (req, res, ctx) => {
@@ -93,7 +97,7 @@ export const partsHandlersTest = [
   rest.patch(`*${environment.apiUrl}/assets/:partId`, (req, res, ctx) => {
     const { partId } = req.params;
     const currentPart = mockAssetList[partId as string];
-    return res(ctx.status(200), ctx.json({ ...currentPart, ...(req.body as Record<string, any>) }));
+    return res(ctx.status(200), ctx.json({ ...currentPart, ...req.json() }));
   }),
 
   rest.get(`*${environment.apiUrl}/assets/:assetId/children/:childId`, (req, res, ctx) => {

src/app/modules/core/kown-route.ts src/app/modules/core/known-route.tssrc/app/modules/core/kown-route.ts renamed to src/app/modules/core/known-route.ts

@@ -21,7 +21,7 @@
 
 import { Component } from '@angular/core';
 import { NavigationEnd, Router } from '@angular/router';
-import { KnownUrl, NavigableUrls } from '@core/kown-route';
+import { KnownUrl, NavigableUrls } from '@core/known-route';
 import { filter } from 'rxjs/operators';
 
 @Component({

src/app/modules/core/layout/header/header.component.ts

@@ -20,11 +20,11 @@
  ********************************************************************************/
 
 import { Component, HostListener } from '@angular/core';
-import { NavigableUrls } from '@core/kown-route';
 import { LayoutFacade } from '@shared/abstraction/layout-facade';
 import { NavigationEnd, Router } from '@angular/router';
 import { environment } from '@env';
 import { filter } from 'rxjs/operators';
+import { NavigableUrls } from '@core/known-route';
 
 @Component({
   selector: 'app-user-navigation',

src/app/modules/core/layout/header/user-navigation/user-menu.component.ts

@@ -29,7 +29,7 @@ import {
   NO_PERMISSION_BASE_ROUTE,
   OTHER_PARTS_BASE_ROUTE,
   PARTS_BASE_ROUTE,
-} from '@core/kown-route';
+} from '@core/known-route';
 import { RoleGuard } from '@core/user/role.guard';
 import { ErrorPageType } from '@page/error-page/model/error-page.model';