Skip to content

Conversation

sophokles73
Copy link
Contributor

No description provided.

@sophokles73 sophokles73 added the enhancement New feature or request label Aug 13, 2025
Changed triggers of CI job to run only on changes to the
Cargo.* files. This reduces the frequency of the 3rd party license
check to the required minimum, which should help with not running
into 429 errors when querying Clearly Defined.
@sophokles73
Copy link
Contributor Author

@ValMobBIllich it looks like ClearlyDefined simply is no longer usable, as it seems to always respond with a 429 these days. I propose to simply merge this PR even without the 3rd-party-deps check for now. Ironically, as part of this PR we are also removing the 3rd-party-check on every push to main to reduce the frequency with which we hit ClearlyDefined ;-)

Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable compromise to me 🤷

@sophokles73 sophokles73 requested review from ValMobBIllich and removed request for ValMobBIllich August 25, 2025 07:10
@ValMobBIllich
Copy link
Contributor

ValMobBIllich commented Aug 25, 2025

If its no longer functional then why not just get rid of the check completely? Still makes sense to me for now though

@sophokles73
Copy link
Contributor Author

If its no longer functional then why not just get rid of the check completely? Still makes sense to me for now though

Because it actually is required by the EF and now seems to be working again ;-)

@sophokles73 sophokles73 merged commit 8e456aa into eclipse-uprotocol:main Aug 25, 2025
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants