Skip to content

Commit 34a4400

Browse files
Apply suggestions from code review
Co-authored-by: BjoernAtBosch <Bjoern.Hornburg@de.bosch.com>
1 parent b65197f commit 34a4400

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ Update `velocitas-sdk` version number in the following files:
7575
* `examples/seat-adjuster/requirements-velocitas.txt`
7676

7777
Use the version number intended to be used for the release.
78-
As the version has not yet been released an error in Continuous Integration for the
78+
As the version has not yet been released, an error in Continuous Integration for the
7979
[Project creation](https://github.com/eclipse-velocitas/vehicle-app-python-sdk/actions/workflows/project-creation.yaml)
8080
workflow is expected.
8181

@@ -85,7 +85,7 @@ Running 'run'...
8585
ExecExitError: Program returned exit code: 1
8686
```
8787

88-
It is recommended to test locally that the not yet released SDK is compatible with the Seat Adjuster example and then merge the changes
88+
It is recommended to test locally if the not yet released SDK is compatible with the Seat Adjuster example and then merge the changes
8989
even if Continuos Integration fails.
9090

9191
2. Tag the commit and upload to GitHub
@@ -97,12 +97,12 @@ a new version of `velocitas-lib` published in [PyPI](https://pypi.org/project/ve
9797

9898
3. Re-run project creation tests
9999

100-
Now when the updated [PyPI](https://pypi.org/project/velocitas-sdk/) package exists the [Project creation](https://github.com/eclipse-velocitas/vehicle-app-python-sdk/actions/workflows/project-creation.yaml) workflow is expected to succeed if run manually for `main`.
100+
Now, when the updated [PyPI](https://pypi.org/project/velocitas-sdk/) package exists, the [Project creation](https://github.com/eclipse-velocitas/vehicle-app-python-sdk/actions/workflows/project-creation.yaml) workflow is expected to succeed if run manually for `main`.
101101
If not you need to troubleshoot why it doesn't.
102102

103103
### Updating Dependencies
104104

105-
This repository specify exact Python versions in `setup.py` and other files.
105+
This repository specifies exact Python versions in `setup.py` and other files.
106106
If a version needs to be updated, for example if a vulnerability is detected, the following approach needs to be followed
107107

108108
1. Update version in `setup.py` if needed

0 commit comments

Comments
 (0)