NumberFormatException thrown when creating DNS Client with IPv6 address (#5753)

See #5745

Separator for address:port is the last one when using IPv6 addresses

Signed-off-by: Thomas Segismont <[email protected]>

Author: tsegismont

vertx-core/src/main/java/io/vertx/core/dns/impl/DnsAddressResolverProvider.java

@@ -16,7 +16,9 @@
 import io.netty.resolver.*;
 import io.netty.resolver.dns.*;
 import io.netty.util.NetUtil;
-import io.vertx.core.*;
+import io.vertx.core.Future;
+import io.vertx.core.Promise;
+import io.vertx.core.VertxException;
 import io.vertx.core.buffer.Buffer;
 import io.vertx.core.dns.AddressResolverOptions;
 import io.vertx.core.internal.ContextInternal;
@@ -57,9 +59,9 @@ public static DnsAddressResolverProvider create(VertxInternal vertx, AddressReso
 
   private DnsAddressResolverProvider(VertxInternal vertx, AddressResolverOptions options) {
     List<String> dnsServers = options.getServers();
-    if (dnsServers != null && dnsServers.size() > 0) {
+    if (dnsServers != null && !dnsServers.isEmpty()) {
       for (String dnsServer : dnsServers) {
-        int sep = dnsServer.indexOf(':');
+        int sep = dnsServer.lastIndexOf(':');
         String ipAddress;
         int port;
         if (sep != -1) {

vertx-core/src/test/java/io/vertx/tests/dns/DNSTest.java

@@ -11,32 +11,30 @@
 
 package io.vertx.tests.dns;
 
-import static io.vertx.test.core.TestUtils.assertNullPointerException;
-
-import java.net.InetSocketAddress;
-import java.util.Collections;
-import java.util.SortedMap;
-import java.util.TreeMap;
-import java.util.concurrent.CountDownLatch;
-import java.util.function.Function;
-
 import io.netty.resolver.dns.DnsNameResolverTimeoutException;
+import io.vertx.core.Vertx;
+import io.vertx.core.VertxException;
+import io.vertx.core.VertxOptions;
 import io.vertx.core.dns.DnsClient;
 import io.vertx.core.dns.DnsClientOptions;
 import io.vertx.core.dns.MxRecord;
 import io.vertx.core.dns.SrvRecord;
 import io.vertx.test.core.TestUtils;
 import io.vertx.test.core.VertxTestBase;
+import io.vertx.test.fakedns.FakeDNSServer;
+import io.vertx.test.netty.TestLoggerFactory;
 import org.apache.directory.server.dns.messages.DnsMessage;
 import org.apache.directory.server.dns.store.RecordStore;
-import org.junit.Ignore;
 import org.junit.Test;
 
-import io.vertx.core.Vertx;
-import io.vertx.core.VertxException;
-import io.vertx.core.VertxOptions;
-import io.vertx.test.fakedns.FakeDNSServer;
-import io.vertx.test.netty.TestLoggerFactory;
+import java.net.InetSocketAddress;
+import java.util.Collections;
+import java.util.SortedMap;
+import java.util.TreeMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Function;
+
+import static io.vertx.test.core.TestUtils.assertNullPointerException;
 
 /**
  * @author <a href="mailto:[email protected]">Norman Maurer</a>
@@ -565,6 +563,12 @@ public void testClose() throws Exception {
     await();
   }
 
+  @Test
+  public void testIpv6NameServer() {
+    // We just want to verify that we can create a client with an IPv6 address as DNS server
+    vertx.createDnsClient(new DnsClientOptions().setPort(53).setHost("::1"));
+  }
+
   private DnsClient prepareDns() throws Exception {
     return prepareDns(new DnsClientOptions().setQueryTimeout(15000));
   }