Future#fromCompletionStage(CompletionStage) with Context if it exists

[magicprinc]

Current version:

static <T> Future<T> fromCompletionStage(CompletionStage<T> completionStage) {
  Promise<T> promise = Promise.promise();
  completionStage.whenComplete((value, err) -> {

isn't it better to supply Vert.x context if it "exists"

static <T> Future<T> fromCompletionStage(CompletionStage<T> completionStage) {
  Context ctx = Vertx.currentContext();
  Promise<T> promise = (ctx instanceof ContextInternal) // ⇒ ≠ null
    ? ((ContextInternal)ctx).promise() 
    : Promise.promise();
  completionStage.whenComplete((value, err) -> {

[tsegismont]

With @vietj we are considering having Promise.promise() use the current context, if any.

This would solve this issue as well.

[magicprinc]

@tsegismont Promise.promise() is a more generic solution! 👍
I hope nobody expects Promise.promise() doesn't have Context though 😅