Handshake timeout timer is not cancelled after a successful handshake

[AlexanderAA]

Should if (timer > 0L) { be changed to if (timer >= 0L) { in Http1xClientConnection.java?

When I set .setTimeout(timeout) in my websocket client, the very first call to vertx.setTimer(handshakeTimeout, id -> closeInternal()) returns 0.
Because of that, the timer is not cancelled after and closes connection - after a successful handshake.

I am able to avoid this by initializing the timer counter before websocket connection setup: vertx.cancelTimer(vertx.setTimer(1, ignored -> {}));.

Is there some other configuration that I might be missing, that helps to avoid this behaviour?

#4324 (comment)

[vietj]

thanks for reporting @AlexanderAA