Extract the socket/codec classes in its own module.

Motivation:

The vertx-sql-client component defines among all the base framework for Vert.x/Netty based implementations (e.g. PG client).

This module intents to define the SQL client API as well as the SPI, there are implementations that do not use the Vert.x/Netty such as JDBC client or Oracle client.

This extracts the Vert.x/Netty part into its own io.vertx.sql.client.codec module ensuring strong decoupling between with io.vertx.sql.client module.

This new module intents to remain quite internal and is not an API usable from Vert.x by most users.

Author: vietj

pom.xml

@@ -65,6 +65,13 @@
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+
+      <!-- TMP -->
+      <dependency>
+        <groupId>io.vertx</groupId>
+        <artifactId>vertx-sql-client-codec</artifactId>
+        <version>${project.version}</version>
+      </dependency>
     </dependencies>
   </dependencyManagement>
 
@@ -184,6 +191,7 @@
       </activation>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-pg-client</module>
         <module>vertx-mysql-client</module>
         <module>vertx-mssql-client</module>
@@ -199,6 +207,7 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-pg-client</module>
       </modules>
     </profile>
@@ -209,6 +218,7 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-pg-client</module>
       </modules>
     </profile>
@@ -219,6 +229,7 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-pg-client</module>
       </modules>
     </profile>
@@ -230,6 +241,7 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-mysql-client</module>
       </modules>
     </profile>
@@ -241,6 +253,7 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-mysql-client</module>
       </modules>
     </profile>
@@ -252,6 +265,7 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-mysql-client</module>
       </modules>
     </profile>
@@ -263,6 +277,7 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-mysql-client</module>
       </modules>
     </profile>
@@ -273,6 +288,7 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-mssql-client</module>
       </modules>
     </profile>
@@ -283,20 +299,23 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-mssql-client</module>
       </modules>
     </profile>
     <profile>
       <id>DB2-11.5</id>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-db2-client</module>
       </modules>
     </profile>
     <profile>
       <id>SQL-templates</id>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-pg-client</module>
         <module>vertx-mysql-client</module>
         <module>vertx-sql-client-templates</module>
@@ -309,9 +328,10 @@
       </properties>
       <modules>
         <module>vertx-sql-client</module>
+        <module>vertx-sql-client-codec</module>
         <module>vertx-oracle-client</module>
       </modules>
     </profile>
   </profiles>
 
-</project>
+</project>

vertx-db2-client/pom.xml

@@ -47,6 +47,10 @@
       <groupId>io.vertx</groupId>
       <artifactId>vertx-sql-client</artifactId>
     </dependency>
+    <dependency>
+      <groupId>io.vertx</groupId>
+      <artifactId>vertx-sql-client-codec</artifactId>
+    </dependency>
 
     <!-- Testing purposes -->
     <dependency>

vertx-db2-client/src/main/java/io/vertx/db2client/impl/DB2SocketConnection.java

@@ -31,11 +31,11 @@
 import io.vertx.db2client.impl.command.InitialHandshakeCommand;
 import io.vertx.db2client.impl.drda.ConnectionMetaData;
 import io.vertx.sqlclient.SqlConnectOptions;
-import io.vertx.sqlclient.impl.connection.CommandMessage;
+import io.vertx.sqlclient.codec.CommandMessage;
 import io.vertx.sqlclient.spi.connection.Connection;
 import io.vertx.sqlclient.internal.PreparedStatement;
 import io.vertx.sqlclient.internal.QueryResultHandler;
-import io.vertx.sqlclient.impl.connection.SocketConnectionBase;
+import io.vertx.sqlclient.codec.SocketConnectionBase;
 import io.vertx.sqlclient.spi.DatabaseMetadata;
 import io.vertx.sqlclient.spi.protocol.CommandBase;
 import io.vertx.sqlclient.spi.protocol.ExtendedQueryCommand;

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/CloseCursorCommandCodec.java

@@ -22,7 +22,7 @@
 import io.vertx.db2client.impl.drda.DRDAQueryRequest;
 import io.vertx.db2client.impl.drda.DRDAQueryResponse;
 import io.vertx.sqlclient.spi.protocol.CloseCursorCommand;
-import io.vertx.sqlclient.impl.connection.CommandResponse;
+import io.vertx.sqlclient.codec.CommandResponse;
 
 class CloseCursorCommandCodec extends CommandCodec<Void, CloseCursorCommand> {
 

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/CloseStatementCommandCodec.java

@@ -17,7 +17,7 @@
 
 import io.netty.buffer.ByteBuf;
 import io.vertx.sqlclient.spi.protocol.CloseStatementCommand;
-import io.vertx.sqlclient.impl.connection.CommandResponse;
+import io.vertx.sqlclient.codec.CommandResponse;
 
 class CloseStatementCommandCodec extends CommandCodec<Void, CloseStatementCommand> {
 

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/CommandCodec.java

@@ -19,12 +19,12 @@
 import io.vertx.core.Handler;
 import io.vertx.db2client.impl.command.InitialHandshakeCommand;
 import io.vertx.db2client.impl.command.PingCommand;
-import io.vertx.sqlclient.impl.connection.CommandMessage;
+import io.vertx.sqlclient.codec.CommandMessage;
 import io.vertx.sqlclient.spi.protocol.CloseConnectionCommand;
 import io.vertx.sqlclient.spi.protocol.CloseCursorCommand;
 import io.vertx.sqlclient.spi.protocol.CloseStatementCommand;
 import io.vertx.sqlclient.spi.protocol.CommandBase;
-import io.vertx.sqlclient.impl.connection.CommandResponse;
+import io.vertx.sqlclient.codec.CommandResponse;
 import io.vertx.sqlclient.spi.protocol.PrepareStatementCommand;
 import io.vertx.sqlclient.spi.protocol.SimpleQueryCommand;
 

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/DB2Decoder.java

@@ -25,7 +25,7 @@
 import io.vertx.core.internal.logging.Logger;
 import io.vertx.core.internal.logging.LoggerFactory;
 import io.vertx.db2client.DB2Exception;
-import io.vertx.sqlclient.impl.connection.CommandResponse;
+import io.vertx.sqlclient.codec.CommandResponse;
 
 class DB2Decoder extends ByteToMessageDecoder {
 

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/DB2Encoder.java

@@ -24,7 +24,7 @@
 import io.vertx.core.internal.logging.Logger;
 import io.vertx.core.internal.logging.LoggerFactory;
 import io.vertx.db2client.impl.DB2SocketConnection;
-import io.vertx.sqlclient.impl.connection.CommandResponse;
+import io.vertx.sqlclient.codec.CommandResponse;
 
 class DB2Encoder extends ChannelOutboundHandlerAdapter {
 

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/ExtendedBatchQueryCommandCodec.java

@@ -28,7 +28,7 @@
 import io.vertx.db2client.impl.drda.DRDAQueryResponse;
 import io.vertx.sqlclient.Tuple;
 import io.vertx.sqlclient.internal.TupleInternal;
-import io.vertx.sqlclient.impl.connection.CommandResponse;
+import io.vertx.sqlclient.codec.CommandResponse;
 import io.vertx.sqlclient.spi.protocol.ExtendedQueryCommand;
 
 public class ExtendedBatchQueryCommandCodec<R> extends ExtendedQueryCommandBaseCodec<R, ExtendedQueryCommand<R>> {

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/ExtendedQueryCommandBaseCodec.java

@@ -27,7 +27,7 @@
 import io.vertx.sqlclient.Row;
 import io.vertx.sqlclient.Tuple;
 import io.vertx.sqlclient.data.Numeric;
-import io.vertx.sqlclient.impl.connection.CommandResponse;
+import io.vertx.sqlclient.codec.CommandResponse;
 import io.vertx.sqlclient.spi.protocol.ExtendedQueryCommand;
 
 abstract class ExtendedQueryCommandBaseCodec<R, C extends ExtendedQueryCommand<R>>