Fix mssql containers setup

Failures could be seen both on the developer machine and on CI.

Microsoft has changed the path to the sqlcmd utility in the latest releases of the image.

Besides, they have made connecting on an encrypted connection with sqlcmd mandatory by default.
Therefore, we must configure the utility to make this optional (-No).

Also, when now certificate are always validated but test servers use self-signed certificates.
For this reason, the utility must not try to validate the server certificate (-C).

Lastly, unlike the mcr.microsoft.com/mssql/server image, the mcr.microsoft.com/mssql-tools image has not been updated.
So the latest image release still uses the old sqlcmd utility path and options.

To avoid discrepancies in our setup, we'll use the mcr.microsoft.com/mssql/server image everywhere from now on.
We don't care too much about the size, because we need this image to run the server anyway.

Signed-off-by: Thomas Segismont <[email protected]>

Author: tsegismont

vertx-mssql-client/docker/docker-compose.yml

@@ -10,14 +10,14 @@ services:
       TZ: UTC
       SA_PASSWORD: A_Str0ng_Required_Password
   test-mssql-initdb:
-    image: mcr.microsoft.com/mssql-tools
+    image: mcr.microsoft.com/mssql/server:${MSSQL_VERSION:-2019-latest}
     depends_on:
       - "test-mssql"
-    command: [ "sh", "/opt/mssql-tools/bin/initdb.sh","test-mssql,1433","A_Str0ng_Required_Password","/opt/data/init.sql" ]
+    command: [ "sh", "/opt/mssql-tools18/bin/initdb.sh","test-mssql,1433","A_Str0ng_Required_Password","/opt/data/init.sql" ]
     volumes:
       - type: bind
         source: ./initdb.sh
-        target: /opt/mssql-tools/bin/initdb.sh
+        target: /opt/mssql-tools18/bin/initdb.sh
         read_only: true
       - type: bind
         source: ../src/test/resources/init.sql

vertx-mssql-client/docker/initdb.sh

@@ -6,10 +6,10 @@ SERVER="$1"
 PASSWORD="$2"
 SQL_FILE="$3"
 
-until /opt/mssql-tools/bin/sqlcmd -l 1 -S $SERVER -U SA -P $PASSWORD -q "SELECT 1"; do
+until /opt/mssql-tools18/bin/sqlcmd -l 1 -S $SERVER -U SA -P $PASSWORD -C -No -q "SELECT 1"; do
   >&2 echo "MSSQL is unavailable - sleeping"
   sleep 1
 done
 
 >&2 echo "MSSQL is up - executing command"
-/opt/mssql-tools/bin/sqlcmd -S $SERVER -U SA -P $PASSWORD -i $SQL_FILE
+/opt/mssql-tools18/bin/sqlcmd -S $SERVER -U SA -P $PASSWORD -i $SQL_FILE -C -No

vertx-mssql-client/src/test/java/io/vertx/mssqlclient/junit/MSSQLRule.java

@@ -115,11 +115,12 @@ private MSSQLConnectOptions startMSSQL() throws IOException {
   private void initDb() throws IOException {
     try {
       ExecResult execResult = server.execInContainer(
-        "/opt/mssql-tools/bin/sqlcmd",
+        "/opt/mssql-tools18/bin/sqlcmd",
         "-S", "localhost",
         "-U", USER,
         "-P", PASSWORD,
-        "-i", INIT_SQL
+        "-i", INIT_SQL,
+        "-C", "-No"
       );
       if (execResult.getExitCode() != 0) {
         throw new RuntimeException(String.format("Failure while initializing database%nstdout:%s%nstderr:%s%n", execResult.getStdout(), execResult.getStderr()));