Skip to content

Commit a5160ca

Browse files
committed
Update to connection pool changes
1 parent 4551b37 commit a5160ca

File tree

1 file changed

+11
-16
lines changed

1 file changed

+11
-16
lines changed

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/pool/SqlConnectionPool.java

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,8 @@ public int size() {
151151

152152
public void evict() {
153153
long now = System.currentTimeMillis();
154-
pool.evict(conn -> conn.shouldEvict(now)).onComplete(ar -> {
155-
if (ar.succeeded()) {
156-
List<PooledConnection> res = ar.result();
154+
pool.evict(conn -> conn.shouldEvict(now), (res, err) -> {
155+
if (err == null) {
157156
for (PooledConnection conn : res) {
158157
conn.close(Promise.promise());
159158
}
@@ -187,8 +186,7 @@ public <R> void execute(CommandBase<R> cmd, Completable<R> handler) {
187186
ContextInternal context = vertx.getOrCreateContext();
188187
Promise<Lease<PooledConnection>> p = context.promise();
189188
Object metric = enqueueMetric();
190-
pool.acquire(context, 0)
191-
.onComplete(p);
189+
pool.acquire(context, 0, p);
192190
p.future().compose(lease -> {
193191
dequeueMetric(metric);
194192
PooledConnection pooled = lease.get();
@@ -254,9 +252,9 @@ private void handle(Lease<PooledConnection> lease) {
254252
public void onEnqueue(PoolWaiter<PooledConnection> waiter) {
255253
if (timeout > 0L && timerID == -1L) {
256254
timerID = context.setTimer(timeout, id -> {
257-
pool.cancel(waiter).onComplete(ar -> {
258-
if (ar.succeeded()) {
259-
if (ar.result()) {
255+
pool.cancel(waiter, (res, err) -> {
256+
if (err == null) {
257+
if (res) {
260258
handler.fail("Timeout");
261259
}
262260
} else {
@@ -274,17 +272,14 @@ public void onConnect(PoolWaiter<PooledConnection> waiter) {
274272
}
275273
Object metric = enqueueMetric();
276274
PoolRequest request = new PoolRequest(metric);
277-
pool.acquire(context, request, 0)
278-
.onComplete(request);
275+
pool.acquire(context, request, 0, request);
279276
}
280277

281278
public Future<Void> close() {
282279
Promise<Void> promise = vertx.promise();
283-
pool.close().onComplete(ar1 -> {
284-
if (ar1.succeeded()) {
285-
List<Future<Void>> results = ar1
286-
.result()
287-
.stream()
280+
pool.close((res, err) -> {
281+
if (err == null) {
282+
List<Future<Void>> results = res.stream()
288283
.map(connection -> connection
289284
.compose(pooled -> Future.<Void>future(p -> pooled.conn.close(pooled, p))))
290285
.collect(Collectors.toList());
@@ -293,7 +288,7 @@ public Future<Void> close() {
293288
.<Void>mapEmpty()
294289
.onComplete(promise);
295290
} else {
296-
promise.fail(ar1.cause());
291+
promise.fail(err);
297292
}
298293
});
299294
return promise.future();

0 commit comments

Comments
 (0)