null check missing for arrays of enums (#1505)

See #1470

Signed-off-by: Thomas Segismont <[email protected]>

Author: tsegismont

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/RowImpl.java

@@ -267,8 +267,12 @@ private Interval[] getArrayOfIntervals(int pos) {
     return (Interval[]) getValue(pos);
   }
 
+  @SuppressWarnings({"unchecked", "rawtypes"})
   private Object[] getArrayOfEnums(Class enumType, int pos) {
     Object val = getValue(pos);
+    if (val == null) {
+      return null;
+    }
     if (val instanceof String[]) {
       String[] array = (String[]) val;
       Object[] ret = (Object[]) Array.newInstance(enumType, array.length);
@@ -279,7 +283,8 @@ private Object[] getArrayOfEnums(Class enumType, int pos) {
         }
       }
       return ret;
-    } else if (val instanceof Number[]) {
+    }
+    if (val instanceof Number[]) {
       Number[] array = (Number[]) val;
       Object[] ret = (Object[]) Array.newInstance(enumType, array.length);
       Object[] constants = enumType.getEnumConstants();
@@ -293,8 +298,7 @@ private Object[] getArrayOfEnums(Class enumType, int pos) {
         }
       }
       return ret;
-    } else {
-      throw new ClassCastException();
     }
+    throw new ClassCastException();
   }
 }

vertx-pg-client/src/test/java/io/vertx/pgclient/data/JavaEnumTest.java

@@ -81,6 +81,22 @@ private void testJavaEnumToArrayColumn(TestContext ctx, String value, String sql
     }));
   }
 
+  @Test
+  public void testJavaEnumToNullArrayColumn(TestContext ctx) {
+    PgConnection.connect(vertx, options).onComplete(ctx.asyncAssertSuccess(conn -> {
+      conn
+        .preparedQuery("SELECT NULL")
+        .execute()
+        .onComplete(ctx.asyncAssertSuccess(v -> {
+          RowIterator<Row> it = v.iterator();
+          ctx.assertTrue(it.hasNext());
+          Row row = it.next();
+          Mood[] result = row.get(Mood[].class, 0);
+          ctx.assertNull(result);
+        }));
+    }));
+  }
+
   @Test
   public void testJavaEnumToEnumParam(TestContext ctx) {
     testJavaEnumToParam(ctx, "happy", "Mood");