Skip to content

Commit ac14e24

Browse files
committed
More cleanups, introduced a RowDescriptor interface to expose what is already there on the SqlResult.
1 parent 3f7862a commit ac14e24

File tree

32 files changed

+136
-83
lines changed

32 files changed

+136
-83
lines changed

vertx-db2-client/src/main/java/io/vertx/db2client/impl/DB2Row.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@
2929
import io.vertx.db2client.impl.drda.DB2RowId;
3030
import io.vertx.sqlclient.data.Numeric;
3131
import io.vertx.sqlclient.impl.RowBase;
32-
import io.vertx.sqlclient.internal.RowDescriptor;
32+
import io.vertx.sqlclient.internal.RowDescriptorBase;
3333

3434
public class DB2Row extends RowBase {
3535

36-
public DB2Row(RowDescriptor rowDescriptor) {
36+
public DB2Row(RowDescriptorBase rowDescriptor) {
3737
super(rowDescriptor);
3838
}
3939

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/DB2PreparedStatement.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import io.vertx.db2client.impl.drda.Cursor;
2525
import io.vertx.db2client.impl.drda.Section;
2626
import io.vertx.sqlclient.internal.PreparedStatement;
27-
import io.vertx.sqlclient.internal.RowDescriptor;
27+
import io.vertx.sqlclient.internal.RowDescriptorBase;
2828
import io.vertx.sqlclient.internal.TupleBase;
2929

3030
public class DB2PreparedStatement implements PreparedStatement {
@@ -58,7 +58,7 @@ public static class QueryInstance {
5858
}
5959

6060
@Override
61-
public RowDescriptor rowDesc() {
61+
public RowDescriptorBase rowDesc() {
6262
return rowDesc;
6363
}
6464

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/DB2RowDescriptor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
package io.vertx.db2client.impl.codec;
1717

1818
import io.vertx.db2client.impl.drda.ColumnMetaData;
19-
import io.vertx.sqlclient.internal.RowDescriptor;
19+
import io.vertx.sqlclient.internal.RowDescriptorBase;
2020

2121
import java.sql.JDBCType;
2222
import java.util.List;
2323

24-
class DB2RowDescriptor extends RowDescriptor {
24+
class DB2RowDescriptor extends RowDescriptorBase {
2525

2626
private final ColumnMetaData columnMetaData;
2727

vertx-db2-client/src/main/java/io/vertx/db2client/impl/codec/QueryCommandBaseCodec.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import io.netty.buffer.ByteBuf;
1919
import io.vertx.db2client.impl.drda.ColumnMetaData;
2020
import io.vertx.db2client.impl.drda.DRDAQueryRequest;
21-
import io.vertx.sqlclient.internal.RowDescriptor;
21+
import io.vertx.sqlclient.internal.RowDescriptorBase;
2222
import io.vertx.sqlclient.spi.protocol.QueryCommandBase;
2323

2424
abstract class QueryCommandBaseCodec<T, C extends QueryCommandBase<T>> extends CommandCodec<Boolean, C> {
@@ -79,7 +79,7 @@ void decodePayload(ByteBuf payload, int payloadLength) {
7979
void handleQueryResult(RowResultDecoder<?, T> decoder) {
8080
Throwable failure = decoder.complete();
8181
T result = decoder.result();
82-
RowDescriptor rowDescriptor = decoder.rowDesc;
82+
RowDescriptorBase rowDescriptor = decoder.rowDesc;
8383
int size = decoder.size();
8484
int updatedCount = decoder.size();
8585
decoder.reset();

vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/MSSQLRow.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import io.vertx.core.buffer.Buffer;
1515
import io.vertx.sqlclient.impl.RowBase;
16-
import io.vertx.sqlclient.internal.RowDescriptor;
16+
import io.vertx.sqlclient.internal.RowDescriptorBase;
1717

1818
import java.math.BigDecimal;
1919
import java.time.LocalDate;
@@ -25,7 +25,7 @@
2525

2626
public class MSSQLRow extends RowBase {
2727

28-
public MSSQLRow(RowDescriptor rowDescriptor) {
28+
public MSSQLRow(RowDescriptorBase rowDescriptor) {
2929
super(rowDescriptor);
3030
}
3131

vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/MSSQLPreparedStatement.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
package io.vertx.mssqlclient.impl.codec;
1313

1414
import io.vertx.sqlclient.internal.PreparedStatement;
15-
import io.vertx.sqlclient.internal.RowDescriptor;
15+
import io.vertx.sqlclient.internal.RowDescriptorBase;
1616

1717
public class MSSQLPreparedStatement implements PreparedStatement {
1818

@@ -24,7 +24,7 @@ public MSSQLPreparedStatement(String sql) {
2424
}
2525

2626
@Override
27-
public RowDescriptor rowDesc() {
27+
public RowDescriptorBase rowDesc() {
2828
throw new UnsupportedOperationException();
2929
}
3030

vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/MSSQLRowDescriptor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@
1111

1212
package io.vertx.mssqlclient.impl.codec;
1313

14-
import io.vertx.sqlclient.internal.RowDescriptor;
14+
import io.vertx.sqlclient.internal.RowDescriptorBase;
1515

1616
import java.util.Arrays;
1717

1818
/**
19-
* An implementation of {@link RowDescriptor} for MSSQL.
19+
* An implementation of {@link RowDescriptorBase} for MSSQL.
2020
* <p>
2121
* When reading rows with a cursor, an extra column named {@code ROWSTAT} is returned by the server.
2222
* This column should not be conveyed to the user so this class filters it out.
2323
*/
24-
public class MSSQLRowDescriptor extends RowDescriptor {
24+
public class MSSQLRowDescriptor extends RowDescriptorBase {
2525

2626
private final ColumnData[] columnDatas;
2727
private final boolean rowStat;

vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/QueryCommandBaseCodec.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import io.netty.buffer.ByteBuf;
1515
import io.vertx.sqlclient.Row;
16-
import io.vertx.sqlclient.internal.RowDescriptor;
16+
import io.vertx.sqlclient.internal.RowDescriptorBase;
1717
import io.vertx.sqlclient.spi.protocol.QueryCommandBase;
1818

1919
import java.util.stream.Collector;
@@ -58,7 +58,7 @@ protected void handleResultSetDone() {
5858
T result;
5959
Throwable failure;
6060
int size;
61-
RowDescriptor rowDescriptor;
61+
RowDescriptorBase rowDescriptor;
6262
if (rowResultDecoder != null) {
6363
failure = rowResultDecoder.complete();
6464
result = rowResultDecoder.result();

vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/MySQLRowDescriptor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818

1919
import io.vertx.mysqlclient.impl.datatype.DataFormat;
2020
import io.vertx.mysqlclient.impl.protocol.ColumnDefinition;
21-
import io.vertx.sqlclient.internal.RowDescriptor;
21+
import io.vertx.sqlclient.internal.RowDescriptorBase;
2222

23-
public class MySQLRowDescriptor extends RowDescriptor {
23+
public class MySQLRowDescriptor extends RowDescriptorBase {
2424

2525
private final ColumnDefinition[] columnDefinitions;
2626
private final DataFormat dataFormat;

vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/codec/MySQLPreparedStatement.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import io.vertx.sqlclient.Tuple;
2626
import io.vertx.sqlclient.impl.*;
2727
import io.vertx.sqlclient.internal.PreparedStatement;
28-
import io.vertx.sqlclient.internal.RowDescriptor;
28+
import io.vertx.sqlclient.internal.RowDescriptorBase;
2929
import io.vertx.sqlclient.internal.TupleBase;
3030

3131
import java.util.Arrays;
@@ -56,7 +56,7 @@ public class MySQLPreparedStatement implements PreparedStatement {
5656
}
5757

5858
@Override
59-
public RowDescriptor rowDesc() {
59+
public RowDescriptorBase rowDesc() {
6060
return rowDesc;
6161
}
6262

0 commit comments

Comments
 (0)