Skip to content

Commit c69b068

Browse files
committed
Ignore OracleMetricsTest#testQueuingXXX
Fails on Oracle Signed-off-by: Thomas Segismont <[email protected]>
1 parent df9b594 commit c69b068

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

vertx-oracle-client/src/test/java/io/vertx/oracleclient/test/tck/OracleMetricsTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ public void testPrepareAndBatchQuery(TestContext ctx) {
5757
super.testPrepareAndBatchQuery(ctx);
5858
}
5959

60+
@Test
61+
@Ignore("Implementation of the test does not work with Oracle")
62+
@Override
63+
public void testQueuing(TestContext ctx) throws Exception {
64+
super.testQueuing(ctx);
65+
}
66+
67+
@Test
68+
@Ignore("Implementation of the test does not work with Oracle")
69+
@Override
70+
public void testQueuingTimeout(TestContext ctx) throws Exception {
71+
super.testQueuingTimeout(ctx);
72+
}
73+
6074
@Test
6175
@Ignore("Implementation of the test does not work with Oracle")
6276
@Override

vertx-sql-client/src/test/java/io/vertx/sqlclient/tck/MetricsTestBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ public void end(Object inUseMetric, boolean succeeded) {
182182
futures.add(pool.withConnection(sqlConn -> sqlConn.query("SELECT * FROM immutable WHERE id=1").execute()));
183183
}
184184
awaitQueueSize(ctx, queueSize, timeout ? 0 : num);
185-
conn.close();
185+
Future.await(conn.close(), 20, SECONDS);
186186
Future.await(Future.join(futures).otherwiseEmpty(), 20, SECONDS);
187187
ctx.assertEquals(0, queueSize.get());
188188
ctx.assertEquals(0, inUse.get());

0 commit comments

Comments
 (0)